[Lime] 答复: AD review: draft-ietf-lime-yang-connectionless-oam-methods

Qin Wu <bill.wu@huawei.com> Fri, 01 September 2017 11:40 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: lime@ietfa.amsl.com
Delivered-To: lime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B86B132E67 for <lime@ietfa.amsl.com>; Fri, 1 Sep 2017 04:40:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xv-TFk2ejyGk for <lime@ietfa.amsl.com>; Fri, 1 Sep 2017 04:40:43 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7E00013263F for <lime@ietf.org>; Fri, 1 Sep 2017 04:40:41 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml709-cah.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DNS57347; Fri, 01 Sep 2017 11:40:39 +0000 (GMT)
Received: from NKGEML411-HUB.china.huawei.com (10.98.56.70) by lhreml709-cah.china.huawei.com (10.201.108.32) with Microsoft SMTP Server (TLS) id 14.3.301.0; Fri, 1 Sep 2017 12:40:38 +0100
Received: from NKGEML513-MBX.china.huawei.com ([169.254.1.219]) by nkgeml411-hub.china.huawei.com ([10.98.56.70]) with mapi id 14.03.0235.001; Fri, 1 Sep 2017 19:40:32 +0800
From: Qin Wu <bill.wu@huawei.com>
To: "lime@ietf.org" <lime@ietf.org>, bclaise <bclaise@cisco.com>
CC: "camoberg@cisco.com" <camoberg@cisco.com>, "janl@tail-f.com" <janl@tail-f.com>
Thread-Topic: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods
Thread-Index: AQHTIxcdsSoV0HwU9UaXwug93B6MvQ==
Date: Fri, 01 Sep 2017 11:40:31 +0000
Message-ID: <etPan.59a9472f.6b8b4567.255d@Qin-Wude-iPhone>
References: <da8af3c8-67f2-64e3-d9b7-d592db2d5eb5@cisco.com> <43b1244d-f834-4251-b930-4f2cb66d774c@cisco.com> <B8F9A780D330094D99AF023C5877DABA9AAEB827@nkgeml513-mbx.china.huawei.com>, <6e526577-160b-01c4-a67d-00d4f64b4906@cisco.com>
In-Reply-To: <6e526577-160b-01c4-a67d-00d4f64b4906@cisco.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Content-Type: multipart/alternative; boundary="_000_etPan59a9472f6b8b4567255dQinWudeiPhone_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.59A94737.01E2, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.1.219, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: a4d17ff0c688f6a4469aeedd9908f079
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/GDN7hI80HAzqGnDiPJRG5NZkRUc>
Subject: [Lime] 答复: AD review: draft-ietf-lime-yang-connectionless-oam-methods
X-BeenThere: lime@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Layer Independent OAM Management in Multi-Layer Environment \(LIME\) discussion list." <lime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lime>, <mailto:lime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lime/>
List-Post: <mailto:lime@ietf.org>
List-Help: <mailto:lime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lime>, <mailto:lime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Sep 2017 11:40:46 -0000

The warning comes from network instance yang model which is referenced in this draft. To fix it, network instance model draft should be updated.


Sent from HUAWEI AnyOffice
发件人: bclaise
收件人: Qin Wu; lime@ietf.org;
抄送: Carl Moberg (camoberg); Jan Lindblad;
主题: Re: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods
时间: 2017-09-01 19:23:18


Thanks Qin,

See in-line (I removed the addressed points).
Thank for valuable comments, your comments have been addressed in v-(06) with other comments on the list:
https://datatracker.ietf.org/doc/draft-ietf-lime-yang-connectionless-oam-methods/
Good, but I still see some warnings at http://www.claise.be/IETFYANGPageCompilation.html

-Qin
发件人: Lime [mailto:lime-bounces@ietf.org] 代表 Benoit Claise
发送时间: 2017年8月11日 23:12
收件人: lime@ietf.org<mailto:lime@ietf.org>
抄送: Carl Moberg (camoberg)
主题: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods

Dear all,

Here is my AD review.

- " This document presents a retrieval method YANG Data model for connectionless OAM protocols" is this right?

   rpc path-discovery {

         description

           "Generates path discovery as per RFC7276<https://tools.ietf.org/html/rfc7276>.";


   rpc continuity-check {

         if-feature coam:continuity-check;

         description

           "Generates continuity-check as per RFC7276<https://tools.ietf.org/html/rfc7276>.";
AFACT, the RPC triggers an "on-demand" (as opposed to proactive draft-ietf-lime-yang-connectionless-oam, to use the draft-ietf-lime-yang-connectionless-oam term) OAM mechanism and retrieves the results directly.
" This document presents a retrieval method YANG Data model for connectionless OAM protocols" makes it sound like "polling" the results, which could also be "proactive". You should improve the text
Please let me know how this has been addressed.
It seems that this draft is not only about a retrieval, but also an activation, in case of "on demand". I believe we should make it clear.
If we need a 5 min call (maybe I don't express myself correctly), don't hesitate to let me know.

After hours spent on the two LIME drafts ...
If the continuity-check RPC is really "on-demand", why do we have the session-type-enum as input?

 rpc continuity-check {

    if-feature "coam:continuity-check";

    description

      "Generates continuity-check as per RFC7276<https://tools.ietf.org/html/rfc7276>.";

    input {

      container destination-tp {

        uses coam:tp-address;

        description

          "Destination test point.";

      }

      uses coam:session-type;         <==============

      leaf source-interface {

        type if:interface-ref;

        description

          "Source interface.";

      }
From the other draft (why, btw?)

    grouping session-type {

      description

        "This object indicates the current session

         definition.";

      leaf session-type-enum {

        type enumeration {

          enum "proactive" {

            description

              "The current session is proactive";

          }

          enum "on-demand" {

            description

              "The current session is on-demand.";

          }

        }

        default "on-demand";

        description

          "Session type enum";

      }

    }
This should always be "on-demand", right?


Regards, Benoit