Re: [lisp] draft-ietf-lisp-yang

[Luigi Iannone <[e-mail]>]

Thanks Tom :-)

L.

> On Oct 13, 2023, at 13:56, tom petch <[e-mail]> wrote:
> 
> Some mostly non-technical thoughts on this I-D which caught my eye
> 
> Abstract I find a bit sparse - what does the YANG module enable a user to do?
> Configure, manage, monitor, ...
> 
> I like the choice of module names and prefixes - so often these are a melange.
> 
> In the YANG module
> 
> WG Web is ood
> as are the references to lisp-lcaf-10 but I think that those should be RFCYYYY or some such and not a URI
> 
> references to BSD license is ood
> 
> There is a mixture of XXX and XXXX which I think refer to the same I-D - consistency is good
> 
> I note you switched from Enumeration to Identity.  As I think you know, the former have stronger change control, the latter none so a vendor can add new roles.  I am not sure if this is a good idea.
> 
> You have the same string pattern five times; worth a derived type, unless you think that they are going to diverge
> 
> /locartors/locators/
> 
> references in the YANG module must appear in the I-D references; I do not see
> RFC2404
> RFC4868
> lisp-lcaf which I think should be RFCyyyy or some such
> IANA address family numbers
> 
> The IP addresses use the form that includes a zone of indeterminate length; is this intended?
> 
> reference clause for the revision should be to this document
> 
> IANA Considerations is double line spaced
> 
> HTH
> Tom Petch