Re: [lisp] YANG data models in LISP: extraction and compilation feedback
Benoit Claise <bclaise@cisco.com> Fri, 18 December 2015 09:24 UTC
Return-Path: <bclaise@cisco.com>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 235CA1B34D5; Fri, 18 Dec 2015 01:24:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0RpYiqLjui1J; Fri, 18 Dec 2015 01:24:51 -0800 (PST)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 805891B34D3; Fri, 18 Dec 2015 01:24:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=13814; q=dns/txt; s=iport; t=1450430691; x=1451640291; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to; bh=LeYu2r6EkT/LDuJjbw1pFvj5nHp3kyzF/xIsWcFWUJs=; b=BLGBDedVkuhZ3341kDTZhbY0vnXhaIQxJknXe91L/STqirwYUB7tNEiy /vV9hZsf9J64UxQNQBjCAjIwb1XMwNS2QIKz51K63eTvAYwoVGlHvJoF8 khccdzRjxgoMGBrybzBmDeg2wOBbbLMrP20p8hkX88MkYlVw3jPAIy02H w=;
X-IronPort-AV: E=Sophos;i="5.20,445,1444694400"; d="scan'208,217";a="609132378"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2015 09:24:47 +0000
Received: from [10.60.67.86] (ams-bclaise-8915.cisco.com [10.60.67.86]) by aer-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id tBI9OkRQ021354; Fri, 18 Dec 2015 09:24:47 GMT
To: "Vina Ermagan (vermagan)" <vermagan@cisco.com>, "lisp@ietf.org" <lisp@ietf.org>
References: <566AC980.10909@cisco.com> <D298D824.7245C%vermagan@cisco.com>
From: Benoit Claise <bclaise@cisco.com>
Message-ID: <5673D0DE.1040402@cisco.com>
Date: Fri, 18 Dec 2015 10:24:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <D298D824.7245C%vermagan@cisco.com>
Content-Type: multipart/alternative; boundary="------------030507080900050906050405"
Archived-At: <http://mailarchive.ietf.org/arch/msg/lisp/9e8jdag3_8voyM0xlN2kMoSmpdI>
Cc: "draft-ietf-lisp-yang@ietf.org" <draft-ietf-lisp-yang@ietf.org>, "yang-coord@ietf.org" <yang-coord@ietf.org>
Subject: Re: [lisp] YANG data models in LISP: extraction and compilation feedback
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp/>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Dec 2015 09:24:55 -0000
Thanks Vina, Well done. Regards, Benoit. > Hi Beniot, > > Thanks for the notification. The errors below should be fixed in the > new revision draft-ietf-lisp-yang-01 published today. I also tested > the new version with yangvalidator, and all seems to be fine. > > Thank you, > Vina > > From: "Benoit Claise (bclaise)" <bclaise@cisco.com > <mailto:bclaise@cisco.com>> > Date: Friday, December 11, 2015 5:02 AM > To: "lisp@ietf.org <mailto:lisp@ietf.org>" <lisp@ietf.org > <mailto:lisp@ietf.org>> > Cc: "draft-ietf-lisp-yang@ietf.org > <mailto:draft-ietf-lisp-yang@ietf.org>" <draft-ietf-lisp-yang@ietf.org > <mailto:draft-ietf-lisp-yang@ietf.org>>, "yang-coord@ietf.org > <mailto:yang-coord@ietf.org>" <yang-coord@ietf.org > <mailto:yang-coord@ietf.org>> > Subject: [lisp] YANG data models in LISP: extraction and compilation > feedback > > Dear all, > > I looked at the YANG model in the LISP WG document, from a > compilation point of view (NOT a YANG design point of view): > https://tools.ietf.org/html/draft-ietf-lisp-yang-00 > > First of, we can't extract your YANG models from the draft. > > Here are the extraction error messages: > xym.py draft-ietf-lisp-yang-00.txt > ERROR: 'draft-ietf-lisp-yang-00.txt', Line 138 - Yang module > 'ietf-lisp' with no <CODE BEGINS> and not starting with 'example-' > ERROR: 'draft-ietf-lisp-yang-00.txt', Line 1193 - Yang module > 'lisp-itr' with no <CODE BEGINS> and not starting with 'example-' > ERROR: 'draft-ietf-lisp-yang-00.txt', Line 1630 - Yang module > 'lisp-etr' with no <CODE BEGINS> and not starting with 'example-' > ERROR: 'draft-ietf-lisp-yang-00.txt', Line 2363 - Yang module > 'lisp-map-server' with no <CODE BEGINS> and not starting with > 'example-' > ERROR: 'draft-ietf-lisp-yang-00.txt', Line 2638 - Yang module > 'lisp-map-resolver' with no <CODE BEGINS> and not starting with > 'example-' > ERROR: 'draft-ietf-lisp-yang-00.txt', Line 3291 - Yang module > 'lisp-pitr' with no <CODE BEGINS> and not starting with 'example-' > ERROR: 'draft-ietf-lisp-yang-00.txt', Line 3548 - Yang module > 'lisp-petr' with no <CODE BEGINS> and not starting with 'example-' > ERROR: 'draft-ietf-lisp-yang-00.txt', Line 3651 - Yang module > 'lisp-address-types' with no <CODE BEGINS> and not starting with > 'example-' > > As mentioned in > https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-05, the > correct way to use <CODE BEGINS> <CODE ENDS> is > > The "<CODE BEGINS>" tag SHOULD be followed by a string identifying > the file name specified in Section 5.2 of > [I-D.ietf-netmod-rfc6020bis > <https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-05#ref-I-D.ietf-netmod-rfc6020bis>]. The following example is for the > '2010-01-18' revision of the 'ietf-foo' module: > > <CODE BEGINS> file"ietf-foo@2010-01-18.yang" > module ietf-foo { > // ... > revision 2010-01-18 { > description "Latest revision"; > reference "RFC XXXX"; > } > // ... > } > <CODE ENDS> > > > Note that the example YANG models should use the "example-" > prefix, and no <CODE BEGINS> <CODE ENDS> > > > Now, if I extract those modules anyway, you have some compilation > errors: > pyang --ietf *.yang > lisp-address-types.yang:1: warning: RFC 6087: 4.1: the module name > should start with one of the strings "ietf-" or "iana-" > lisp-etr.yang:1: warning: RFC 6087: 4.1: the module name should > start with one of the strings "ietf-" or "iana-" > lisp-itr.yang:1: warning: RFC 6087: 4.1: the module name should > start with one of the strings "ietf-" or "iana-" > lisp-map-resolver.yang:1: warning: RFC 6087: 4.1: the module name > should start with one of the strings "ietf-" or "iana-" > lisp-map-server.yang:1: warning: RFC 6087: 4.1: the module name > should start with one of the strings "ietf-" or "iana-" > lisp-petr.yang:1: warning: RFC 6087: 4.1: the module name should > start with one of the strings "ietf-" or "iana-" > lisp-pitr.yang:1: warning: RFC 6087: 4.1: the module name should > start with one of the strings "ietf-" or "iana-" > > Once you correct the extraction issues, the YANG models, along > with some remaining compilation errors, will appear at > http://www.claise.be/IETFYANGPageCompilation.html > > Finally, note that www.yangvalidator.com is your friend._ > _ > Regards, Benoit > > .
- [lisp] YANG data models in LISP: extraction and c… Benoit Claise
- Re: [lisp] YANG data models in LISP: extraction a… Vina Ermagan (vermagan)
- Re: [lisp] YANG data models in LISP: extraction a… Benoit Claise