Re: [lp-wan] Tsvart last call review of draft-ietf-lpwan-schc-over-nbiot-12

Ana Minaburo <ana@ackl.io> Thu, 03 November 2022 10:28 UTC

Return-Path: <ana@ackl.io>
X-Original-To: lp-wan@ietfa.amsl.com
Delivered-To: lp-wan@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD01FC15A734 for <lp-wan@ietfa.amsl.com>; Thu, 3 Nov 2022 03:28:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.908
X-Spam-Level:
X-Spam-Status: No, score=-1.908 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ackl-io.20210112.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VXwYXHy3a-gr for <lp-wan@ietfa.amsl.com>; Thu, 3 Nov 2022 03:28:00 -0700 (PDT)
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B1A5C14F733 for <lp-wan@ietf.org>; Thu, 3 Nov 2022 03:28:00 -0700 (PDT)
Received: by mail-lf1-x136.google.com with SMTP id d6so2014224lfs.10 for <lp-wan@ietf.org>; Thu, 03 Nov 2022 03:28:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ackl-io.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GSpLobHicq3ZFlCFS+5/c2s1IiISCRiOFxUhfTBU0P8=; b=HHp2dwWh+NFrXAjFOt80DofJfjppdBN5N7DbZlKHaJSdexPWQ5rT5DYZIUF+ZJcaFr qSY19/kVG7RXQeDWZ6ruBxBO6/mV1vZcmoRdAaAaC3s5xrwPpCrPkffSJCNUGWNX2ORi sxFkQhPvc2IPbIQQM/Iu0+do940uEI4oLFymYD3dnB4GJ4qixO47TQYbdMXE6gLheUAi 84tFXhLDWDX9AUqUjDDi5diO0zgRa+uK3cagCr73ePZUlHIGosoLypAn81F8aDgH64T3 VERxX6M/nfeR8bNnQotJu4LrjZPl9G6h70HTNrrO3uVGUEA5+7JVtMRMHIM06UEc16xl tQkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GSpLobHicq3ZFlCFS+5/c2s1IiISCRiOFxUhfTBU0P8=; b=4+Kb/FMfQH598VIwscIUjskaeqhFlrgzlul4A62iGHuJjvIwfEWU6GjCLRjQkz6+62 PFteikeuJiDlPZ00F189js6MUt9qgXSOXYkSqStcXC6hN9pJbPfziaHhDYGSkyFDuWgj Zxl3tJ9gR+2T4dLUCA3yDDb3eflTWE+Gb+r56vGJG9Gk2qzxESwamZt4dIjNIEqDZfUJ 1DuaIPO4uruBJ8xj9j8Tot04E68dWGCBEvM+AP9QhfcUc4aR66en5A0zVZLY2oEbxhW+ nWPNwZ/UVjaNoTwtvS81ki9A1tOyM93H2AnJ136q9TRlIETLH4AgMTfapbn6HA+9XkPM 3FJQ==
X-Gm-Message-State: ACrzQf1Z/JNUDlM2duTPozXog2O6HdEuk6GU6pcLM6BlAahMKNbbtg6P uusFmW1BwCak4n1pRbicmdivtmHGYIxIP9p6zN+dAw==
X-Google-Smtp-Source: AMsMyM73l6CnU/pNFvo1goFYpc6+hRawdgXGVs1a10Z/AQRiqCR4U9zLDsO0+q8sgUE+zrw+aPfnUCmjuZ3iYcGWfYk=
X-Received: by 2002:a19:a40d:0:b0:4b0:144:a246 with SMTP id q13-20020a19a40d000000b004b00144a246mr10804250lfc.416.1667471278494; Thu, 03 Nov 2022 03:27:58 -0700 (PDT)
MIME-Version: 1.0
References: <166622733693.62879.486546683551204677@ietfa.amsl.com>
In-Reply-To: <166622733693.62879.486546683551204677@ietfa.amsl.com>
From: Ana Minaburo <ana@ackl.io>
Date: Thu, 03 Nov 2022 11:27:31 +0100
Message-ID: <CAAbr+nTyX124nMgvQqk4ccX7uWzky-ov8wHZydmkgzTastyD4w@mail.gmail.com>
To: Spencer Dawkins <spencerdawkins.ietf@gmail.com>
Cc: tsv-art@ietf.org, draft-ietf-lpwan-schc-over-nbiot.all@ietf.org, last-call@ietf.org, lp-wan@ietf.org
Content-Type: multipart/alternative; boundary="0000000000003a69ec05ec8e6921"
Archived-At: <https://mailarchive.ietf.org/arch/msg/lp-wan/h57uAhIAoa8DVDq_EcDSTpVRLgc>
Subject: Re: [lp-wan] Tsvart last call review of draft-ietf-lpwan-schc-over-nbiot-12
X-BeenThere: lp-wan@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Low-Power Wide Area Networking \(LP-WAN\), also known as LPWA or Low-Rate WAN \(LR-WAN\)" <lp-wan.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lp-wan>, <mailto:lp-wan-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lp-wan/>
List-Post: <mailto:lp-wan@ietf.org>
List-Help: <mailto:lp-wan-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lp-wan>, <mailto:lp-wan-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Nov 2022 10:28:05 -0000

Dear Spencer,

Sorry for our delay. We want to thank you for your review. We are
publishing version 13 with all the IESG review inputs.
We have corrected the nits you bring out.
https://github.com/lp-wan/SCHC-NBIoT/blob/master/draft-ietf-lpwan-schc-over-nbiot-13.md

See our comments below.

Ana & Edgar

On Thu, Oct 20, 2022 at 3:01 AM Spencer Dawkins via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Spencer Dawkins
> Review result: Ready with Nits
>
> This document has been reviewed as part of the transport area review team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the
> document's
> authors and WG to allow them to address any issues raised and also to the
> IETF
> discussion list for information.
>
> When done at the time of IETF Last Call, the authors should consider this
> review as part of the last-call comments they receive. Please always CC
> tsv-art@ietf.org if you reply to or forward this review.
>
> This is a dense document, and that's probably unavoidable. I had a couple
> of
> technical questions, but most of what follows is about readability
> (including
> some sentences I couldn't parse). I could reasonably have marked this
> "ready
> with nits" - it's very close.
>
> Best wishes as you move this document forward.
>
> One general nit:
>
> I imagine the RFC Editor will suggest expanding the acronyms in the title.
>
[Ana] Done

>
> One point of confusion:
>
> I understand why some of the sections in this standards-track document are
> tagged as “informational”, but I’m confused why Section 5.4 is tagged as
> “normative”. Aren’t all of the sections in a standards-track document
> assumed
> to be normative?
>
[Ana]  the document has three parts:
- two informational about how 3GPP could use SCHC for their 'internal'
network
- one standard 'end to end' how any application developer must use SCHC
*over* the 3GPP public service (i.e., 3GPP network is fully unaware of SCHC
use)

We have modified the structure of the document to see if this is more
clear, see please version-13.

>
> One observation:
>
> As other reviewers have noted, this document is extremely acronym-dense,
> and I
> don’t think you can fix that (certainly not in a reasonable amount of
> time).
> Rather than ask for the impossible, I’d suggest adding a list at the
> beginning
> of the document that describes the structure of the document (something
> like an
> expanded table of contents), and calls attention to the very helpful
> Appendices, that people might not realize they should read as background.
>
[Ana] It is a very good input to define the structure of the document, this
will also help to understand the informative/normative parts.
We have add references to the appendix, and we have modified the structure
of the document, hoping this could simplify the lecture. We have improve
the terminology list too.
See please the link with version-13

>
> Under terminology:
>
> It would be helpful to include DoNAS and NAS in the Terminology section.
>
[Ana] Done

>
> “L2. Layer-2.”
>
> isn’t enlightening. I don’t have any objection to using “l2” or “layer 2”
> in
> this specification, but it’s probably better if you have a more useful
> definition for the terms.
>
[Ana] Yes, and in the NB-IoT architecture the layer 2 includes the PDCP,
RLC and MAC layers, so I've changed the terminology description of L2 to:
* L2. Layer-2 includes MAC, RLC and PDCP layers see {{AppendixA}}.
I've modified the definition on terminology too.

>
> Under Section 5:
>
> Is the concern about fragmentation in
>
> “The recommended 3GPP MTU size is 1358 bytes. The radio network protocols
> limit
> the packet sizes over the air, including radio protocol overhead, to 1600
> bytes. However, the recommended 3GPP MTU is smaller to avoid fragmentation
> in
> the network backbone due to the payload encryption size (multiple of 16)
> and
> the additional core transport overhead handling.”
>
> alleviated by RLC segmentation, as mentioned in 5.3? If so, it might be
> useful
> to have a forward pointer to 5.3.
>
[Ana] Done

>
> I couldn’t parse
>
> “In case SCHC is not standardized as a mandatory capability.”


> without guessing.

[Ana] yes, it is obvious, I delete the sentence.

>


> I couldn’t parse
>
> “And third use case, over the SCHC over Non-IP Data Delivery (NIDD)
> connection
> or at least up to the operator network edge, see Section 5.4.”
>
[Ana] changed to:
 “And third, over the SCHC over Non-IP Data Delivery (NIDD) connection
or at least up to the operator network edge, see Section 5.4.”
>
>
> without guessing.
>
> In
>
> “A non-IP transmission refers to other layer-2 transport.”,
>
> I wasn’t sure what “other” meant. Could you give an example of an
> alternative
> layer-2 transport?
>
[Ana]other layer-2 transport different from NB-IoT as Sigfox or LoRaWAN

>
> Under Section 5.3:
>
> Would it be helpful to provide a reference for “SCHC header compression” in
>
> “If 3GPP incorporates SCHC, it is recommended that these scenarios use SCHC
> header compression capability to optimize the data transmission”?
>
[Ana] Done

>
> (Is that defined in [TS36322]?)
>
[Ana] Yes, the TS36322 describes RLC layer, and part of the appendix
information has been taken from this document, the other documents used for
the appendix were the TS36323 for Packet Data Convergence Protocol (PDCP)
and TR36321 for Medium Access Control protocol (MAC)

>
> In Appendix A:
>
> As a 3GPP neophyte (and someone who rarely ventures outside SA technical
> working groups), I appreciate very much that you included this material in
> the
> draft. It’s very useful to someone on the outside of the technology. I’d
> suggest a couple of minor changes that would make it more useful
>
> In each of the subsections (A.1, A.2, A.3), could you include an
> appropriate
> reference early in the Subsection? I see that you’ve got those references
> in
> 5.1, but anyone who wants to start with the background that Appendix A
> provides, won’t see them unless they start searching.
>
[Ana] Done

>
> For the same reason, you might consider adding the acronyms in the
> subsection
> titles (A.1, A.2, A.3) to the Terminology section.
>
[Ana] Done

>
> In Appendix B:
>
> I’m not sure “somehow particular” is the right phrase in
>
> “The Access Stratum (AS) protocol stack used by DoNAS is somehow
> particular.
> Since the security associations are not established yet in the radio
> network,
> to reduce the protocol overhead, PDCP (Packet Data Convergence Protocol) is
> bypassed until AS security is activated. RLC (Radio Link Control protocol)
> uses
> by default the AM mode, but depending on the network's features and the
> terminal, it may change to other modes by the network operator.”
>
> Is the point that the AS protocol stack changes after AS security is
> activated?
> (That’s not a suggestion for replacement text)
>
[Ana] yes, it is very specific to this kind of transmission because we go
from control plane to data plane.
I changed the text to:
The Access Stratum (AS) protocol stack used by DoNAS is specific because
the radio network still needs to establish the security associations and
reduce the protocol overhead, so the PDCP (Packet Data Convergence
Protocol) is bypassed until AS security is activated. RLC (Radio Link
Control protocol) uses, by default, the AM mode, but depending on the
network's features and the terminal, it may change to other modes by the
network operator.