Re: [Lsr] Robert Wilton's Yes on draft-ietf-lsr-ospfv3-extended-lsa-yang-28: (with COMMENT)

Acee Lindem <acee.ietf@gmail.com> Thu, 01 February 2024 16:08 UTC

Return-Path: <acee.ietf@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61650C14F6BE; Thu, 1 Feb 2024 08:08:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KtzbF4WdUoiT; Thu, 1 Feb 2024 08:08:01 -0800 (PST)
Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 340D7C14CE27; Thu, 1 Feb 2024 08:07:48 -0800 (PST)
Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-785515724b5so5816185a.0; Thu, 01 Feb 2024 08:07:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706803667; x=1707408467; darn=ietf.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W3qIgYEeYFcEiyDeoYr5RrTDodpQ72/Jj6ssIoMYxhg=; b=OxTf/SHz40z1d3ZafXrXvSSU4/tA/gEtKJ8i2v3uwnsUvlJwIbgMDFuxMIwigP2i/S BUsW8cGIrn/uouJmaFzJglgqWCzrcnARnoBvOBaR4XJ+mLiTZ2hvS33aEtKbkGSiIL68 7ELoiKz3HOE/gtvggxWnSYq8PG7ymrAzBfaO1Da6FCSoBWBo2Fpu0CXRogsqDVhft+is QOJHsJdzRyQNCjmJPqjoSpyxuE1kHCANydEyB/FtpJycE2dvHbO7sbQpZ6GmCjQB9nU0 6oBmsZxbfU3uU2F2NH2LXOJnCI2Xcxa4SV5xf0M5OoDX3cYTmTpqKvSGAm1t3adXxPT+ 2g+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706803667; x=1707408467; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W3qIgYEeYFcEiyDeoYr5RrTDodpQ72/Jj6ssIoMYxhg=; b=uEx2ine3sNBxI3ZYDychBVPOKgJ+c3JW9ua+MecjOh43dGK1kGJ9UuYK+OoCrFqmit SUIef0LtqcbwR2c6zEu6pXAsJt9RHbOssUT6xIaTXuWhYZ8AIKHCmhiX0QItab6wsaS/ pNzDAqe2uVc/fvwHiRDBwRZQ44fn82xdOrj5gggGOW5BThXKQGXVMANf9pLdJ9j9JJKp LDcwDWBVA8JTxKI0/zBDANfPQYRwWYVw49POvliKPzskZF9bd5M3WuVY2bE2eZFEA07/ IlylIkpXjWjzAGJafyeV5NhvZjvcn+tpvX9aRNlXLTx5MKR7qUIsXSHOvFQz6CcK98ys /8qg==
X-Gm-Message-State: AOJu0Yx29U79+zzid1QpvXM502EFc9VKHN9+rG6kn13PkhAc9q6D8O2h 3gGdpZFMNjLYeL6hz7U3CnU6oXkhz+qsbCexa4YcD02Ovq4kYAjo
X-Google-Smtp-Source: AGHT+IF6767Vefad7FU1AXmxV54esk4U/F5gOTHzSfY1E80XfrhEynlEZIqNzU13otoW9aZuz1MqEQ==
X-Received: by 2002:a05:620a:2235:b0:783:bcdc:e2d1 with SMTP id n21-20020a05620a223500b00783bcdce2d1mr2584153qkh.70.1706803666906; Thu, 01 Feb 2024 08:07:46 -0800 (PST)
X-Forwarded-Encrypted: i=0; AJvYcCXLbPR0GkQR3XWWXOwceZcWyE/9STDasT38SZcHqPaQMVH9jeSkw/VKdwYkE+GyTDzZl+WTD6rhllS7YZYIaZ/tvGcy4GameGqihOgSBXGyrOVWhCr+s62DDMO5fAwgAicYdJTJ/ZYZzs3liw3URVm8nnicDCudAGAPqogfpv5drWlYoAugiKG45PKzgi1l91z9aFVUbn8=
Received: from smtpclient.apple ([136.54.28.118]) by smtp.gmail.com with ESMTPSA id c9-20020ae9e209000000b0078401adad7fsm3142438qkc.133.2024.02.01.08.07.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Feb 2024 08:07:46 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Acee Lindem <acee.ietf@gmail.com>
In-Reply-To: <170679668299.48388.3842134076926187440@ietfa.amsl.com>
Date: Thu, 01 Feb 2024 11:07:35 -0500
Cc: The IESG <iesg@ietf.org>, draft-ietf-lsr-ospfv3-extended-lsa-yang@ietf.org, lsr-chairs <lsr-chairs@ietf.org>, lsr <lsr@ietf.org>, Christian Hopps <chopps@chopps.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E2EE2032-59DD-4E14-B8A8-74A2E5243C46@gmail.com>
References: <170679668299.48388.3842134076926187440@ietfa.amsl.com>
To: Robert Wilton <rwilton@cisco.com>
X-Mailer: Apple Mail (2.3731.700.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/INeVOUcnqzbiIM7w7zLwkVxc7ig>
Subject: Re: [Lsr] Robert Wilton's Yes on draft-ietf-lsr-ospfv3-extended-lsa-yang-28: (with COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Feb 2024 16:08:02 -0000

Hi Rob,

> On Feb 1, 2024, at 9:11 AM, Robert Wilton via Datatracker <noreply@ietf.org> wrote:
> 
> Robert Wilton has entered the following ballot position for
> draft-ietf-lsr-ospfv3-extended-lsa-yang-28: Yes
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
> for more information about how to handle DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-extended-lsa-yang/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thanks for publishing another YANG model.
> 
> I do have a little sympathy to Roman's comment that having a bit more
> descriptive prose at the beginning of this document might be helpful to readers
> (i.e., I'm thinking in the order of one or two paragraphs).  But at the same
> time, I can also see that repeating (or perhaps summarising) what is already
> written in another RFC isn't necessarily that helpful, and having the details
> in the YANG module itself is arguably the most important and useful place
> because then the tooling can build appropriate GUI help text or user
> documentation.

I honestly don’t know what I’d add. While sometimes the abstract/introduction of documents do
not adequately articulate the document purpose and scope, the succinct text below is clear (at least to me):


      This document defines a YANG data model augmenting the IETF OSPF
      YANG model to provide support for OSPFv3 Link State Advertisement (LSA) Extensibility
      as defined in RFC 8362. OSPFv3 Extended LSAs provide extensible TLV-based LSAs for the
      base LSA types defined in RFC 5340.

What is missing here?

One area of confusion that it would be good for you to get the message out, is that operational state  is
typically validated prior to being returned and the data is typically not validated by the YANG infra-structure
(al though types must still match). As you know, this is being addressed in RFC 8407BIS. 


Thanks,
Acee


> 
> Regards,
> Rob
> 
> 
>