Re: [Lsr] AD Review of draft-ietf-ospf-te-link-attr-reuse-10

[Alvaro Retana <[e-mail]>]

On May 5, 2020 at 6:08:27 AM, Peter Psenak wrote:


Peter:

Hi!


...
> I tried to address all of them, some have been resolved during ISIS
> draft review, in which case I took the same resolution for this draf.
>
> Please see inline, look for ##PP


There's only one outstanding comment that I don't think was answered
-- or at least I missed the meaning of the answer.  Please see below.


I am also including some comments based on -11.  Except for the
Normative language in §12.1, all the comments are basically
nits/suggestions.


I am starting the IETF Last Call for this document and
draft-ietf-isis-te-app.  We can work on these remaining comments while
we do that.

Thanks!

Alvaro.



...
> 434 6. Local Interface IPv6 Address Sub-TLV
>
> [major] The Local/Remote Interface IPv6 Address Sub-TLVs (rfc5329) can
> include multiple addresses for a link. It seems to me that it could
> be possible for different applications to use different addresses. If
> that is the case, then it seems that these sub-TLVs should not be
> application independent. Why are they not considered to be
> application specific?
>
> [minor] Why are IPv4 addresses not considered?
>
> ##PP
> IPv4 local address is part of the basic spec.
> IPv6 remote address has been added in rfc8379.

For IPv4: what basic spec?

For IPv6: rfc8379 doesn’t seem to relate to the questions — am I
missing something?





[Line numbers from idnits]

draft-ietf-ospf-te-link-attr-reuse-11

...
168	4.1.  OSPFv2 Extended Link Opaque LSA and OSPFv3 E-Router-LSA
...
184	   3.  There is clear distinction between link attributes used by RSVP-
185	       TE and link attributes used by other OSPFv2 or OSPFv3
186	       applications.

[nit] s/is clear distinction/is a clear distinction


...
203	   TE link attributes used for RSVP-TE/GMPLS continue use OSPFv2 TE
204	   Opaque LSA [RFC3630] and OSPFv3 Intra-Area-TE-LSA [RFC5329].

[nit] s/continue use/continue to use


...
213	5.  Advertisement of Application Specific Values
...
252	      SABM Length: Standard Application Identifier Bit-Mask Length in
253	      octets.  The legal values are 0, 4 or 8.  If the Standard
254	      Application Bit-Mask is not present, the Standard Application Bit-
255	      Mask Length MUST be set to 0.

257	      UDABM Length: User Defined Application Identifier Bit-Mask Length
258	      in octets.  The legal values are 0, 4 or 8.  If the User Defined
259	      Application Bit-Mask is not present, the User Defined Application
260	      Bit-Mask Length MUST be set to 0.

[minor] "The legal values are 0, 4 or 8."  Should the statement be
Normative ("MUST be...")?  I know there is a sentence below about
ignoring the sub-TLV if a different value is received -- IOW, just a
suggestion.


...
319	      - Unidirectional Link Dela [RFC7471]

321	      - Min/Max Unidirectional Link Delay [RFC7471]
322	      - Unidirectional Delay Variation [RFC7471]

[nit] There seems to be a line missing...


...
532	12.1.  Use of Legacy RSVP-TE LSA Advertisements

534	   Bit Identifiers for Standard Applications are defined in Section 5.
535	   All of the identifiers defined in this document are associated with
536	   applications which were already deployed in some networks prior to
537	   the writing of this document.  Therefore, such applications have been
538	   deployed using the RSVP-TE LSA advertisements.  The Standard
539	   Applications defined in this document MAY continue to use RSVP-TE LSA
540	   advertisements for a given link so long as at least one of the
541	   following conditions is true:

[major] s/MAY/may


...
651	12.3.4.  Use of Application Specific Advertisements for RSVP-TE

653	   The extensions defined in this document support RSVP-TE as one of the
654	   supported applications.  It is however RECOMMENDED to advertise all
655	   link-attributes for RSVP-TE in the existing OSPFv2 TE Opaque LSA
656	   [RFC3630] and OSPFv3 Intra-Area-TE-LSA [RFC5329] to maintain backward
657	   compatibility.  RSVP-TE can eventually utilize the application
658	   specific advertisements for newly defined link attributes, which are
659	   defined as application specific.

[minor] "It is however RECOMMENDED to advertise all link-attributes
for RSVP-TE in the existing..."  The application specific
advertisements can be used and result in duplicate information.  The
ISIS draft includes some sample steps to eliminate redundancy and get
rid of the legacy advertisements -- can we add something similar here?