Re: [Lsr] Martin Duke's No Objection on draft-ietf-ospf-te-link-attr-reuse-14: (with COMMENT)

Peter Psenak <ppsenak@cisco.com> Tue, 09 June 2020 09:05 UTC

Return-Path: <ppsenak@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92D473A0B5E; Tue, 9 Jun 2020 02:05:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.601
X-Spam-Level:
X-Spam-Status: No, score=-9.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eJcjxjLd-v9M; Tue, 9 Jun 2020 02:05:12 -0700 (PDT)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E1053A0993; Tue, 9 Jun 2020 02:05:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1428; q=dns/txt; s=iport; t=1591693511; x=1592903111; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=pH+7+T+56ibtYfOFF3h5mSo7rEwnfN+u5hZrcGb3Yno=; b=TXv9UrpvhQEXQK/w5EVbIvRz4FLlbEHJShQ0E/npt7+jMUmI8B9xr1Cd JA/q3UQcRgrTtJ5jqgxR8i/eSRcxyyDj1k7/PxY9h//cO9qxLf2HPYEi1 gPYjKeRPvH44oGCbCfVkQDBJIYWdHaQmY6vMZN+rIdJbxpSInka8zfWDD w=;
X-IronPort-AV: E=Sophos;i="5.73,491,1583193600"; d="scan'208";a="24528972"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 09 Jun 2020 09:05:09 +0000
Received: from [10.60.140.51] (ams-ppsenak-nitro2.cisco.com [10.60.140.51]) by aer-core-4.cisco.com (8.15.2/8.15.2) with ESMTP id 059958P4016900; Tue, 9 Jun 2020 09:05:09 GMT
To: Martin Duke <martin.h.duke@gmail.com>, The IESG <iesg@ietf.org>
Cc: draft-ietf-ospf-te-link-attr-reuse@ietf.org, lsr-chairs@ietf.org, lsr@ietf.org, Acee Lindem <acee@cisco.com>, Yingzhen Qu <yingzhen.qu@futurewei.com>, aretana.ietf@gmail.com
References: <159168566731.4247.14973726690285486076@ietfa.amsl.com>
From: Peter Psenak <ppsenak@cisco.com>
Message-ID: <89107651-b54d-d707-79fd-774c156cc8b5@cisco.com>
Date: Tue, 09 Jun 2020 11:05:08 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <159168566731.4247.14973726690285486076@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Outbound-SMTP-Client: 10.60.140.51, ams-ppsenak-nitro2.cisco.com
X-Outbound-Node: aer-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/L_SMwSYMx0LrbjJyCvmaCXx02ns>
Subject: Re: [Lsr] Martin Duke's No Objection on draft-ietf-ospf-te-link-attr-reuse-14: (with COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2020 09:05:14 -0000

Hi Martin,

On 09/06/2020 08:54, Martin Duke via Datatracker wrote:
> Martin Duke has entered the following ballot position for
> draft-ietf-ospf-te-link-attr-reuse-14: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-ospf-te-link-attr-reuse/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> The link attributes are sub-sub-TLVs, but are sections 6 and 7 constantly refer
> to them as “TLV types”, which seems imprecise.

well, sub-sub-TLV is a TLV and has a TLV type. I don't see a problem 
with the existing language, but if you feel strongly, I can replace it 
with "sub-sub-TLV types".

> 
> Nits:
> 
> S/other then/other than

fixed.

thanks,
Peter

> 
> Throughout this document, the indefinite and definite articles ‘a’, ‘an’, and
> ‘the’ are often missing  where needed and present where not needed.
> 
> 
> 
> 
>