Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-04.txt

"Acee Lindem (acee)" <acee@cisco.com> Tue, 29 September 2020 21:45 UTC

Return-Path: <acee@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0A5C43A122B for <lsr@ietfa.amsl.com>; Tue, 29 Sep 2020 14:45:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.598
X-Spam-Level:
X-Spam-Status: No, score=-9.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=M6PmXZxb; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=ml7lCd2Y
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oQ3OYeCXZJnz for <lsr@ietfa.amsl.com>; Tue, 29 Sep 2020 14:45:00 -0700 (PDT)
Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ECF4E3A1158 for <lsr@ietf.org>; Tue, 29 Sep 2020 14:44:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5392; q=dns/txt; s=iport; t=1601415899; x=1602625499; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Zl6LJ6MuDbRZ8CwVgmPjrr7cK9P2ea5R7k3YcS4FIus=; b=M6PmXZxba4OkT+Ml6gzrhXC625qF653A5xNH9oQfYfDEAPGkpxGm5SYN rKIZA1fnyYVLoQSVvFSnAd2EinIxHQSv99j7ObXZi/wrpbJpzq0zVTEtF 04tEau1VZaVRmaOFFxxDzXTKJn3LIU37tSrTunxFohl0jiXfiMo+wqwIz o=;
X-IPAS-Result: =?us-ascii?q?A0AmHADsqXNf/4wNJK1XCR4BAQsSDECBUYFQIy4HcFkvL?= =?us-ascii?q?AqEM4NGA41YJph3gS+BJANVCwEBAQ0BARgNCAIEAQGESwIXghgCJToEDQIDA?= =?us-ascii?q?QEBAwIDAQEBAQUBAQECAQYEbYVcDIVyAQEBAQMBARAREQwBASwLAQ8CAQgVA?= =?us-ascii?q?QQCJgICAiULFRACBAENBSKDBAGCSwMuAQ6qLQKBOYhhdoEygwEBAQWBNwIOQ?= =?us-ascii?q?UOCQhiCEAmBDiqCcoNphlMbggCBEScMEIJNPoJcAQECAQEVgRosgxczgi2TO?= =?us-ascii?q?YclnGgKgmeIe5FcAx+DDYEoiFaUCJMJimuVIwIEAgQFAg4BAQWBbg4SgVdwF?= =?us-ascii?q?RohKgGCPglHFwINjh8MF4NOhRSFQnQ3AgYBCQEBAwl8jC0BgRABAQ?=
IronPort-PHdr: =?us-ascii?q?9a23=3A+MmJ8RzIWB8DhWDXCy+N+z0EezQntrPoPwUc9p?= =?us-ascii?q?sgjfdUf7+++4j5ZRaFt/9xh1jPW4jQ97RPjO+F+6zjWGlV55GHvThCdZFXTB?= =?us-ascii?q?YKhI0QmBBoG8+KD0D3bZuIJyw3FchPThlpqne8N0UGEtr1YFvUr3auqzUVH0?= =?us-ascii?q?a3OQ98PO+gHInUgoy+3Pyz/JuGZQJOiXK9bLp+IQ/wox/Ws5wdgJBpLeA6zR?= =?us-ascii?q?6arw=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.77,319,1596499200"; d="scan'208";a="543022161"
Received: from alln-core-7.cisco.com ([173.36.13.140]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 29 Sep 2020 21:44:58 +0000
Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by alln-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id 08TLiwx6012945 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 29 Sep 2020 21:44:58 GMT
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 29 Sep 2020 16:44:58 -0500
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 29 Sep 2020 17:44:57 -0400
Received: from NAM04-BN3-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 29 Sep 2020 17:44:57 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kRjpDXwI16jbTFUajBhx8D8WGAyJceyVPMfM6ezHCIFDAQbAewFPRq+8qewmhvC4hcNDthgW/biQut9QaNU3ujcRIEvzkBiJdxYZFaoJx12UVQ053c9BEH9A068+OsX9bzhkGfIquMW6p1nIjtMqmRnxrCvmVPOz0NWxVdHayrhMGzjozUpvFq1jLLvqpAMKZ9Hs4LMusUSV2W/16sgxYDGD0sGqg5Im7gj0K+Rmvi7B3UDw0VIBFL0qPgsWSyhVVWxtrncRlEGDESBkXmNlDSlKnk41iUMMDRiNPJ7ZOUimqRHLZxqJ+6HD9fkY9H12KzUDRQkd5XbherkuqabVkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zl6LJ6MuDbRZ8CwVgmPjrr7cK9P2ea5R7k3YcS4FIus=; b=hsyuKww5fhF8bd0Oe074p4xtg6+dXcJD5kFTAeinzhsF+cvdBht3gK7iFBLvWljDxVYoCbPPz+NnJLo2MDK/JNpS78vLyplcakr1OnD1OzHZ9fjcsqRcHZXwuy9W1BoCuHXf9kAo18YHh8Yp5wJzKDnKrpTgy20X754ScwNqLMsK0T7HOULoXtsI7QyDJJr5NRvZNPFVW0X9w+Z74IvtFN7H1QRJI4mIZ/P/sFSB435bFY2sRL74JZYxlVYkhdytWMjmX3Pyrmy2toILtVPmchxd5deox7ygJzj3uBp+TgAXgj1IbfC30rbE9L9Zpyb48rs4XrV3PF6E98/Q1LHsuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zl6LJ6MuDbRZ8CwVgmPjrr7cK9P2ea5R7k3YcS4FIus=; b=ml7lCd2YYMYH53/2F+FNMqP6tMGLw3NP2x7Yp92QFub135wshh6IDIjqxukesni4gDU51q0HdrzcMwxfRkLa0h4ZtHBssPjOUuUNfZrUVa2sGTWIz1lY5LEZxSIzHunrMDAqns2oMozUcqUfnwdA4tumHrYMjal/FnM+a7/N9i0=
Received: from BYAPR11MB2887.namprd11.prod.outlook.com (2603:10b6:a03:89::27) by BYAPR11MB3574.namprd11.prod.outlook.com (2603:10b6:a03:b1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.25; Tue, 29 Sep 2020 21:44:55 +0000
Received: from BYAPR11MB2887.namprd11.prod.outlook.com ([fe80::1ddc:cdb4:32cc:f078]) by BYAPR11MB2887.namprd11.prod.outlook.com ([fe80::1ddc:cdb4:32cc:f078%3]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 21:44:55 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: tom petch <ietfc@btconnect.com>, "lsr@ietf.org" <lsr@ietf.org>
CC: Yingzhen Qu <yingzhen.qu@futurewei.com>
Thread-Topic: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-04.txt
Thread-Index: AQHWcSut5NtSKq9iwkm7KpdB3W6cTak1z3yAgEpeo4A=
Date: Tue, 29 Sep 2020 21:44:55 +0000
Message-ID: <316D1B5E-F709-4598-8998-4F6368569CD1@cisco.com>
References: <159729345724.32598.10798369052469436120@ietfa.amsl.com> <AM7PR07MB62480BC77EABB838C031CA20A0430@AM7PR07MB6248.eurprd07.prod.outlook.com>
In-Reply-To: <AM7PR07MB62480BC77EABB838C031CA20A0430@AM7PR07MB6248.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.41.20091302
authentication-results: btconnect.com; dkim=none (message not signed) header.d=none;btconnect.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [136.56.133.70]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 82fd9eba-94b3-4f4a-817c-08d864c0e7a6
x-ms-traffictypediagnostic: BYAPR11MB3574:
x-microsoft-antispam-prvs: <BYAPR11MB35749F035C9EEBF84DAC65E9C2320@BYAPR11MB3574.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +pa6OKT5BFgrGjueLLoyz7+cCuKf2fOS6l1SEUCTFhIaLMjfGO+zg1Y+KvrBmNK54huGUp1eDSKYm3k+hQH3eQGP24+07G3kyqja0krgONdVY4as8rQLeZaXFuEWloXNnzZ4+0awJLsCD3dv7jZw0U7qWM4U3Hjw4dTu8HLQ6WWRgoS3Gfft5IbXNCv7No5COQyOE3CiPBTVQwwEzacW+keky5hXgcbgPQ+npucE4caVyf8B1C9YmHZPC1oXiIfpFQYb+NM6fcw/VfkgPHTvgDTO7QAKq3pd48784mzzn8f0zbUtPtPRU1pmTNohKwYDN5lqqj/YhLbr6T8GIwA4JoZ45VUREthOCAwLqwBcH9fWIzx5/2glB1ab0hu3OSWp6bjE2EKrUH23KMB3hop4bt1jpyzcdRj93wnD2eFvQwTWH1WNZzSxxuiMSMCIaTdO
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2887.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(366004)(39860400002)(376002)(346002)(136003)(6486002)(4326008)(5660300002)(66476007)(66446008)(6506007)(66556008)(26005)(64756008)(71200400001)(8676002)(36756003)(110136005)(2906002)(296002)(66946007)(76116006)(316002)(186003)(8936002)(966005)(66574015)(2616005)(6512007)(83380400001)(86362001)(33656002)(478600001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: EyuHSJuq/TqZE3cBI23k1cC0Bre+q1IqBXxLW+xEmqZ/QGf6NHpXUtiSc7/4YeYCEK2mTo2uKNxTVDCGLrcaJivuMMbS39M4K/vGZIc4pGx6/ajlqnC9MdNhjDASwLCWMh6z7jLnCEzYSpA+W7a/2NpkAMtT6RCqT6LSrwBECSh9ZKYZuw4zxg1DVjHc7+PDG3bLhIFp9VgzIzR4kTaxtH1kLlvTHyZUiVQuxhqRH2mgv0l2x4aeZ+1Cdzyl77FGLobDEk2/gzZIIoIK7n39t4mg1V1R96E9LfdcZyQsrqze18uF85vl2t1qNwRNiFbXzCq2bISc+2GU+B7SYQC47krLoe9ufg4pW0nkxciQLp1MLEJ4r+pmmMyHq2hACqlKvRIOHMvDH7DIycuDjC5UG4BJBhfWcwi4h/e523ouZ0fZNG4sgNA3yD/3HBHrEZ6nQe9uCXqPfpoHxmtpP94lgSpZVPIu4+WKiEBV8A1e4rL5zODao6Em75rGUYUuW1VHN3qk7aiqeHfyu00cBmAwgJOI8dr9NsCJDyYvJw8fTg+1Vr7zjbOLsc2RxH1umoUqqKQPoIWB+knu+DyDVELQSPDmqSX2y9ezULTm7+04WSN7+2AzHcMvbwIGG0yROxVXaSGo501nJ/RUxhbByfVutg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <54FEA07632941C4DB87E97A1052D43AB@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2887.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82fd9eba-94b3-4f4a-817c-08d864c0e7a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 21:44:55.5063 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9WRbAU2dI6tXc8iLgXNcBFJLYSPK9vX+MzOzQ2BmwDyOFSevmOTJUXSBUzOoe9Hm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3574
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.14, xch-aln-004.cisco.com
X-Outbound-Node: alln-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/VL6mheQgXXtAJLWcCHp6InSW5Eg>
Subject: Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-04.txt
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2020 21:45:02 -0000

Hi Tom, 

We can add the references. See ACEE>. 

On 8/13/20, 6:03 AM, "Lsr on behalf of tom petch" <lsr-bounces@ietf.org on behalf of ietfc@btconnect.com> wrote:

    From: Lsr <lsr-bounces@ietf.org> on behalf of internet-drafts@ietf.org <internet-drafts@ietf.org>
    Sent: 13 August 2020 05:37

    I said before that it was tough to review because of a lack of references in the YANG module and that remains true.
    You have two Boolean to enable extended LSA on for ospf, one for area.  Yes, the answer is in RFC8362 but it tells me the YANG module is wrong - and it took me some time to find it.  RFC8362 defines two parameters ExtendedLSASupport and AreaExtendedLSASupport and the latter is not in the model; yes you have a Boolean under area but I think its meaning requires a reading of RFC8362 Appendix B and that is missing and the description is unclear and the name is wrong.  Also the RFC has a SHOULD in it which the model does not implement.  You reference s.6.2 but I think that wrong, that it is Appendices A and B that describe this.

ACEE> What is the SHOULD that isn't implemented? 

    On type, you say there are three possible values. Precisely.  Can you have the type set to 'ospf' and support ospfv3?  If so, your model fails.  Or does ospf-yang only allow the type to be ospfv2 or ospfv3 and bar the use of ospf per se?

ACEE>"ospf" is the base identity for  "ospfv2" and "ospfv3". So, if a container is applicable to both, no when constraint is needed. However, if it is applicable to the one or the other, a "when" constraint. It is common to do this in YANG. This module is applicable only to OSPFv3. 


    The reference statement after the description could do with a title as you have for the revision description

    My point about link type is that you are augmenting ospf-yang which uses an enum so in places users will be required to use an enum and in others a uint8 which could be confusing

ACEE> I don't get this. We don’t augment link-type. 

Thanks,
Acee

    Tom Petch

    A New Internet-Draft is available from the on-line Internet-Drafts directories.
    This draft is a work item of the Link State Routing WG of the IETF.

            Title           : YANG Model for OSPFv3 Extended LSAs
            Authors         : Acee Lindem
                              Sharmila Palani
                              Yingzhen Qu
            Filename        : draft-ietf-lsr-ospfv3-extended-lsa-yang-04.txt
            Pages           : 27
            Date            : 2020-08-12

    Abstract:
       This document defines a YANG data model augmenting the IETF OSPF YANG
       model to provide support for OSPFv3 Link State Advertisement (LSA)
       Extensibility as defined in RFC 8362.  OSPFv3 Extended LSAs provide
       extensible TLV-based LSAs for the base LSA types defined in RFC 5340.


    The IETF datatracker status page for this draft is:
    https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-extended-lsa-yang/

    There are also htmlized versions available at:
    https://tools.ietf.org/html/draft-ietf-lsr-ospfv3-extended-lsa-yang-04
    https://datatracker.ietf.org/doc/html/draft-ietf-lsr-ospfv3-extended-lsa-yang-04

    A diff from the previous version is available at:
    https://www.ietf.org/rfcdiff?url2=draft-ietf-lsr-ospfv3-extended-lsa-yang-04


    Please note that it may take a couple of minutes from the time of submission
    until the htmlized version and diff are available at tools.ietf.org.

    Internet-Drafts are also available by anonymous FTP at:
    ftp://ftp.ietf.org/internet-drafts/


    _______________________________________________
    Lsr mailing list
    Lsr@ietf.org
    https://www.ietf.org/mailman/listinfo/lsr

    _______________________________________________
    Lsr mailing list
    Lsr@ietf.org
    https://www.ietf.org/mailman/listinfo/lsr