Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-04.txt
tom petch <ietfc@btconnect.com> Thu, 13 August 2020 10:03 UTC
Return-Path: <ietfc@btconnect.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D70DA3A0B32 for <lsr@ietfa.amsl.com>; Thu, 13 Aug 2020 03:03:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xYSbMJa8FRYl for <lsr@ietfa.amsl.com>; Thu, 13 Aug 2020 03:02:59 -0700 (PDT)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80120.outbound.protection.outlook.com [40.107.8.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D3983A0B2F for <lsr@ietf.org>; Thu, 13 Aug 2020 03:02:58 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWSrCMoqY61t2xUslkbQ4NZBmqq1Sk64M/5PRxIcRo5zPr7TRoe42OW9CIB02fecw+wlRr0HC8pX5jzlNH6Cu+s3HerRkTgfcpku7B94RhWL3D50Gynmd2BpaO2/frziKB14i6LzKbl6ONOqFroEZ3SKowtC6oLzXse3aSCyiznCeeiz+JsxSJc2eyHyJwvAklRtdx7zU3eeJX5dKovHGFLm6ecXgxbas0i9cndHQvwWw+ir/LeTJgtB4+c6LA8J86HPAJBzTD2B3rI5jzT0L6Gfm6JMmTisg+LNFdspOxm1jUOMpRACwIGRcxlwgtcAFS4EFBmJHPWwemm9xFzGdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wbl0v2R2CvKwjYxkXBrb4mwLlHcMR3RbniEh7w/9S/I=; b=Ut8kiN2NZGDKU3S45Gl3RfKmqYHQZ+pbLkmobuhUZX4Ulv45IBB0p3AXmqulPVO1eGgoXTIMMheHfKA+4qgCi9Z2FEc+4KJq2K3k2EqULI5gbR8KqLmdZnseGdX5c5Ozv7ajIGHt+6ka9kYC0D7OSY+CAscbgLHho1fCWTIuZHr/odMpa5TF6WAMmiQqUtdfhALBCwYYEmS5VGG0mikDkI6ty6pJOdlFSkwvKZWT3LCCMGtN92jztHYuPQAWvcIVEb+D+J2p94QS128595RJEv7lsdMRgLW/lTZXcDO5MawZMGt0uDAVzk2A1qdLWujreUoRIy9HyvW/yRBksrEs4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wbl0v2R2CvKwjYxkXBrb4mwLlHcMR3RbniEh7w/9S/I=; b=MtpJQ/f5oMushsdeA5Vq1LLzO+hjfC33fveAL4TjcJCnx0xhdnbA+DCZoSQmCkBFzIf6zNpYozcEBb2bI5KxixjX3wGJkWeUMJIL9Jm4Wgb83N4X+ljDsevLS4KgI+01pMiL6VEetx0+0HvcvdZRYeuz/YnZhhl7PbYhAGXhsXY=
Received: from AM7PR07MB6248.eurprd07.prod.outlook.com (2603:10a6:20b:134::11) by AM6PR07MB3847.eurprd07.prod.outlook.com (2603:10a6:209:31::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.11; Thu, 13 Aug 2020 10:02:55 +0000
Received: from AM7PR07MB6248.eurprd07.prod.outlook.com ([fe80::b570:437a:db46:400a]) by AM7PR07MB6248.eurprd07.prod.outlook.com ([fe80::b570:437a:db46:400a%9]) with mapi id 15.20.3283.014; Thu, 13 Aug 2020 10:02:55 +0000
From: tom petch <ietfc@btconnect.com>
To: "lsr@ietf.org" <lsr@ietf.org>
CC: Yingzhen Qu <yingzhen.qu@futurewei.com>
Thread-Topic: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-04.txt
Thread-Index: AQHWcSuRIOkUrehz7UmLs62i8LmET6k1yPk6
Date: Thu, 13 Aug 2020 10:02:55 +0000
Message-ID: <AM7PR07MB62480BC77EABB838C031CA20A0430@AM7PR07MB6248.eurprd07.prod.outlook.com>
References: <159729345724.32598.10798369052469436120@ietfa.amsl.com>
In-Reply-To: <159729345724.32598.10798369052469436120@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=btconnect.com;
x-originating-ip: [81.131.229.35]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6f58d7f0-7af7-438c-8bc7-08d83f700ca4
x-ms-traffictypediagnostic: AM6PR07MB3847:
x-microsoft-antispam-prvs: <AM6PR07MB38470DC5F3A276F86DB18084A0430@AM6PR07MB3847.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: sbfwqP/OlXcWndmrM/y/wTsDPwhuHav+oZXsH8mBp2jfH1DmjE2Ras/fONKDGMWZYInGEfxBoOqLzWBOSn1FvSq9rB5Utvxtk+my/PbdyBoZwgdw92ucwGP1osMxxjG0IWdx3zmU8sFAStWOZb4xgtY1hEcbaQs7sOQj+RKkbesWkRNhx6/UUK6oiJBStjC+rXp7PSuDZoEvyb/S9g56p2k2BrvaKyGjcleRtupjNqzrbYJSMTp+k+bE3C33fbYnzKzxg3U8kE7u3AXNzkUJwkYsF9RTPD3yMng9NxHlLCHJh6+O/xMqaumH6UD6hpPSWO7Pf42OW7FZRBIg5MTQsVgwoRVmkWdsmQYfBmJ52KaZSXtH7Ug2tIcbXQfLfa1EQ0NA38RnWG3cXGZi7shkCA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR07MB6248.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(366004)(136003)(39860400002)(186003)(6916009)(86362001)(966005)(66574015)(8936002)(316002)(52536014)(55016002)(4326008)(478600001)(76116006)(9686003)(7696005)(2906002)(33656002)(5660300002)(6506007)(66946007)(66446008)(66476007)(66556008)(64756008)(26005)(71200400001)(91956017)(8676002)(83380400001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: +aTzPNcxovwCNQETsSp3WGyg+/MY8ojV7RSlxahERkgxNPV6u+m2tJX8YecBW7otBwbNWoL8NC0YyDWiOENHZzcMHSnmQ7rSPJpjy8OYYQxdDMZavu5xVJUZBUTGk8xz9DoN6BtvkUvQYWD/AczeBijhVqLbHYn8OA8gHkcEIOY9MhCKh2k8GiZknAZzlq5LNxFqCL5LQ8lbrN8ki3C7jHzzxlaX+ZNEOAMLMGYOMxNgzfvn5ltC5zw1+axpfsg0Fc49P/wV1LLtZS5AQ/RVzFU/LwdlpI/t8sT7YCfqznsN+xnoAWHFxjTqpzILu9U/UcQKULTsElLdReypofx3AaO3n9qkL5KSQKYNt3gViGzvMd+c1NraY7KlcS3Ci2DqAsXTL09WqyoWJKeEC457x0vZ5GUQmS7D8VxYU7r2h3gX9X1l2ffPA7YgVc+xWkiZp07qVCvWBc/mlsopu0vOW5/CprPmGwJuVpFIrBOxBe447TIfMiEQiUYvJPBDSLANWNjMRUqAbnxe96KGnwNO7xcZNAN2c0MGFdz7GipJta6Q0eluLJXOinLUx5PKeqIUQ6KiTMzaXjxNAIWVoWIHTDBm8+J74egBDXkZRCrK6ZsexeVHjmphgnMzUXM9vFV8MLjQUrJDqqu8MHGQ7dsm0Q==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR07MB6248.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f58d7f0-7af7-438c-8bc7-08d83f700ca4
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2020 10:02:55.1990 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i7fFE7I4IPZPu/cDRFh7HXOMZpVlhFqTHSafW8K/SSbIDWmi2IlXsNIGEtKgts8xXkfhik56nq5h1eakcuDOtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB3847
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/fML1hUVkJsxP72XaGb6qISy54ek>
Subject: Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-lsa-yang-04.txt
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2020 10:03:01 -0000
From: Lsr <lsr-bounces@ietf.org> on behalf of internet-drafts@ietf.org <internet-drafts@ietf.org> Sent: 13 August 2020 05:37 I said before that it was tough to review because of a lack of references in the YANG module and that remains true. You have two Boolean to enable extended LSA on for ospf, one for area. Yes, the answer is in RFC8362 but it tells me the YANG module is wrong - and it took me some time to find it. RFC8362 defines two parameters ExtendedLSASupport and AreaExtendedLSASupport and the latter is not in the model; yes you have a Boolean under area but I think its meaning requires a reading of RFC8362 Appendix B and that is missing and the description is unclear and the name is wrong. Also the RFC has a SHOULD in it which the model does not implement. You reference s.6.2 but I think that wrong, that it is Appendices A and B that describe this. On type, you say there are three possible values. Precisely. Can you have the type set to 'ospf' and support ospfv3? If so, your model fails. Or does ospf-yang only allow the type to be ospfv2 or ospfv3 and bar the use of ospf per se? The reference statement after the description could do with a title as you have for the revision description My point about link type is that you are augmenting ospf-yang which uses an enum so in places users will be required to use an enum and in others a uint8 which could be confusing Tom Petch A New Internet-Draft is available from the on-line Internet-Drafts directories. This draft is a work item of the Link State Routing WG of the IETF. Title : YANG Model for OSPFv3 Extended LSAs Authors : Acee Lindem Sharmila Palani Yingzhen Qu Filename : draft-ietf-lsr-ospfv3-extended-lsa-yang-04.txt Pages : 27 Date : 2020-08-12 Abstract: This document defines a YANG data model augmenting the IETF OSPF YANG model to provide support for OSPFv3 Link State Advertisement (LSA) Extensibility as defined in RFC 8362. OSPFv3 Extended LSAs provide extensible TLV-based LSAs for the base LSA types defined in RFC 5340. The IETF datatracker status page for this draft is: https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-extended-lsa-yang/ There are also htmlized versions available at: https://tools.ietf.org/html/draft-ietf-lsr-ospfv3-extended-lsa-yang-04 https://datatracker.ietf.org/doc/html/draft-ietf-lsr-ospfv3-extended-lsa-yang-04 A diff from the previous version is available at: https://www.ietf.org/rfcdiff?url2=draft-ietf-lsr-ospfv3-extended-lsa-yang-04 Please note that it may take a couple of minutes from the time of submission until the htmlized version and diff are available at tools.ietf.org. Internet-Drafts are also available by anonymous FTP at: ftp://ftp.ietf.org/internet-drafts/ _______________________________________________ Lsr mailing list Lsr@ietf.org https://www.ietf.org/mailman/listinfo/lsr
- [Lsr] I-D Action: draft-ietf-lsr-ospfv3-extended-… internet-drafts
- Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-exten… tom petch
- Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-exten… Acee Lindem (acee)
- Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-exten… tom petch
- Re: [Lsr] I-D Action: draft-ietf-lsr-ospfv3-exten… Acee Lindem (acee)