Re: [Lsr] Éric Vyncke's No Objection on draft-ietf-lsr-ospfv3-extended-lsa-yang-27: (with COMMENT)

Acee Lindem <acee.ietf@gmail.com> Tue, 30 January 2024 23:20 UTC

Return-Path: <acee.ietf@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32085C151997; Tue, 30 Jan 2024 15:20:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.106
X-Spam-Level:
X-Spam-Status: No, score=-1.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PF3hOJZXslLF; Tue, 30 Jan 2024 15:20:47 -0800 (PST)
Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8EA54C151983; Tue, 30 Jan 2024 15:20:47 -0800 (PST)
Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-42aabb1cdaaso20058521cf.2; Tue, 30 Jan 2024 15:20:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706656846; x=1707261646; darn=ietf.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mT5J9wWwzdq08F3vBqdZBwyap+jHtIxWc+nWPN/e0z8=; b=W/4D8YAdQKlbwYAPDZ2hW9k4uZdXs41QnyIHFA5FcGdYehKXweD3NUxf4+fhaktkP/ r4kO3X6n8BhYt2uDBIXfPkgN9+AQhKBHw/8Gsr1/cyyg19iefrptXgqPU+Fr+LfoDFow ni/bYQdFtrO0/9BhtAjJc3OW+AcRL+84eHmYW8hiXnDei4y7saoFuU+5G4jsFzeejVn6 f92cWgHZCe96Qfnf5KxJ6+Go3EfPoEKxr8aI1uIes0dI/m3dhyG3CNM/Myh6bTc0iUTq a7o7omDy532lqqMfzKBptDWtYZJS8UnL+rV3eZTA2t3K/5wrJL9oPcXEMaZXC+aRuKug 35og==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706656846; x=1707261646; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mT5J9wWwzdq08F3vBqdZBwyap+jHtIxWc+nWPN/e0z8=; b=lV+DxHvkyDFIeuYi8K4g9bwPGL0s48nkqcuwdrnJFoRoy5f3OBnZjVEJ5IzAYrw6wn rRX9Oq9AGKumm/HaUPhD0C5WfgzWiQLZVb8LJDYsOswIH7BTfrO/IPKhYjQNHxStBls6 wob6+FL6fBc3AQ4xcZi8wfK47FJYl1GTvAXW8sSKy+K1oVEuewp3Xkp7MtpK21f3Sbh2 NqKrf7ZxDfVfrzy6PQe09sMLv3u1lBSXeDwqnbRAwRmFc4Yy82vJAa4BNIsJi0vjY+rC bFTQ4Vopg71PR7A9qr+W8RbPSk//689Psv7ptg2claLBx7bE2DvKVXmlMWF0YzTs+sDn EsUQ==
X-Gm-Message-State: AOJu0YzSyuPQSHo9dfssEyT5DoQ3/Jc3LpfKgZ1gWnCAAj6+NUDP+F5b r89hBZvoh4ylIEpAtVDeU/iPw+c5lW6c+JHivo9gLixF/UiDRMPu
X-Google-Smtp-Source: AGHT+IHgbD6vFoKsSkKFNEbeny9ajQcRh/8xjZoEc/a6F3w2wNeEz8RRrKQjYWildnEqQEtOCv+UDA==
X-Received: by 2002:ac8:5a06:0:b0:42a:b197:bbfe with SMTP id n6-20020ac85a06000000b0042ab197bbfemr190259qta.6.1706656846620; Tue, 30 Jan 2024 15:20:46 -0800 (PST)
Received: from smtpclient.apple ([136.54.28.118]) by smtp.gmail.com with ESMTPSA id fw8-20020a05622a4a8800b0042a0a3d29a2sm1049337qtb.49.2024.01.30.15.20.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jan 2024 15:20:46 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Acee Lindem <acee.ietf@gmail.com>
In-Reply-To: <0D840D30-5FF7-47A8-8DB1-62A3F8F7EE60@cisco.com>
Date: Tue, 30 Jan 2024 18:20:35 -0500
Cc: Mahesh Jethanandani <mjethanandani@gmail.com>, The IESG <iesg@ietf.org>, "draft-ietf-lsr-ospfv3-extended-lsa-yang@ietf.org" <draft-ietf-lsr-ospfv3-extended-lsa-yang@ietf.org>, lsr-chairs <lsr-chairs@ietf.org>, lsr <lsr@ietf.org>, Christian Hopps <chopps@chopps.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <33824AE5-6A3D-4F77-A14C-451B588EE1F7@gmail.com>
References: <170652358887.60201.5322393151775104580@ietfa.amsl.com> <7C4AB442-FFD8-44F2-A0E5-A190ABC02812@gmail.com> <4DD3388F-4A89-4D5F-ACE0-B3F9BF5B681D@gmail.com> <0D840D30-5FF7-47A8-8DB1-62A3F8F7EE60@cisco.com>
To: "Eric Vyncke (evyncke)" <evyncke@cisco.com>
X-Mailer: Apple Mail (2.3731.700.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/l-dkvyUTTwp2YcX1MJlzLWYwyig>
Subject: Re: [Lsr] Éric Vyncke's No Objection on draft-ietf-lsr-ospfv3-extended-lsa-yang-27: (with COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jan 2024 23:20:48 -0000

HI Eric, 

> On Jan 30, 2024, at 7:04 AM, Eric Vyncke (evyncke) <evyncke@cisco.com> wrote:
> 
> Mahesh
>  Indeed, this was my question: why including BCP14 template when they are not used ? 😊

I have removed in the -28 version. I just posted it. 


>  Acee, the comment about a less trivial example was just a suggestion, feel free to ignore it

I’ve got to figure out how to so this with yanglint but it won’t be for this draft. 

Thanks,
Acee


>  Regards
>  -éric
>  From: Mahesh Jethanandani <mjethanandani@gmail.com>
> Date: Tuesday, 30 January 2024 at 02:52
> To: Acee Lindem <acee.ietf@gmail.com>
> Cc: The IESG <iesg@ietf.org>, "draft-ietf-lsr-ospfv3-extended-lsa-yang@ietf.org" <draft-ietf-lsr-ospfv3-extended-lsa-yang@ietf.org>, lsr-chairs <lsr-chairs@ietf.org>, lsr <lsr@ietf.org>, Christian Hopps <chopps@chopps.org>, Eric Vyncke <evyncke@cisco.com>
> Subject: Re: Éric Vyncke's No Objection on draft-ietf-lsr-ospfv3-extended-lsa-yang-27: (with COMMENT)
>  Hi Acee,
> 
> 
>> On Jan 29, 2024, at 6:33 AM, Acee Lindem <acee.ietf@gmail.com> wrote:
>>  Hi Éric, 
>> 
>> Thanks for the review - see inline. 
>> 
>> 
>>> On Jan 29, 2024, at 05:19, Éric Vyncke via Datatracker <noreply@ietf.org> wrote:
>>> 
>>> Éric Vyncke has entered the following ballot position for
>>> draft-ietf-lsr-ospfv3-extended-lsa-yang-27: No Objection
>>> 
>>> When responding, please keep the subject line intact and reply to all
>>> email addresses included in the To and CC lines. (Feel free to cut this
>>> introductory paragraph, however.)
>>> 
>>> 
>>> Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
>>> for more information about how to handle DISCUSS and COMMENT positions.
>>> 
>>> 
>>> The document, along with other ballot positions, can be found here:
>>> https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-extended-lsa-yang/
>>> 
>>> 
>>> 
>>> ----------------------------------------------------------------------
>>> COMMENT:
>>> ----------------------------------------------------------------------
>>> 
>>> Thanks for the work done in this document.
>>> 
>>> Like id-nits, I wonder why BCP14 template is used in the main body (in addition
>>> to its occurence in the YANG module itself) as there are occurence of normative
>>> language neither in the main body nor in the YANG module. Please consider
>>> removing the 2 occurence of the BCP 14 template.
>> 
>> 
>> This is normal for YANG model documents. I’d like to hear from OPS ADs on this if it is changing.
> 
>  The point Eric is bringing up is that you are not using any of the key words from BCP 14 like MUST, MUST NOT etc. Why do you need the include the template in that case.
>  Cheers.
> 
> 
>> 
>> 
>> 
>> 
>>> 
>>> Should there be a less trivial example ?
>> 
>> 
>> Operational state examples are not easy to produce without access to implementations. I’ve got it on my list of things to do to look at the available tools but it isn’t going to happen for this document. 
>> 
>> Thanks,
>> Acee
>> 
>> 
>> 
>> 
>>> 
>>> 
>>  
>  
> Mahesh Jethanandani
> mjethanandani@gmail.com