[manet] WGLC comments on draft-ietf-manet-dlep-da-credit-extension

"Velt, R. (Ronald) in 't" <Ronald.intVelt@tno.nl> Thu, 15 July 2021 17:13 UTC

Return-Path: <Ronald.intVelt@tno.nl>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 2E5863A0E7D for <manet@ietfa.amsl.com>; Thu, 15 Jul 2021 10:13:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=tno.nl
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id g-HPObL1vbmp for <manet@ietfa.amsl.com>; Thu, 15 Jul 2021 10:13:08 -0700 (PDT)
Received: from fromintouta.tno.nl (fromintouta.tno.nl []) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A4EC3A0E60 for <manet@ietf.org>; Thu, 15 Jul 2021 10:13:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tno.nl; l=9720; s=mta1; t=1626369188; h=from:to:subject:date:message-id:mime-version; bh=/eApWNp1zLGawJNGy94D5GHh+KyvRclDxTdDp3eWmk4=; b=Y7JDEBxVyMCzs0Dh3N2qgQnLwGx3iX9vTpGC7kFAUBga6jHC41N/cm4l YWvviKU3XN7KS7ioMDUJIHyz0SvNsvlr8yB7kTsD4u0aAxQ7sjVmjSW61 kp3DNzJvxKwXGV22OWjxZtwnvzveOqgaaFwevqa9Lyra9pIvIy2vZdPcP 8=;
IronPort-SDR: Ci3EACm9vgufkhsRJZrMyrn970xCIc6kMMq5VRyV3TsBLjXK2eUOaAqj4xpLJryYRXW6sTRrT3 uOIrJIdVvoYZJ3nZxFiB3vXjoDpDZO/gOH7VZWjNDV1K7BUdVnf2eSyqhiw1ymAq63z5HDVphD ETMCP1+7VAWlV6wlPtwgSM+9Df5JSMouhAXmiOvUee/UADYSt8yVU4yabhboZJtTuNj7QZxvaD RaODbOJOK1Zyvs0qnkiW/8Ihl9KSoIbFnYpCvls7ycREYw+EACq+2G0L4HWhGZMxOyuvaSJ7A0 4xzAFXX89EUnYagH1Ui6xWts
X-IronPort-AV: E=Sophos; i="5.84,242,1620684000"; d="scan'208,217"; a="32454538"
Received: from UCP13.tsn.tno.nl ( by UCP33.tsn.tno.nl ( with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 15 Jul 2021 19:13:05 +0200
Received: from UCP13.tsn.tno.nl ([fe80::c142:976e:5281:8298]) by UCP13.tsn.tno.nl ([fe80::c142:976e:5281:8298%7]) with mapi id 15.01.2242.004; Thu, 15 Jul 2021 19:13:05 +0200
From: "Velt, R. (Ronald) in 't" <Ronald.intVelt@tno.nl>
To: Lou Berger <lberger@labn.net>, "Wiggins, David - 0665 - MITLL" <David.Wiggins@ll.mit.edu>, Bow-Nan Cheng <bcheng@ll.mit.edu>, "manet@ietf.org" <manet@ietf.org>
Thread-Topic: WGLC comments on draft-ietf-manet-dlep-da-credit-extension
Thread-Index: Add5m5aLIeYRmmdBQE6R65W4ysWFRQ==
Date: Thu, 15 Jul 2021 17:13:05 +0000
Message-ID: <e24517e05d014ad5b1304bbc40fdeb75@tno.nl>
Accept-Language: en-US, nl-NL
Content-Language: en-US
x-originating-ip: []
x-esetresult: clean, is OK
x-esetid: 37303A29F08AA76F647165
Content-Type: multipart/alternative; boundary="_000_e24517e05d014ad5b1304bbc40fdeb75tnonl_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/G2jFmOqhfgToRpnBBvswdopJHwg>
Subject: [manet] WGLC comments on draft-ietf-manet-dlep-da-credit-extension
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jul 2021 17:13:13 -0000

Hi Authors, MANET WG participants,

Please find below my long overdue comments on draft-ietf-manet-dlep-credit-extension, one of three documents related to credit-based flow control that have been in WGLC for a long time. (With chair wig off).



Major Issues


Minor Issues

Section 1, Introduction, contains the somewhat puzzling sentence "Traffic sent by a router will use traffic flow classification information provided by the modem to identify which traffic is associated with each credit window." I would think it is the router, as opposed to the traffic, that uses the classification information. The traffic, which may originate from an upstream source, is what it is. But then the question is HOW the router should make use of the classification information. Should it re-mark certain traffic flows (i.e., alter their DSCPs) to ensure that they receive preferential treatment (i.e., are throttled last in case of congestion)? Can the router assume that the modem understands Per-Hop Behaviors? In my opinion, at the very least the sentence quoted above should be rephrased; in addition some further clarification on the mechanism foreseen could be helpful.


Section 1

3rd para: "... to provided credit window based flow control ..." => "... to provide credit window based flow control ..."

3rd para: "... based on on DLEP destination and DiffServ [RFC2475] DSCPs (differentiated services codepoints)." => "... based on DLEP destinations and DiffServ [RFC2475] DSCPs (differentiated services codepoints)."

Section 2

1st para: "... the DiffServ Traffic Classification Sub Data Item," => "... the DiffServ Traffic Classification Sub-Data Item," (following the precedent set by RFC8651)

Appendix A

"The sub data item format was inspired ..." => "The Sub-Data Item format was inspired ..." (see above)
This message may contain information that is not intended for you. If you are not the addressee or if this message was sent to you by mistake, you are requested to inform the sender and delete the message. TNO accepts no liability for the content of this e-mail, for the manner in which you use it and for damage of any kind resulting from the risks inherent to the electronic transmission of messages.