Re: [manet] WGLC comments on draft-ietf-manet-dlep-da-credit-extension

Lou Berger <lberger@labn.net> Thu, 29 July 2021 22:51 UTC

Return-Path: <lberger@labn.net>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D89D3A0CD3 for <manet@ietfa.amsl.com>; Thu, 29 Jul 2021 15:51:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.701
X-Spam-Level:
X-Spam-Status: No, score=-1.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=labn.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eVO0y6pHtIH0 for <manet@ietfa.amsl.com>; Thu, 29 Jul 2021 15:51:27 -0700 (PDT)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2102.outbound.protection.outlook.com [40.107.244.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 311583A0CD0 for <manet@ietf.org>; Thu, 29 Jul 2021 15:51:26 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GTFow227l1t8tiGLMw4M4v90uMkMzLvyp2LXT1ekEy8gssSCYMNKbj3VaxEfpMphiFaVvRyCMPwLfpgOMg/8xnqCkS2vcO3lY+MbZ7Ap6ooEiFPoAM5+mDicLCnmRsYjOrH1so2pPBGjy6PhLn20ICSYgF8O6+87G62ojIQK/casT062IcsAJ73pK/gEyUPqlbkuOr4Uu/LEQFXBUXdKGAbjfW3Hxzsta+ak1nFMK5z1hzQ1juXm3Wm5r8cjTRUhLpccPlf9u5RSQu20EZhlxI/Ccxl1HwAJkHA2PPvCugW+SOOLF+sQlKyLwOpqWBpRDim/FL8VzIUG/LcCA6iDHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tj0HLElyfPxUjLxaVFdw/gf58YvM9knrMYTTL2md0KM=; b=aCkMPU6hZiY+b8McP4Ew+l0GkWgIow6lpQjz4PTsoPBEQlnUCHq/07ARmhCjxD1jbE04UaRmzhbmu9CqRZ4IazqUoU0SpEwMBNh6uoYnRwcBjmycdK+llwJqWU7nCjzvw3OBkLw6et33KyzdmMr01CdJ71oNjKX53Wc75o1aphlHIvOyi9zV9IWCeUBDAq2UDGw/H/HDdr/aB59cDUC/wAh+lDWc4ijTM5e+NABaf51zQEMuzpyPaJ5bl8bmgMNFSq2vdqhFIT5B/gxoNAeILCs3RpeHhmrJV7vIae5Euu384+1NUSGx7tby07cdh8nlUCXsfe+vnIWUiK/Iu7hjbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labn.net; dmarc=pass action=none header.from=labn.net; dkim=pass header.d=labn.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labn.onmicrosoft.com; s=selector2-labn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tj0HLElyfPxUjLxaVFdw/gf58YvM9knrMYTTL2md0KM=; b=iA1GBiWbaMwTIvGOPj+R7R0Hrdpgq1X2o2LlQDiDuShT1gyf9VNoOP+w3uY/ED82S2Ne5VCaGBS62XSLK/NRCwpQiDhjRm2gPASY3O4/aULoCCQqxtcgPowPcehR7eeFdzK9eYqt4183sE4E08ENLpIyQS34ueG43a22prAzdFw=
Authentication-Results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=labn.net;
Received: from SJ0PR14MB4792.namprd14.prod.outlook.com (2603:10b6:a03:379::24) by BY5PR14MB3576.namprd14.prod.outlook.com (2603:10b6:a03:1c6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.28; Thu, 29 Jul 2021 22:51:23 +0000
Received: from SJ0PR14MB4792.namprd14.prod.outlook.com ([fe80::4c2e:22d:4fe5:6792]) by SJ0PR14MB4792.namprd14.prod.outlook.com ([fe80::4c2e:22d:4fe5:6792%7]) with mapi id 15.20.4373.020; Thu, 29 Jul 2021 22:51:23 +0000
To: "Velt, R. (Ronald) in 't" <Ronald.intVelt@tno.nl>, "Wiggins, David - 0665 - MITLL" <David.Wiggins@ll.mit.edu>, Bow-Nan Cheng <bcheng@ll.mit.edu>, "manet@ietf.org" <manet@ietf.org>
References: <e24517e05d014ad5b1304bbc40fdeb75@tno.nl>
From: Lou Berger <lberger@labn.net>
Message-ID: <0a469503-b4d7-db48-2d17-799dc407c032@labn.net>
Date: Thu, 29 Jul 2021 18:51:21 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0
In-Reply-To: <e24517e05d014ad5b1304bbc40fdeb75@tno.nl>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-ClientProxiedBy: MN2PR12CA0020.namprd12.prod.outlook.com (2603:10b6:208:a8::33) To SJ0PR14MB4792.namprd14.prod.outlook.com (2603:10b6:a03:379::24)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [127.0.0.1] (100.15.108.238) by MN2PR12CA0020.namprd12.prod.outlook.com (2603:10b6:208:a8::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.17 via Frontend Transport; Thu, 29 Jul 2021 22:51:23 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 249bb980-3d45-4e1a-3c1e-08d952e363d8
X-MS-TrafficTypeDiagnostic: BY5PR14MB3576:
X-Microsoft-Antispam-PRVS: <BY5PR14MB35766B21CBA92FFB2AA3E88EC3EB9@BY5PR14MB3576.namprd14.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +aGY0/L86WvHQaPeKwNsSZOiKrH1dYSO9hRcjT7bNRfSGI9BLX3xIdInwDXirAzPPUhgzhbxImoUB2eXIJx79xcIUcC16QYDm2jPAW5wO7Y3jTl8AP6qWan23JI186s9czgKKxgAQavRfJiQf9DFX7aaHqxSKU1pcVrJBOqXfa1dEZQG0MEjHaGWHUKlxjwA9cZn7EsoOyWtnAmG+KxjbMxRTXJkEodxmOhOLk2AbuiucA5UJdkurVkD8AACkCCPa7kxkn+gQibqzgIpmWwD7rSNPD9jWK5yAphN8w38zdZdB2e1WXtYgfpHTZ5m2/SSCXJOqu9wZrIz7dBo8nv94bcj4g6hizGbMiMGU3PYhuFBbM5rK4dGhe/ZYct7XjfDY3L143v747/soUjFwjlkvjgzErY64VxP5aXbr05s8f/iMNtUClAOn0bZ0ZsJIR5mF+mIUf2xcZ5nLAl9oSGoIQ0mXNW+jYasAAZtYtdj9tmcAhq/rbsymh2eiLQEvp1cwgb4v88mYaJro65tNBu7Yh4WfIM40XwKaE95A6SCTcGyfR0Dp4aIJ8IPEYAKunav4ioNt9Z8wVYbwjdEylK9bqDj41Y/HCzYCOJvbL4pemqitPN0D3vzGLwfQ8QAOqwOCbeX9WV7Hzs0d4coJQdrXqs/1yg9KRqJvNWrV/WWiasGSShCyPfSugJeLjCnGUupBuhlB11lttA/HsfEW8SnzWakK4cE/XF4JrBnVAALsprfDSm6lLEwHGiStuABXyZXGz7RLd94VqnUXRXrBdy79g==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR14MB4792.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39830400003)(376002)(136003)(396003)(366004)(36756003)(316002)(5660300002)(7246003)(110136005)(52116002)(66556008)(956004)(31686004)(66476007)(86362001)(53546011)(66946007)(7126003)(2906002)(16576012)(2616005)(31696002)(478600001)(6486002)(186003)(45640500001)(66574015)(38100700002)(38350700002)(26005)(8676002)(8936002)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?iFrXKH3XxzK8efCs4pb3kitMkWO6SaeZX66ENcEhqNQxOK00J8fg/qmW?= =?Windows-1252?Q?eMVbQCDCuelPF7vZd7qc/cK6QSx+CbgryyHFDSmJBeK1jXrE82wNT0cs?= =?Windows-1252?Q?YRYko27FIhjfKJrKsi+44nNnRxEprTMj8fus+TVa24Z0oBL34U/ZQkDC?= =?Windows-1252?Q?iodAlnHYrzbFpn66jGUwJmkdSk99Xktidz7kMdpb2/70objUN+O6x2iC?= =?Windows-1252?Q?qvMamU0Z941b0Oi78GAywjLi7QGKdFwd5SKapN284gHRjfc4BXoMUBWf?= =?Windows-1252?Q?abARhcauQJzqJNx7pQEAsTiVhcaaFT0RNnnvNmHwoxRr1r/iin6Spu6x?= =?Windows-1252?Q?PJoRMcBrhgkhZ71PBmQwbPKrw0rkbRxiG9+v+aCDVjHmHWHTtJD3FLt0?= =?Windows-1252?Q?2mMBk88b5hVbzrBCO7C40V+Y2adqdo/oSTOHiDbAwHS+MExcSFeHftyv?= =?Windows-1252?Q?OkQ+JFdfNr2rH5AKcE8MJtNJnOH165YzIyXeLJB548F3+LhQYQyu/HZv?= =?Windows-1252?Q?jg6RlB/aF1e19/9IiMEoTgIizC3Y4BX0oYc6lR4mTNgmTX4y0PS028dq?= =?Windows-1252?Q?oHDGwiknrb5Q7WwaDFrl6MmJVFbPiWYPBMyZ63lLURO/Zup9h7jhb47W?= =?Windows-1252?Q?d25NiX4Uhzm1mfvHUcR1pc7PYrzOtTL1SXRCMrBpJcuHjmQBBGMO38lw?= =?Windows-1252?Q?GSigc0mYAXh4hQTMyotyM73vZCVQsZqZlBtB3ci7/luForBMnBfBf8VG?= =?Windows-1252?Q?Gv43y1lfUZ9FHYFUqjzgqXSnlxCevUr3WVBfr3RN5LRP7h6m7mpUr16e?= =?Windows-1252?Q?EErx4QXrhShCIEqrzvak05OPSJBfa4LsZvVGi/XvdK0WuiPO/a+PNEpq?= =?Windows-1252?Q?rXZyJGUukGhQQpYpRhU5I+CyVl+vRL8gEvDDqv18u3WTtc7OUO3H9ZI7?= =?Windows-1252?Q?Sg3ER7RnIkwW8g+lLY6rnHd0ctZBo+3m7VNTnImyEo7q0rS2qrIHppDC?= =?Windows-1252?Q?t+RdGqlkDIgNUsTlN6mNIP4brqAkFoylgYy2PaRfs8ioL0C2MNapXSmM?= =?Windows-1252?Q?T81YuC/hPU2N3HiAumVXUBxc3eGnzW0Jf2Y2I+A6sFggJdQmCwuulmd9?= =?Windows-1252?Q?LN4sNm5IUoS0NIEfWFnXJ/9nerG9aRjSUx0q7p5V5gbfb1Gb+TQIS/L3?= =?Windows-1252?Q?cRGU3B4Yh684wUtAApvsjZ05kYGEAlfzak+j9jiPV97djg13Twyuz4Sh?= =?Windows-1252?Q?NS/rFcsd1E8v66dk9Yr3fU486ipsOjVTflhpU73Uh74ln3o8t00DRqX1?= =?Windows-1252?Q?LXhBvQm1Ubb631OqlN4k/uCDb9iUow//BKuZ+CBStfoidAvyWyii+/ma?= =?Windows-1252?Q?3AAWbWL2mwATnwCeRWU5FgvzFL/dqJ0FprqJJKMZSXKEepds1muNECAF?=
X-OriginatorOrg: labn.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 249bb980-3d45-4e1a-3c1e-08d952e363d8
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR14MB4792.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 22:51:23.7268 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: eb60ac54-2184-4344-9b60-40c8b2b72561
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VpS25nSgROo4iSYcauSfOEMgaQTUKd4iqNpHTDJHEzO67kot1E5OqMPbgCJrrd84YsED10C8tTu/XePhZewc0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR14MB3576
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/QcrzxU_Z3euyzE9-vuplv042Qy0>
Subject: Re: [manet] WGLC comments on draft-ietf-manet-dlep-da-credit-extension
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 22:51:30 -0000

Hi Ronald,

Thanks again for the reviews! See below for responses.


On 7/15/2021 1:13 PM, Velt, R. (Ronald) in 't wrote:
>
> Hi Authors, MANET WG participants,
>
> Please find below my long overdue comments on 
> draft-ietf-manet-dlep-credit-extension, one of three documents related 
> to credit-based flow control that have been in WGLC for a long time. 
> (With chair wig off).
>
> Thanks,
>
> Ronald
>
> -- 
>
> Major Issues
>
> ============
>
> None
>
> Minor Issues
>
> ============
>
> Section 1, Introduction, contains the somewhat puzzling sentence 
> "Traffic sent by a router will use traffic flow classification 
> information provided by the modem to identify which traffic is 
> associated with each credit window." I would think it is the router, 
> as opposed to the traffic, that uses the classification information. 
> The traffic, which may originate from an upstream source, is what it 
> is. But then the question is HOW the router should make use of the 
> classification information. Should it re-mark certain traffic flows 
> (i.e., alter their DSCPs) to ensure that they receive preferential 
> treatment (i.e., are throttled last in case of congestion)? Can the 
> router assume that the modem understands Per-Hop Behaviors? In my 
> opinion, at the very least the sentence quoted above should be 
> rephrased; in addition some further clarification on the mechanism 
> foreseen could be helpful.
>
Same change as your other review, i.e., drop "Traffic sent by"

>
> Nits
>
> ====
>
> Section 1
>
> 3rd para: "... to provided credit window based flow control ..." => 
> "... to provide credit window based flow control ..."
>
thanks
>
> 3rd para: "... based on on DLEP destination and DiffServ [RFC2475] 
> DSCPs (differentiated services codepoints)." => "... based on DLEP 
> destinations and DiffServ [RFC2475] DSCPs (differentiated services 
> codepoints)."
>
yes
>
> Section 2
>
> 1st para: "... the DiffServ Traffic Classification Sub Data Item," => 
> "... the DiffServ Traffic Classification Sub-Data Item," (following 
> the precedent set by RFC8651)
>
yes.
>
> Appendix A
>
> "The sub data item format was inspired ..." => "The Sub-Data Item 
> format was inspired ..." (see above)
>
agreed.

Thanks again.  Stay tuned for the update.

Lou

> This message may contain information that is not intended for you. If 
> you are not the addressee or if this message was sent to you by 
> mistake, you are requested to inform the sender and delete the 
> message. TNO accepts no liability for the content of this e-mail, for 
> the manner in which you use it and for damage of any kind resulting 
> from the risks inherent to the electronic transmission of messages.
>