[manet] DLEP pause extension
Rick Taylor <rick@tropicalstormsoftware.com> Tue, 20 March 2018 11:42 UTC
Return-Path: <rick@tropicalstormsoftware.com>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8E243127078 for <manet@ietfa.amsl.com>; Tue, 20 Mar 2018 04:42:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.911
X-Spam-Level:
X-Spam-Status: No, score=-1.911 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ff-0Bz4pVjUd for <manet@ietfa.amsl.com>; Tue, 20 Mar 2018 04:42:48 -0700 (PDT)
Received: from mail.tropicalstormsoftware.com (mail.tropicalstormsoftware.com [188.94.42.120]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1D61126DED for <manet@ietf.org>; Tue, 20 Mar 2018 04:42:10 -0700 (PDT)
Received: from tss-server1.home.tropicalstormsoftware.com ([fe80::753b:fa82:5c0:af0d]) by tss-server1.home.tropicalstormsoftware.com ([fe80::753b:fa82:5c0:af0d%10]) with mapi; Tue, 20 Mar 2018 11:41:58 +0000
From: Rick Taylor <rick@tropicalstormsoftware.com>
To: "manet@ietf.org" <manet@ietf.org>, "lberger@labn.net" <lberger@labn.net>
Thread-Topic: DLEP pause extension
Thread-Index: AQHTwEB0q58zoRMTUE6Lynoa53UkUQ==
Date: Tue, 20 Mar 2018 11:41:08 +0000
Message-ID: <1521546068.17989.44.camel@tropicalstormsoftware.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Content-Type: text/plain; charset="utf-8"
Content-ID: <e22b584b-a3cf-40a5-b456-a5c454a5f233>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/XHiCZD0o4rzqldoO7gzB0JBDBWU>
Subject: [manet] DLEP pause extension
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2018 11:42:49 -0000
Hi Lou, I'm also having a re-read of the latest pause extension draft. In general I like it, and think it's almost ready, but I have a couple of comments: * Section 3.1 Queue Parameters. There seems to be a lot of reserved space to align fields within the data item. Is this strictly necessary? This sounds like an optimization to try to force sub-tlvs to 8 byte alignment. Given the DI is coming over TCP, I think this might be a false optimization. I know it prevents your diagram from getting messy, but an arbitrary 28-bits of padding is just a bit weird. Given the large chunk of padding, why not make the scale 8 bits to make implementers life a little easier? * Section 3.1. Rather than have the order of items be important (unlike everywhere else in DLEP), I would prefer to have an explicit QID in there somewhere. The same applies to section 3.1.1 Queue Parameter Sub Data Item. You already introduce the Queue Index, why not make it explicit for sanity? Can I suggest the following DI layout instead, as I think it addresses both my comments? The format of the Queue Parameters Data Item could be: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Data Item Type | Length | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Num Queues | Scale (8!) | Reserved | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Queue Parameter Sub Data Item 1 | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ : ... : +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Queue Parameter Sub Data Item n | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ The format of the Queue Parameter Sub Data Item could be: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Queue Id | Queue Size Qn | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Num DSCPs Qn | DS Field Qn | DS Field Qn | ... : +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ : ... | DS Field Qn | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ Cheers, Rick
- [manet] DLEP pause extension Rick Taylor
- Re: [manet] DLEP pause extension Lou Berger