Re: [manet] ready for LC : latency and multi-hop

Victoria Pritchard <pritchardv0@gmail.com> Fri, 26 January 2018 04:36 UTC

Return-Path: <pritchardv0@gmail.com>
X-Original-To: manet@ietfa.amsl.com
Delivered-To: manet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCDEC12D94F for <manet@ietfa.amsl.com>; Thu, 25 Jan 2018 20:36:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.449
X-Spam-Level:
X-Spam-Status: No, score=-1.449 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ymrRkNiHNmRU for <manet@ietfa.amsl.com>; Thu, 25 Jan 2018 20:36:12 -0800 (PST)
Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A506212422F for <manet@ietf.org>; Thu, 25 Jan 2018 20:36:12 -0800 (PST)
Received: by mail-it0-x22c.google.com with SMTP id u62so577246ita.2 for <manet@ietf.org>; Thu, 25 Jan 2018 20:36:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=24zIy7PjeSivIgA+5JJbJ0YKzdFZYt+q8eG56gEJ28c=; b=OjrN/rwwrMsFlLRSMnnlIJ6tIYEjM2CD4cie/d8xee4+592rGoHS2qzc0todvqr2Pm gBkeOVWcnkwALioUL6p7b6GDoOVW++UU+akOn4WUfxw7USho83p7e+IzmlwaEbBffAWW a8Z2nUxkHVjmFnmxWBkOHfTnNe13R1MeiUvKsjfHbddoPuIxy5AQhmDHMBLNt/4X6cMw SGgmLa9lUvzZn4Oy7JGATyg6OVGJH7voMZrPVcous9NiQl0mL6gfFuVgnMCUNTgF+hWK hdMKInznXxdP4vYIoG4UErs8CPoGLc5SGKr9gMWQe/oLjJDqgXjC3/XqEAVsKLoj0vvc D0Sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=24zIy7PjeSivIgA+5JJbJ0YKzdFZYt+q8eG56gEJ28c=; b=nhSz6BPLTczFk5ZhlxHdw8l2d+gBwBfGZlt1vOJvfjnefTCkIUkOwKnVwuSx/zbaoV 7DTGEd4lX2xWimH65IT6v0XpDdYKnN9shE3GBY9kAl00Bk7YCS87mjAZ73rQWqbcVTOU jafgUdaEyC/4B/leJA4xr4Y5VNvxuwg2GGghK+4oRxYb4O7VtXlkX61Fv0N8I0wtRdND lhDBiXJRM9BYnNtXOTLrohm11hcie4s6+hULgT/Uiadvan4CjuyMwjPyg69XNag6ukC4 4wHPNr4dkvqk8XXvlXIxQCgczzMAMcgqgcha5cS8CNX8BYQH8TT2fkjGcxezgmY4W7pH ApkQ==
X-Gm-Message-State: AKwxytezHCA5lD5TjUzJmobvratAu9z9rwOxeZDp8WN6AldSLRiaiAKM apT81uqbF4ojq0EIp7OxPFYpg4QxtMnAuVD0tuQ=
X-Google-Smtp-Source: AH8x226Alwqiq71hXfo97HLQAZPBuHb1uEyTcjShFxhfbwe6JhPBFSMP5z5wJza7tOBawVdCFB78gYA+0sD5+D1VM4Q=
X-Received: by 10.36.145.208 with SMTP id i199mr14959914ite.81.1516941371984; Thu, 25 Jan 2018 20:36:11 -0800 (PST)
MIME-Version: 1.0
Received: by 10.2.61.10 with HTTP; Thu, 25 Jan 2018 20:36:11 -0800 (PST)
Received: by 10.2.61.10 with HTTP; Thu, 25 Jan 2018 20:36:11 -0800 (PST)
In-Reply-To: <ea933d6c-6b75-a1e9-3be4-ac3b0f3223ab@labn.net>
References: <151182163087.13335.9898030294539351604@ietfa.amsl.com> <f9b818ce-f032-e04f-c6e4-8f3e14fe1793@labn.net> <CA+-pDCdLfTB7RsopqttYh243JeJ0kst3EPsJPuyXhPs4C3vR2Q@mail.gmail.com> <CA+fLEhKsyMLfYzGaO5ip9T8mavjyuLeDi2=G942iLpMH6SY=NA@mail.gmail.com> <ea933d6c-6b75-a1e9-3be4-ac3b0f3223ab@labn.net>
From: Victoria Pritchard <pritchardv0@gmail.com>
Date: Fri, 26 Jan 2018 04:36:11 +0000
Message-ID: <CA+fLEhJj2x_u5RHyOyCk0uxythF4zys2YQJSoNmvv=SDnT4aJQ@mail.gmail.com>
To: Lou Berger <lberger@labn.net>
Cc: Justin Dean <bebemaster@gmail.com>, MANET IETF <manet@ietf.org>
Content-Type: multipart/alternative; boundary="94eb2c07d5f49f50f50563a66fcb"
Archived-At: <https://mailarchive.ietf.org/arch/msg/manet/aHnFn0S8HCmbspql7vgZU0bu3Fs>
Subject: Re: [manet] ready for LC : latency and multi-hop
X-BeenThere: manet@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Mobile Ad-hoc Networks <manet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/manet>, <mailto:manet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/manet/>
List-Post: <mailto:manet@ietf.org>
List-Help: <mailto:manet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/manet>, <mailto:manet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Jan 2018 04:36:15 -0000

Hi Lou,

Thanks for the response...


On 25 Jan 2018 23:50, "Lou Berger" <lberger@labn.net> wrote:

Vicky,

    Thank you for the comments!



On 1/21/2018 1:03 PM, Victoria Pritchard wrote:

> Hi all,
>
> Just a few picky comments on the Latency Range draft.
>
> Title
> Lantency -> Latency
>
> thanks.


Abstract
> Should you reference the DLEP RFC number here? Or at least expand the
> acronym?
>
> Section 1
> It's "Dynamic Link Exchange Protocol" (not "Event Protocol")
>
>
Well that's embarrassing! Fixed in all extensions.


I think DLEP itself was confused for a little while too ;)



"provides an average latency" - the definition in RFC8175 actually says
> "The calculation
>    of latency is implementation dependent.  For example, the latency may
>    be a running average calculated from the internal queuing." so not sure
> it's right to say it provides an average.
>
> how about:
   The base DLEP specification includes the Latency metric which provides
-  an average latency on a link.  This document adds the ability to relay
+  a single latency value on a link, which is implementation dependent.
+  This document adds the ability to relay


Looks good to me




"one new DLEP
>    Data Items" - unnecessary 's' on Items
> Section 3
> Is it " Latency Range Item " or " Latency Range Data Item "? Makes sense
> to be consistent
>
> agreed.


Under the Maximum Latency field description:
> "representing the transmission longest
>       delay"
> should that be "longest transmission delay"?
> Similar comment for Minimum Latency
>
> thanks!


Section 5.2
> "Data Item Type Values"  is the name of the registry in RFC8175.
>
> fixed in all drafts!


> Regards,
> Vicky
>
>
Thank you - changes have been pushed to the repo...


Brilliant :) thanks Lou.


On 8 January 2018 at 21:46, Justin Dean <bebemaster@gmail.com <mailto:
> bebemaster@gmail.com>> wrote:
>
>     As discussed during IETF 100 these documents are now in last call.
>     Please review them and post comments to the list.
>
>
>     https://tools.ietf.org/html/draft-ietf-manet-dlep-latency-extension-01
>     <https://tools.ietf.org/html/draft-ietf-manet-dlep-latency-e
> xtension-01>
>     https://tools.ietf.org/html/draft-ietf-manet-dlep-multi-hop-
> extension-03
>
>     <https://tools.ietf.org/html/draft-ietf-manet-dlep-multi-hop
> -extension-03>
>
>     _______________________________________________
>     manet mailing list
>     manet@ietf.org <mailto:manet@ietf.org>
>     https://www.ietf.org/mailman/listinfo/manet
>     <https://www.ietf.org/mailman/listinfo/manet>
>
>
>
>
>
> _______________________________________________
> manet mailing list
> manet@ietf.org
> https://www.ietf.org/mailman/listinfo/manet
>