Re: [Masque] Éric Vyncke's No Objection on draft-ietf-masque-h3-datagram-10: (with COMMENT)

David Schinazi <dschinazi.ietf@gmail.com> Thu, 16 June 2022 00:36 UTC

Return-Path: <dschinazi.ietf@gmail.com>
X-Original-To: masque@ietfa.amsl.com
Delivered-To: masque@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB8F0C14CF0E; Wed, 15 Jun 2022 17:36:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fMSsZAz2pUlj; Wed, 15 Jun 2022 17:36:37 -0700 (PDT)
Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F30DC14F744; Wed, 15 Jun 2022 17:36:37 -0700 (PDT)
Received: by mail-pg1-x52e.google.com with SMTP id z14so8741056pgh.0; Wed, 15 Jun 2022 17:36:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=RzNUS2Plpa+KU4EjVd+y7LB8NEcL8fKJrddX0qr9DVs=; b=H+MWnl3JTGqeGa9rPxBi9xaaG1ArKAHUEBl2nejLo2OiLIJmLg9LARllLUjB5ST0Pg FeJoFTqyHC5jd4Bhj3d8SO96J4/rY+C7izjJFy2YinwPDIWARz6dSfJeKqKPZ9dcGXBX ryjutxOsa6p/6p577I6JeRCKX1vXequkC5s/6EX3uGKMHRxVOogyDEl+2Y865fbZDB28 d0qFa5fBmRFe897xtj2I2ufH0nZ5ijIYGkTbijtNr/u9NyICw2ZSnVIiSSu/xAp1zfZk cfLWPLyp42IYBhW82nRT6aEN7MoPWRSep+DxbLoaCiQQJaoGIVhd/6vcq/niQSNiivgZ zsTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=RzNUS2Plpa+KU4EjVd+y7LB8NEcL8fKJrddX0qr9DVs=; b=aD9/e+VBjl8Z2E8CJSmytYJc6ZXQU1mAB8bEqOc/GR44ue1WqA3SbSqQfNe7IScjTg Hhw+vl66jhGK1Z90caeVPIwgD2zvY/0GCoPLJMcA8u6ZeVzvyMjmms+V0coxeXUvV4Mf ID7jPSF3ge2GI2T2fiPhxH2ggLK/a5cnuIIkok+4Nlq5IFRBYBLwuttUh+1L5mJzgOWq z9gLzrXUJm8oaqhzM3MchQuCQC1Z262nKE8Zx4sgZh9O0h/8B5KsyWXca+56ATMPdbzy PceHs9iKKaBVkrzqonoy0JOeRLnem49ulRTjsP2bHU5HN7zmZuJ4NN3gWo+aO+eDPBLL AoHg==
X-Gm-Message-State: AJIora+NK7DxjBbP6CEuuCdC8Jzu6gJc3XB5VWcHMjgaHJ494OVxcDQU gmKaKFxJLAo6Ly3koKFGZtLwjRnhpX23nyy3tDc=
X-Google-Smtp-Source: AGRyM1s7UIBtratoJCY02a0E0Olnp1gBrWj9UCdH3uOLR5HjQGz6UV4PzpBA1LcTa5G1uUiFbz8UyVmXySQ9J7bnC+c=
X-Received: by 2002:a63:4e62:0:b0:398:cb40:19b0 with SMTP id o34-20020a634e62000000b00398cb4019b0mr2081011pgl.445.1655339796120; Wed, 15 Jun 2022 17:36:36 -0700 (PDT)
MIME-Version: 1.0
From: David Schinazi <dschinazi.ietf@gmail.com>
Date: Wed, 15 Jun 2022 17:36:25 -0700
Message-ID: <CAPDSy+72g==PJ-b_XD0cX4F7r2szbOKDthTjPTMNaD=VWwm82A@mail.gmail.com>
To: Éric Vyncke <evyncke@cisco.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-masque-h3-datagram@ietf.org, masque-chairs@ietf.org, MASQUE <masque@ietf.org>, Christopher Wood <caw@heapingbits.net>
Content-Type: multipart/alternative; boundary="00000000000087ca4a05e185d483"
Archived-At: <https://mailarchive.ietf.org/arch/msg/masque/Uoyd3Sairn64-Uvt3UaIhcVT8Js>
Subject: Re: [Masque] Éric Vyncke's No Objection on draft-ietf-masque-h3-datagram-10: (with COMMENT)
X-BeenThere: masque@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multiplexed Application Substrate over QUIC Encryption <masque.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/masque>, <mailto:masque-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/masque/>
List-Post: <mailto:masque@ietf.org>
List-Help: <mailto:masque-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/masque>, <mailto:masque-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2022 00:36:38 -0000

Hi Eric, thanks for your review!
Responses inline.
David

### Abstract

s/This document describes HTTP Datagrams/This document specifies HTTP
> Datagrams and the Capsule Protocol/ ?


I personally prefer "describes" here.

### Section 1
> For consistency with other reasons, should a reference be added to
> `unreliable version of the CONNECT method` ?


We could add a reference to Section 9.3.6 of RFC 9110, but I think that
this would make the sentence harder to read. There's already a reference to
RFC 9110 in that paragraph. If this is just about consistency with the
WebSocket, I'd favor readability or consistency.

### Section 2
> ```
>    HTTP extensions can
>    override these requirements by defining a negotiation mechanism and
>    semantics for HTTP Datagrams.
> ```
> s/can/MAY/ ? (but I am not a native English speaker) I also noticed that
> 'MAY' is used at the end of section 2.1.


Agreed, fixed via this commit:
https://github.com/ietf-wg-masque/draft-ietf-masque-h3-datagram/commit/d7d06b1ca504617a8121ba206fb526a06b1db780

### Section 2.2

I wonder whether this small section is useful. The text should rather go
> into the intro of section 3.


This small subsection provides continuity, it exists in the HTTP Datagrams
section and points to how to encode HTTP Datagrams over capsules.

### Section 3.4

While I am not too familiar with HTTP & QUIC, I wonder when reading
> `Endpoints indicate that the Capsule Protocol is in use on a data stream by
> sending a Capsule-Protocol header field with a true value.` Until now, the
> Capsule Header is not yet defined even less how to send a true value (or
> did I misread part of the I-D)


The header is defined in the paragraph right above the one you quoted. It
references the Structured Fields RFC and that explains how to send a true
value.

### Section 3.5
> ```
> Since QUIC DATAGRAM frames are required to fit within a QUIC packet,
>    implementations that reencode DATAGRAM capsules into QUIC DATAGRAM
>    frames might be tempted to accumulate the entire capsule before
>    reencoding it.  This can cause flow control problems; see
>    Section 3.2.
> ```
> The problem is clear, but what is the recommendation for implementers ?


Agreed, fixed in this commit:
https://github.com/ietf-wg-masque/draft-ietf-masque-h3-datagram/commit/0de86dbe59612a4c006f89a51b878f1d5acdb325