Re: [mile] review-- ROLIE Vulnerability Extension

"Banghart, Stephen A. (Fed)" <stephen.banghart@nist.gov> Wed, 15 May 2019 16:13 UTC

From: "Banghart, Stephen A. (Fed)" <stephen.banghart@nist.gov>
To: Jessica Fitzgerald-McKay <jmfmckay@gmail.com>, "mile@ietf.org" <mile@ietf.org>
Thread-Topic: review-- ROLIE Vulnerability Extension
Thread-Index: AQHU/ELTNiwdsQwaB0GKY7Uek98OS6ZseM6w
Date: Wed, 15 May 2019 16:13:11 +0000
Message-ID: <BN3PR09MB06098B32BC9E2DB7717C2EF4F0090@BN3PR09MB0609.namprd09.prod.outlook.com>
References: <CAM+R6NUCaEiQ9SAz_-iFP3YLqpCdioDwcp3kvb0Vw9V70dyAWQ@mail.gmail.com>
In-Reply-To: <CAM+R6NUCaEiQ9SAz_-iFP3YLqpCdioDwcp3kvb0Vw9V70dyAWQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nist.gov does not designate permitted sender hosts)
Content-Type: multipart/alternative; boundary="_000_BN3PR09MB06098B32BC9E2DB7717C2EF4F0090BN3PR09MB0609namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 096e5ece-b97f-4278-8a72-08d6d9503a2a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2019 16:13:11.3379 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2ab5d82f-d8fa-4797-a93e-054655c61dec
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR09MB0339
Archived-At: <https://mailarchive.ietf.org/arch/msg/mile/blnIFqWbNRflxzg2Ty8Ooe7X2oM>
Subject: Re: [mile] review-- ROLIE Vulnerability Extension
X-BeenThere: mile@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Managed Incident Lightweight Exchange, IODEF extensions and RID exchanges" <mile.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mile>, <mailto:mile-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mile/>
List-Post: <mailto:mile@ietf.org>
List-Help: <mailto:mile-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mile>, <mailto:mile-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 May 2019 16:13:18 -0000

Jess,

Thanks for the review. I’ve fixed your editorial notes.

In Section 6.2 I will be adding some property names, and have it fleshed out for the next version.
For the references in Section 8, I think that it’s a byproduct of how I’m handling my non-RFC references in the source XML. I’ll have to take a pass and patch it up.

Thanks,
Stephen

From: Jessica Fitzgerald-McKay <jmfmckay@gmail.com>
Sent: Friday, April 26, 2019 11:15 AM
To: Banghart, Stephen A. (Fed) <stephen.banghart@nist.gov>; mile@ietf.org
Subject: review-- ROLIE Vulnerability Extension

I promised to review the ROLIE Vulnerability Extension during the MILE meeting in Prague. Comments are below. Please let me know if you have any questions.

Thanks,
Jess
--------------------------------------------------------------

Section 1--
    The sentence beginning "Today, a number of formats" is a run on sentence.

    Ditto the sentence beginning "This extension does not attempt".
Section 3--
    Paragraph 1-- change "as per" to "per"
    Paragraph 2-- s/"Provided below is a non-exhaustive list of information that may be considered to be of a vulnerability information type."/Below is a non-exhaustive list of information that may be considered vulnerability information."
    Last sentence of section 3 ("Note again that. . . ") is a run on sentence.
Section 4--
    Data Format Requirements-- you say "software descriptor" when I think you mean " vulnerability descriptor". Maybe a copy/paste error?
    Section 4.2.2- s/"utilize"/"used"
Section 6.2-- will you be asking for any new rolie:property names? If so, I would at least create a TBD section here, as a placeholder.
Section 8-- this is super nitpicky, even for me, but is there a reason to use lower case references? It stuck me as unconventional, particularly since you capitalize the RFC references.

[mile] review-- ROLIE Vulnerability Extension Jessica Fitzgerald-McKay
Re: [mile] review-- ROLIE Vulnerability Extension Banghart, Stephen A. (Fed)