Re: [MMUSIC] [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

"Murray S. Kucherawy" <superuser@gmail.com> Thu, 16 July 2020 15:51 UTC

Return-Path: <superuser@gmail.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3FCCF3A0B04; Thu, 16 Jul 2020 08:51:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vbdUZ7KaALYS; Thu, 16 Jul 2020 08:51:39 -0700 (PDT)
Received: from mail-vk1-xa2d.google.com (mail-vk1-xa2d.google.com [IPv6:2607:f8b0:4864:20::a2d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 28A833A0AF9; Thu, 16 Jul 2020 08:51:38 -0700 (PDT)
Received: by mail-vk1-xa2d.google.com with SMTP id g22so1411937vke.9; Thu, 16 Jul 2020 08:51:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iumPHpFCmTZYt423qcE2NOZFJJiclR5QtS4H/mFqwuc=; b=tQJ7ZUhG6D8wulQiXIvE0djGg05N22SInP5jktnKy6NvCH9FBzq44brTblFgj2nWl9 PfwHHAQ3xiYlTo9g331G5HBIqbVlAbENR7qpKQ+EQNXYAmbqY0n9vjIfznY1ihP6o+6M fpIcZ8BHld+Y0vgcBfqFKYj4jMmrn99V3ZyP38pVUE8m6prrLbv3SrKN+paTTKsQcsCh ShNncXkLLA6yXU5L5v+N2aL+qiniilUFNPpMhrdPVcLd0xFzgBKmtP+LZNeoeyNTj88V 9VMR7BY+L3n8hYXL5/bdLioemrPAgN2LbzcteEHxT6aceAP8kqlYMQa3A56t3TeTIn5F wDKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iumPHpFCmTZYt423qcE2NOZFJJiclR5QtS4H/mFqwuc=; b=tRe8bh6SS8RGzN27XMTcTEdcauw/2Pas4auqCAYKlMx3cHym73shmPa/O7EUDSBGpc /9dvePfta2IDuSFjlufXKe+5z4Nh5rZI9652OuFk9OHqsIOu7YpUqo71PFoHs1CWo5ja GT+j+AT5j0hzov0zzOykrn8R61Clf8oHaab3MrrizZk2beVmmuJtK+3Eqb7uwo10ODiH /ztb7oq0M/zgLpDeCY8cprG28CcLix+oOghVms1gW/hbqhOC6glY+ziU8h7eO8GdWw0z GBlDSTRrJUT2V+wDcBx4k18V0CdW2dAMunMpx26784m4r9YhPgDl6LwiyyNVYPbmJ/JR 1d5Q==
X-Gm-Message-State: AOAM532M7MH6VDR4fAqz+73EpaDetfZ8S3SBydSskgKm3uS6U1KTFfYF WFUcfQkBlJ5JHNio5aIKiW06w9b8TnHDWrqZwMQ=
X-Google-Smtp-Source: ABdhPJxEJVsGWMFALAmQlSO6H+CNi5QfvW0PT/1O2fqAVOIp2RpMjb2yGp5aTv3WGCVu3k+8hZRWA5UV1EcRAmjQADI=
X-Received: by 2002:ac5:c76e:: with SMTP id c14mr3762236vkn.60.1594914697714; Thu, 16 Jul 2020 08:51:37 -0700 (PDT)
MIME-Version: 1.0
References: <159459362316.14150.6160122631877971567@ietfa.amsl.com> <AM7PR07MB7012B935296554B783A0995393600@AM7PR07MB7012.eurprd07.prod.outlook.com> <1f035833-3efe-3444-3387-1c8feac48538@gmail.com> <AM7PR07MB7012161C9A9BF60203923AB193610@AM7PR07MB7012.eurprd07.prod.outlook.com>
In-Reply-To: <AM7PR07MB7012161C9A9BF60203923AB193610@AM7PR07MB7012.eurprd07.prod.outlook.com>
From: "Murray S. Kucherawy" <superuser@gmail.com>
Date: Thu, 16 Jul 2020 08:51:26 -0700
Message-ID: <CAL0qLwYWX25wy9AcOB99Uoq=yLdu6yUjK8Qg84qk6iJG+J_Bfw@mail.gmail.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
Cc: Brian E Carpenter <brian.e.carpenter@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org" <draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000011ec305aa9104e7"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/7Yt7fnVpHrUJBgqP20NTrmSBBXo>
Subject: Re: [MMUSIC] [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jul 2020 15:51:42 -0000

If you email the files to internet-drafts@ietf.org and Cc: me, I'll approve
them and then the secretariat will put the update in the tracker.

-MSK

On Tue, Jul 14, 2020 at 5:39 AM Christer Holmberg <
christer.holmberg@ericsson.com> wrote:

> Hi,
>
> I have created a new version (-22) of the draft, based on Brian's comment.
>
> Murray, as the submission window is currently closed, are you able to
> manually submit the new version if I send you the files?
>
> Regards,
>
> Christer
>
>
>
> -----Original Message-----
> From: Brian E Carpenter <brian.e.carpenter@gmail.com>
> Sent: maanantai 13. heinäkuuta 2020 23.52
> To: Christer Holmberg <christer.holmberg@ericsson.com>; gen-art@ietf.org
> Cc: draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org;
> last-call@ietf.org; mmusic@ietf.org
> Subject: Re: [Gen-art] Genart last call review of
> draft-ietf-mmusic-msrp-usage-data-channel-21
>
> Thanks Christer, that all looks good to me,
>
> Regards
>    Brian
>
> On 13-Jul-20 20:58, Christer Holmberg wrote:
> > Hi Brian,
> >
> > Thank You for the review! Please see inline.
> >
> >
> > Nits:
> > -----
> >
> >>> 4.1.  MSRP URI
> >>> ....
> >>>     transport  /= "dc"
> >>>
> >>> I see that RFC7977 takes a slightly different approach to updating the
> ABNF:
> >>>
> >>>     transport  =  "tcp" / "ws" / 1*ALPHANUM
> >>>
> >> The advantage of listing out
> >>
> >>  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
> >>
> >> would be that the reader sees the full list.
> >
> > The MMUSIC WG has previously decided to take the approach of only
> writing the new value, using the "/=" format.
> >
> > ---
> >
> >>>                  ; Add "dc" to existing transports per [RFC4975]
> >>>
> >>> I suggest
> >>>
> >>>                 ; Add "dc" to existing transports per Section 9 of
> [RFC4975]
> >
> > Will modify as suggested.
> >
> > ---
> >
> >>> 4.6.  Session Closing
> >>>
> >>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
> >>>   present in the SDP answer if no corresponding attributes are present
> >>>   in the received SDP offer.
> >>>
> >>> Should that be MUST?
> >
> > The reason for "must" is that is referring to generic data channel SDP
> O/A procedures.
> >
> > I suggest to remove the paragraph.
> >
> > ---
> >
> >>> B2BUA
> >>>
> >>> Define the acronym please.
> >
> > We normally don't do that in MMUSIC specifications. Also, it is on the
> IETF list of well-known acronyms.
> >
> > Having said that, I am fine to enhance it on first occurrence:
> 'Back-to-Back User Agent (B2BUA)'
> >
> > ---
> >
> >>> 9.2.  Subprotocol Identifier MSRP
> >>>
> >>>   A reference to this document is added to the subprotocol identifier
> >>>   "msrp" in the "WebSocket Subprotocol Name Registry"
> >>>
> >>> s/this document/RFCXXXX/
> >
> > Will modify as suggested.
> >
> > ---
> >
> >>> 11.  CHANGE LOG
> >>>
> >>> Mark this section for deletion by the RFC Editor
> >
> > I think the RFC Editor will delete it by default, but we can add
> explicit text.
> >
> > Regards,
> >
> > Christer
> >
>