Re: [MMUSIC] Fwd: New Version Notification for draft-ietf-mmusic-rfc4566bis-20.txt

Paul Kyzivat <paul.kyzivat@comcast.net> Thu, 22 June 2017 19:16 UTC

Return-Path: <paul.kyzivat@comcast.net>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C83F6126B7E for <mmusic@ietfa.amsl.com>; Thu, 22 Jun 2017 12:16:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=comcast.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qBwFtb2kSwYm for <mmusic@ietfa.amsl.com>; Thu, 22 Jun 2017 12:16:23 -0700 (PDT)
Received: from resqmta-ch2-05v.sys.comcast.net (resqmta-ch2-05v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE05E124D85 for <mmusic@ietf.org>; Thu, 22 Jun 2017 12:16:22 -0700 (PDT)
Received: from resomta-ch2-16v.sys.comcast.net ([69.252.207.112]) by resqmta-ch2-05v.sys.comcast.net with SMTP id O7Zmdhbo7zz3dO7aYdUMKt; Thu, 22 Jun 2017 19:16:22 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1498158982; bh=jHQGVaQ+JiVAg5aFmxZ2jTIb6BjZBL5a37GBBA0IbzU=; h=Received:Received:Subject:To:From:Message-ID:Date:MIME-Version: Content-Type; b=K/QjRPv/BGNHXjMrRgyZnUqoM9rYwGwGi8zDItg3AGMM93T/x3Lc6pX+kzoUOafZ5 HIrc1yCYi1yExpL0TrFa7A0lGp0M6ut3mvXQt6immcjFXDdxXVReCW3oqt1swEdmrQ g8ArCg/9fDD6CJAXzpQdQW48skCLVobwoaVMiQsS33+2VjXiyJPFrAdk6UpB6xr3so SEWp4vCSMJBw3FBbN2er23Aq2IrO+ts+v1qAi+XHicnmXlErhERaYkAnaT6kaOJxmY 2hE2vNUiTDBRx/aqtA6wSvrDcEPovMjb0D6KWSl91PXn6mVKD0xOkAqGVQFcGHlMrP udtpMh+PA7I8Q==
Received: from [192.168.1.110] ([24.62.227.142]) by resomta-ch2-16v.sys.comcast.net with SMTP id O7aXdFLLZ96jtO7aXd5YPn; Thu, 22 Jun 2017 19:16:22 +0000
To: mmusic@ietf.org
References: <149765179618.24205.7010922835529746440.idtracker@ietfa.amsl.com> <CAA4Mczvi-+sCYHO9NO48wE8o6YTvZ-a216d1L_yLvgwFS9O3zw@mail.gmail.com> <aa23c37c-7e6a-fa18-29fb-0ae19be28b3c@comcast.net> <CAA4Mczu8a48rqQ7RRFKVOs83+9pK0DPcbbYdLa9y-NHOUt8B2w@mail.gmail.com>
From: Paul Kyzivat <paul.kyzivat@comcast.net>
Message-ID: <db09b6dd-aa54-82b2-b7ff-bc569fa375fc@comcast.net>
Date: Thu, 22 Jun 2017 15:16:21 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0) Gecko/20100101 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <CAA4Mczu8a48rqQ7RRFKVOs83+9pK0DPcbbYdLa9y-NHOUt8B2w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-CMAE-Envelope: MS4wfLqVQpnxG8OtJVnJRPdYepLzdQsN0cP+1IRR4qG2g3b9Z4bzoZJ03JrFTlhKCcmD8CA2k4PgAZNX/WaSoHMIWer+UwYgYmDfP4DFZKLKHCz9BZOTCVve 3mSfeVc/obMSeft+09SusuFI4UUZb3c92pprvsR5h2u7+9ZS1q3ZllT9
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/JGuIwclADGi6o9WYqKsg6m7Fm9U>
Subject: Re: [MMUSIC] Fwd: New Version Notification for draft-ietf-mmusic-rfc4566bis-20.txt
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jun 2017 19:16:25 -0000

One thing you missed in the ABNF def of media-description:

s/*attribute-fields/*attribute-field/

Otherwise looks good.

	Thanks,
	Paul

On 6/21/17 7:39 PM, Ali C. Begen wrote:
> Hi Paul
> 
> Thanks for catching the error. It is fixed and submitted now.
> 
> -acbegen
> 
> On Mon, Jun 19, 2017 at 6:02 PM, Paul Kyzivat <paul.kyzivat@comcast.net 
> <mailto:paul.kyzivat@comcast.net>> wrote:
> 
>     Hi Ali,
> 
>     On 6/16/17 6:32 PM, Ali C. Begen wrote:
> 
>         Hi everyone
> 
>         There have been some comments on and off the list regarding the
>         4566bis draft and with this update, I am hoping that I made all
>         the changed asked for. There were a few errors that were taken
>         care of, some ABNF syntax has been improved, references have
>         been updated, etc.
> 
>         https://www.ietf.org/rfcdiff?url1=draft-ietf-mmusic-rfc4566bis-18&url2=draft-ietf-mmusic-rfc4566bis-19
>         <https://www.ietf.org/rfcdiff?url1=draft-ietf-mmusic-rfc4566bis-18&url2=draft-ietf-mmusic-rfc4566bis-19>
> 
>         Please check whether you have outstanding issues or not. I saw
>         that the chairs updated the milestone for this draft, and from
>         my perspective, the draft is ready to go to WGLC.
> 
> 
>     I like the change to the grammar that moves the notation for
>     optionality/repetition of individual fields from the definition of
>     those fields to the overall definition of the session-description:
> 
>         session-description = proto-version
>                               origin-field
>                               session-name-field
>                               [information-field]
>                               [uri-field]
>                               *email-fields
>                               *phone-fields
>                               [connection-field]
>                               *bandwidth-fields
>                               1*time-fields
>                               [key-field]
>                               *attribute-fields
>                               *media-descriptions
> 
>     However, this change induced a bug in the definition of
>     media-descriptions:
> 
>         media-descriptions =  media-field
>                               information-field
>                               *connection-field
>                               bandwidth-fields
>                               key-field
>                               attribute-fields
> 
>     This needs the same changes made to session-description. So this
>     needs to be changed to:
> 
>         media-descriptions =  media-field
>                               [information-field]
>                               *connection-field
>                               *bandwidth-fields
>                               [key-field]
>                               *attribute-fields
> 
>     Also this change does result in some very odd naming, where the
>     names of some fields are plural but now ought to be singular. These
>     ought to be fixed. Specifically:
> 
>     email-fields => email-field
>     phone-fields => phone-field
>     bandwidth-fields => bandwidth-field
>     time-fields => time-field
>     attribute-fields => attribute-field
>     media-descriptions => media-description
> 
>     Otherwise the new version seems good to me.
> 
>              Thanks,
>              Paul
> 
>     _______________________________________________
>     mmusic mailing list
>     mmusic@ietf.org <mailto:mmusic@ietf.org>
>     https://www.ietf.org/mailman/listinfo/mmusic
>     <https://www.ietf.org/mailman/listinfo/mmusic>
> 
> 
> 
> 
> _______________________________________________
> mmusic mailing list
> mmusic@ietf.org
> https://www.ietf.org/mailman/listinfo/mmusic
>