[mpls] draft-andersson-mpls-lsp-ping-registries-update-01 - Updating the LSP Ping IANA registries

Carlos Pignataro <cpignata@gmail.com> Tue, 06 August 2019 20:14 UTC

Return-Path: <cpignata@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 976A5120223; Tue, 6 Aug 2019 13:14:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QTLUMHWpnMJY; Tue, 6 Aug 2019 13:14:12 -0700 (PDT)
Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC41D12013C; Tue, 6 Aug 2019 13:14:08 -0700 (PDT)
Received: by mail-qt1-x832.google.com with SMTP id r6so81701510qtt.0; Tue, 06 Aug 2019 13:14:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:cc:to; bh=EfEGkG71TbN9MXCOD2o0hBlbCcb74bDtzm5qF0X6ObI=; b=c8ZX7ZIMX1vhFmrnXHvnoGL8ATMupPj2S3VAUftbAgCaY5Wj+gRsbEb5eaEMPVKufr hrmwkl1gp3B/3nkK0An4ClPg56xQX2MTxiYjo9+IY/v8JkIfrHu9V7L93ryi2hRAkOag 9Y8+CfkMT6Q8lsjgpPAl/guKRqvxBh0Q04U32hoa8RFxIJ9TJGdUtM9knXnoZwpGPdhM uCSJ6ijBU1PtvFQmMxCpWbuqin198+l5M4Y+RB/dJM7a1ampBgUtL5cTohG7/Jlm/5SK vMvBriPOARs+bxeDN9VD0dl/11g4H6HcXABFos84aOqpMK0AKTb2NNxkYzJ8O6riKKVU eI4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:cc:to; bh=EfEGkG71TbN9MXCOD2o0hBlbCcb74bDtzm5qF0X6ObI=; b=iJDzFaUDWHfruTh15Zsi8DJUgtOu5BopYPSY/JcERCgApeAEgvjyiob2omx9hFy0iZ V8tYPSuMkagdXhTQwOPVAZI318NdjekSB06uzwNc7EpLY8tUlBH6HfEYL0f/HQLZ315t dOHMClH94nwtpI8QtyJP32tGgmxbiT1LEvtmQokh8LTJDC5mcJCZSfVesWbl+5CJFkPH vefP6bfTvrbVd4X4o04GSgrdxeA+w5vj2W6DeiChEKlsYIBNYKwzYjvvd+wQeNFnzc7T kgbfncH+BmczcCOykZoo2FmvSCodzfAbImfTRthODBBsmxJrqKqiSmh+P+L2aS9Cf5cW +mqw==
X-Gm-Message-State: APjAAAWA6CUNjzXYFG6nsD5hw/9x6oz4A3aKomMXciLwT+uu7D+1wzgA ZujDeD5lmGZe/+/ZL3hZT1Rtn4+/
X-Google-Smtp-Source: APXvYqwnopPA/ZC/lKV60zEx0w4O6aVB74CONcG9CwLAZQGckEV1QD6CmM59mcCZD09HXWmvf2lHvQ==
X-Received: by 2002:ac8:41ce:: with SMTP id o14mr4617093qtm.92.1565122447688; Tue, 06 Aug 2019 13:14:07 -0700 (PDT)
Received: from rtp-cpignata-nitro3.cisco.com ([173.38.117.89]) by smtp.gmail.com with ESMTPSA id z19sm40507089qtu.43.2019.08.06.13.14.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Aug 2019 13:14:06 -0700 (PDT)
From: Carlos Pignataro <cpignata@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_50C6D154-E110-46ED-A57F-DB6BF50E3220"
X-Mao-Original-Outgoing-Id: 586815245.254123-796a506b9bf332040ec2bdf42e1a0a1b
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Message-Id: <21011742-C1D6-4F64-852A-4C399139B840@gmail.com>
Date: Tue, 6 Aug 2019 16:14:05 -0400
Cc: draft-andersson-mpls-lsp-ping-registries-update@ietf.org, mpls <mpls@ietf.org>
To: Loa Andersson <loa@pi.nu>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/3FpcPiVAKxKSCSpi-ArdujUkQjg>
Subject: [mpls] draft-andersson-mpls-lsp-ping-registries-update-01 - Updating the LSP Ping IANA registries
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Aug 2019 20:14:15 -0000

Loa, Authors,

Please find comments and recommendations on, prefaced with “CMP":
https://tools.ietf.org/html/draft-andersson-mpls-lsp-ping-registries-update-01 <https://tools.ietf.org/html/draft-andersson-mpls-lsp-ping-registries-update-01> 


Updating the LSP Ping IANA registries

CMP: I would change the title to follow the actual name of the registration: “Updating IANA’s MPLS LSP Ping Parameters"


Abstract

   This document updates some registries in the LSP Ping IANA name
   space.  The updates are mostly for clarification and to align this
   registry with recent developments.


CMP: Similarly, s/LSP Ping/MPLS LSP Ping/ in the Abstract to match the registration.
CMP: Also, s/to align this registry/to align these registries/


Table of Contents

CMP: Editorial -> Arguably, the complete document is a set of “IANA Considerations”. That should be the main section encapsulating S2 and S3.

1.  Introduction


   When RFC 8029 [RFC8029] where published it contained among other

CMP: s/were published/was published/

   The LSP Ping IANA registries were partly updated to match RFC 8029,
   but the there were some ambiguity in the RFC, that were reflected in
   the registries.

CMP: s/were some ambiguity/was some ambiguity/.

CMP: However, I would not say there was “ambiguity”. I would instead write that the registrations can be further clarified and their definitions more precise.

   First the registries for Message Types [MessTypes], Reply Modes
   [re-Mode] and Return Codes [return-codes].  The changes to these
   registries are minor.


CMP: The anchor for all citations is confusing, and it gets mis-sorted. I recommend the following anchors throughout:


   OLD              NEW
  ----------------------------------
   [IANA-LSP-PING]  [IANA-LSP-PING]
   [MessTypes]      [IANA-MT]
   [re-Mode]        [IANA-RM]
   [return-codes]   [IANA-RC]
   [sub-1-16-21]    [IANA-Sub-n]
   [sub-11]         [IANA-Sub-11]
   [sub-20]         [IANA-Sub-20]
   ...
   [tlv-reg]        [IANA-TLV]


2.  Updating the Message Types, Reply Mode and Return Codes Registries


   The following changes are made to the Message Types, Reply Modes and
   Return Codes [MessTypes] registries.

CMP: Why only citation to message types?

   o  a small set of code points (4 code points) for experimental use is
      added, actually they are take from the range for "Private Use".

CMP: Gramar fixing needed.

   o  the registration procedure "Specification Required" is changed to
      "RFC Required" and the note "Experimental RFC needed" is removed


CMP: Please let’s fix the initial sentence capitalization


   IETF does not prescribe how the Experimental Use and Private Use sub-
   TLVs are handled; however, if a packet containing a sub-TLV from the
   Experimental Use or Private Use ranges is received by an LSR that
   does not recognize the sub-TLV, an error message MAY be returned if
   the sub-TLV is from the range 31744-32767, and the packet SHOULD be
   silently dropped if it is from the range 64512-65535.


CMP: Which specific error message is sent? This updates not only registration but also protocol constructs. As such, this should be called out in the abstract (since it already updates 8029)

4.  Security Considerations


   TBA

CMP: “This document does not introduce any additional security considerations beyond RFC 8029.”

   [return-codes]
              "Return Codes", <https://www.iana.org/assignments/
              mpls-lsp-ping-parameters/
              mpls-lsp-ping-parameters.xhtml#return-codes>.

CMP: In regards to all the references, the title needs to include “MPLS LSP Ping Parameters” before “, Return Codes”
CMP: Also the URI should be shorter: <https://www.iana.org/assignments/mpls-lsp-ping-parameters/#return-codes <https://www.iana.org/assignments/mpls-lsp-ping-parameters/#return-codes>>


   [RFC8611]  Akiya, N., Swallow, G., Litkowski, S., Decraene, B.,
              Drake, J., and M. Chen, "Label Switched Path (LSP) Ping
              and Traceroute Multipath Support for Link Aggregation
              Group (LAG) Interfaces", RFC 8611, DOI 10.17487/RFC8611,
              June 2019, <https://www.rfc-editor.org/info/rfc8611>.


CMP: This should be Informative.

I trust these are useful.

—
Carlos Pignataro, http://carlos.pignataro.net <http://carlos.pignataro.net/>

“Sometimes I use big words that I do not fully understand, to make myself sound more photosynthesis."