Re: [mpls] [Gen-art] Genart last call review of draft-ietf-mpls-rfc8287-len-clarification-02

"Carlos Pignataro (cpignata)" <cpignata@cisco.com> Tue, 06 August 2019 19:25 UTC

Return-Path: <cpignata@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5652512003F; Tue, 6 Aug 2019 12:25:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=Srs2TeFj; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=Fe3EycHB
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id elA_s2cf_8St; Tue, 6 Aug 2019 12:25:38 -0700 (PDT)
Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 860E0120059; Tue, 6 Aug 2019 12:25:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=9406; q=dns/txt; s=iport; t=1565119538; x=1566329138; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zOT4JcvqJm8x+/Cj4VN3s97WklttoxhzlC8iDHboHtE=; b=Srs2TeFjxHYJfB3cKE2czUCTEdMUYBkvSLa4Ggs7PBJe4kqwMl0Y3bAK Av5nEIRrfXMv7gVnirxhlCJeOrBB6HQbxRfVADB0TAVdZFdx+cmC89e24 v6rQ9wF8i6u4ZS5zVall5HcYWeuySGAWAfvjwa8WySMf7Ij122N7VxeZ6 I=;
IronPort-PHdr: =?us-ascii?q?9a23=3AwUkXxhB0tb11d0IhyW0jUyQJPHJ1sqjoPgMT9p?= =?us-ascii?q?ssgq5PdaLm5Zn5IUjD/qs03kTRU9Dd7PRJw6rNvqbsVHZIwK7JsWtKMfkuHw?= =?us-ascii?q?QAld1QmgUhBMCfDkiuJ+brYCozAM1qX15+9Hb9Ok9QS47z?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AHAADF00ld/5RdJa1mGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUwQBAQEBAQsBgURQA21VIAQLKgqEFINHA4RShl+CNiW?= =?us-ascii?q?XW4EugSQDVAkBAQEMAQEYCwoCAQGEPwIXgicjNAkOAQQBAQQBAQIBBm2FJwy?= =?us-ascii?q?FSgEBAQECAQEBEBEEDQwBASwLAQQLAgEIFAQCAiYCAgIlCxUQAgQBDQUigwA?= =?us-ascii?q?BgWoDDg8BAgygGQKBOIhgcX8zgnoBAQWFERiCEwMGgQwoAYtiF4FAP4ERJww?= =?us-ascii?q?TgU5QLj6CYQEBgWCDDDKCJow0LYIpjX2NP2cJAoIchlyJUoNzG4IvhyyOUY1?= =?us-ascii?q?KgTSGJY0Lgw4CBAIEBQIOAQEFgVA4gVhwFTsqAYJBPoIEDBcUgzqFFIU/coE?= =?us-ascii?q?pjBwBgSABAQ?=
X-IronPort-AV: E=Sophos;i="5.64,353,1559520000"; d="scan'208";a="310287251"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 06 Aug 2019 19:25:37 +0000
Received: from XCH-RCD-017.cisco.com (xch-rcd-017.cisco.com [173.37.102.27]) by rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id x76JPbAm023836 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 6 Aug 2019 19:25:37 GMT
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-RCD-017.cisco.com (173.37.102.27) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 6 Aug 2019 14:25:37 -0500
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 6 Aug 2019 14:25:36 -0500
Received: from NAM04-CO1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 6 Aug 2019 15:25:36 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QiLlH+6uND7vA2hS7bOAwnI599vxgstd9T488E3aDfcRV2MS1E6e/7NlvMe808ohjl6XLgRzq3DsfNCCM4F+AgXzX1vTZH76f1lAnWIjfBU637pPHH5grKbI+E6trSevfS5IIFVyrQ4LSWl8kf1gdFF+CBUTBPZr0Lz5Qr8mv3/FLl6EumrSa/4I2ACuj/jDA0NgnQFp+S3b/B1MtbD7MY7o6+zkYjaAhBHylxzUviTGezKM+fM1PyEJ/zwADk5etZd2CoICBi+oKskai8NcMUV5IpacDLPKJ61dcPF0GhZhH/fcJasy29DszGMdhPWtRIYBbsEPnvJk+DvN7YPMrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOT4JcvqJm8x+/Cj4VN3s97WklttoxhzlC8iDHboHtE=; b=l3FJGZiQzIapvntaG53cswd5iYSAXS9XcJFSu1H/GUSUvFQZqgdcFR/rYePnvaRFd+trYt0nV9D+RiLHnmh4VjvWjHxyU1qlY1APClvW02xmm7y/RGKBPNpJFJNEKewChGVl4pqEUFnrdD2mXhS09N3XJ7QYwwg84sqiD87s9uqOslW/iDWN3MbsVxJkrXXll6lv2q1fTnYYG9zN//ndBG0ZzK6Qj/SriWcctl8oPgqWMQm1/hbf7jqJtTnXL49EErKIlkieIpbR7fIbH26wYTHz0k+gS0bnGv+X5ms+z5DB5m1hMvMwSn6ky7A+aHul5XLj5IPzGhOVFpgEA0vE/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOT4JcvqJm8x+/Cj4VN3s97WklttoxhzlC8iDHboHtE=; b=Fe3EycHB1ARxE1n/njF04qVmHzVDa1VqTpq9w5iRkIQTl9Luuoq3qI7bf3ITeAnmFySu5BZVIg7pReJu6I/6XP9PsDC4/wM+oFwA5g2MR/1GKMKUNOgObm2z71fE/p4ftvwCecGu5aTtr7kAOItHeGYwCCsEVRl7n179KK8rARE=
Received: from BL0PR11MB3028.namprd11.prod.outlook.com (20.177.204.138) by BL0PR11MB2995.namprd11.prod.outlook.com (20.177.204.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.14; Tue, 6 Aug 2019 19:25:35 +0000
Received: from BL0PR11MB3028.namprd11.prod.outlook.com ([fe80::1129:b8ad:27b9:151f]) by BL0PR11MB3028.namprd11.prod.outlook.com ([fe80::1129:b8ad:27b9:151f%6]) with mapi id 15.20.2136.018; Tue, 6 Aug 2019 19:25:35 +0000
From: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
To: Alissa Cooper <alissa@cooperw.in>, Ines Robles <mariainesrobles@googlemail.com>
CC: "gen-art@ietf.org" <gen-art@ietf.org>, mpls <mpls@ietf.org>, "IETF discussion list" <ietf@ietf.org>, "draft-ietf-mpls-rfc8287-len-clarification.all@ietf.org" <draft-ietf-mpls-rfc8287-len-clarification.all@ietf.org>
Thread-Topic: [Gen-art] Genart last call review of draft-ietf-mpls-rfc8287-len-clarification-02
Thread-Index: AQHVRs/zloAY3rKNukOlb6za2o8+pKbuh/kAgAAD1gA=
Date: Tue, 6 Aug 2019 19:25:34 +0000
Message-ID: <FB34773A-D1D1-4457-8DD2-B9D2E6E298C1@cisco.com>
References: <156448869146.2787.8676709133801114398@ietfa.amsl.com> <10B18110-50E1-4969-841F-084158A3EFEE@cooperw.in>
In-Reply-To: <10B18110-50E1-4969-841F-084158A3EFEE@cooperw.in>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3445.104.11)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=cpignata@cisco.com;
x-originating-ip: [173.38.117.89]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8f6ca5af-2dd5-4542-69a9-08d71aa3dadb
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BL0PR11MB2995;
x-ms-traffictypediagnostic: BL0PR11MB2995:
x-ms-exchange-purlcount: 2
x-microsoft-antispam-prvs: <BL0PR11MB29955EEDE95D5FB0F170524BC7D50@BL0PR11MB2995.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0121F24F22
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(346002)(376002)(39860400002)(396003)(199004)(189003)(51914003)(99286004)(3846002)(6116002)(6506007)(4326008)(57306001)(53546011)(8676002)(8936002)(71190400001)(71200400001)(5660300002)(36756003)(2906002)(33656002)(305945005)(7736002)(478600001)(966005)(25786009)(186003)(81166006)(76176011)(102836004)(6246003)(81156014)(14454004)(53936002)(26005)(54906003)(66066001)(316002)(6512007)(2616005)(11346002)(486006)(476003)(110136005)(68736007)(6436002)(6486002)(66446008)(66556008)(64756008)(66476007)(86362001)(229853002)(66946007)(6306002)(50226002)(446003)(76116006)(256004)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR11MB2995; H:BL0PR11MB3028.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: QTvJEHq8nr8RXJH6MYPg1FGGuegbLyMon36hYYo0oWcXlgGB8K6m1GXNmwSJG9FzTPqcxo6gvYnt4X1li+KV8JWBvfj2hQP2p5TyNwdNQLqv5U5X4/aPTrX4moRNqqk/NOvqFnJyTBR4pQmE8c0s2KDte2k4Anj9ysY8HhWHhKubV8dOf5tEO5Ss++zq3ETF1D2m6JYXn3c4ffUuluSh8/1Cj3Fa5p1UjGec0wsye40iH8FCP+4ZcWDqSuyfSx8bXqBhqF8xCoRcvJeFYxmoITW1RNK/35g29CVBbALq1he4Bfdl6m1hZuaCi+r5xVzYBRFGe0FtaiPekHt28t2rwNXpiDrDuox4f4lTYSRLTXrAeYI/rMazAxBrUQOUH5xr4hrlABU8Q3ZtgLeEZMDsj8qg7ENubteykusbh2d/oww=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <648B8451FAB8C1428F94B834C8878DEA@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f6ca5af-2dd5-4542-69a9-08d71aa3dadb
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2019 19:25:34.9378 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cpignata@cisco.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2995
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.27, xch-rcd-017.cisco.com
X-Outbound-Node: rcdn-core-12.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/dLjdqe7WcZIsbs9fF9W0h_AhwDY>
Subject: Re: [mpls] [Gen-art] Genart last call review of draft-ietf-mpls-rfc8287-len-clarification-02
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Aug 2019 19:25:42 -0000

Hi, Ines, Many thanks for your very useful review!

Thanks Alissa for flagging this.

Please find some follow-up comments inline.

> On Aug 6, 2019, at 3:11 PM, Alissa Cooper <alissa@cooperw.in> wrote:
> 
> Ines, thanks for your review. I entered a DISCUSS ballot to get the figure fixed in Section 4.2.
> 
> Alissa
> 
> 
>> On Jul 30, 2019, at 8:11 AM, Ines Robles via Datatracker <noreply@ietf.org> wrote:
>> 
>> Reviewer: Ines Robles
>> Review result: Ready with Issues
>> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>> 
>> For more information, please see the FAQ at
>> 
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>> 
>> Document: draft-ietf-mpls-rfc8287-len-clarification-02
>> Reviewer: Ines Robles
>> Review Date: 2019-07-30
>> IETF LC End Date: 2019-07-31
>> IESG Telechat date: Not scheduled for a telechat
>> 
>> Summary:
>> 
>> I believe the draft is technically good. This document is well written.
>> 
>> The document updates RFC8287 by clarifying the length for the following Segment
>> ID Sub-TLVs: IPv4 IGP-Prefix Segment ID Sub-TLV, IPv6 IGP-Prefix Segment ID
>> Sub-TLV and IGP-Adjacency Segment ID Sub-TLV.
>> 
>> There are some minor issues detailed below that should be addressed.
>> 
>> Major issues: Not found
>> 
>> Minor issues:
>> 
>> 1- Section 3 - Requirements notation is not complete, it should be added:  "NOT
>> RECOMMENDED" and "...are to be interpreted as described in BCP 14 [RFC2119]
>> [RFC8174] when, and only when, they appear in all capitals, as shown here.”
>> 

Sure.

>> 2- Figure of Section 4.2: Type = 35 (IPv4 IGP-Prefix SID) ---> Type = 35 (IPv6
>> IGP-Prefix SID)
>> 

Indeed. Great catch and many thanks.

>> 2.1- It would be nice if the figures have a caption where we can point to the
>> figure number, and the figure number is referenced in the text. The same for
>> the table of Section 4.3.
>> 

We had thought about this, and received this comment before also, but since this is largely a fix and update to RFC 8287, we want to remain consistent to the format used there.

>> 3- Question: What do you think?
>> 
>> I think it would be nice to explain a bit more the length for the different
>> combinations of the table of Section 4.3, e.g. with tables as detailed below:

Thanks for this suggestion. To me, it seems a bit overkill to explain the the size of an IPv4 is 4 octets, and the size of an IPv6 is 16 octets, etc. The fact that we are including the table seems the right middle-ground for readability, thoroughness, and detailed-orientedness.

But thanks for the suggestion.

Best,

Carlos.

>> 
>> +-----------------------------+-------------------+
>> |            Field                               | Parallel (octets) |
>> |     rfc8287#section-5.3            +-----+------+------+
>> |                                                       | Any | OSPF | ISIS |
>> +-----------------------------+-----+------+------+
>> |      Local Interface ID                    |  4  |   4  |   4  |
>> +-----------------------------+-----+------+------+
>> |     Remote Interface ID                 |  4  |   4  |   4  |
>> +-----------------------------+-----+------+------+
>> | Advertising Node Identifier          |  4  |   4  |   6  |
>> +-----------------------------+-----+------+------+
>> |  Receiving Node Identifier             |  4  |   4  |   6  |
>> +-----------------------------+-----+------+------+
>> |           Reserved                                 |  2  |   2  |   2  |
>> +-----------------------------+-----+------+------+
>> |     Adj. Type + Protocol                     |  2  |   2  |   2  |
>> +-----------------------------+-----+------+------+
>> |       Sum Total octets =                      |  20 |  20  |  24  |
>> +-----------------------------+-----+------+------+
>> 
>> +-----------------------------+-------------------+
>> |            Field                                |   IPv4 (octets)   |
>> |     rfc8287#section-5.3             +-----+------+------+
>> |                                                        | Any | OSPF | ISIS |
>> +-----------------------------+-----+------+------+
>> |      Local Interface ID                     |  4  |   4  |   4  |
>> +-----------------------------+-----+------+------+
>> |     Remote Interface ID                 |  4  |   4  |   4  |
>> +-----------------------------+-----+------+------+
>> | Advertising Node Identifier           |  4  |   4  |   6  |
>> +-----------------------------+-----+------+------+
>> |  Receiving Node Identifier             |  4  |   4  |   6  |
>> +-----------------------------+-----+------+------+
>> |           Reserved                                  |  2  |   2  |   2  |
>> +-----------------------------+-----+------+------+
>> |     Adj. Type + Protocol                     |  2  |   2  |   2  |
>> +-----------------------------+-----+------+------+
>> |       Sum Total octets =                     |  20 |  20  |  24  |
>> +-----------------------------+-----+------+------+
>> 
>> +-----------------------------+-------------------+
>> |            Field                                |   IPv6 (octets)          |
>> |     rfc8287#section-5.3           +-----+------+------+
>> |                                                       | Any | OSPF | ISIS |
>> +-----------------------------+-----+------+------+
>> |      Local Interface ID                    |  16 |  16  |  16  |
>> +-----------------------------+-----+------+------+
>> |     Remote Interface ID                  |  16 |  16  |  16  |
>> +-----------------------------+-----+------+------+
>> | Advertising Node IdentifieR           |  4  |   4  |   6  |
>> +-----------------------------+-----+------+------+
>> |  Receiving Node Identifier              |  4  |   4  |   6  |
>> +-----------------------------+-----+------+------+
>> |           Reserved                                  |  2  |   2  |   2  |
>> +-----------------------------+-----+------+------+
>> |     Adj. Type + Protocol                     |  2  |   2  |   2  |
>> +-----------------------------+-----+------+------+
>> |     sum  Total octets =                       |  44 |  44  |  48  |
>> +-----------------------------+-----+------+------+
>> 
>> Nits/editorial comments: Issue tool: Summary: 0 errors (**), 0 flaws (~~), 0
>> warnings (==), 1 comment (--).
>> 
>> Thanks for this document,
>> 
>> Ines
>> 
>> _______________________________________________
>> Gen-art mailing list
>> Gen-art@ietf.org
>> https://www.ietf.org/mailman/listinfo/gen-art
>