Re: [mpls] wglc on draft-ietf-mpls-ldp-p2mp-11

IJsbrand Wijnands <ice@cisco.com> Tue, 08 February 2011 08:46 UTC

Return-Path: <ice@cisco.com>
X-Original-To: mpls@core3.amsl.com
Delivered-To: mpls@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 32B6C3A7058 for <mpls@core3.amsl.com>; Tue, 8 Feb 2011 00:46:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.299
X-Spam-Level:
X-Spam-Status: No, score=-2.299 tagged_above=-999 required=5 tests=[AWL=-0.300, BAYES_00=-2.599, J_CHICKENPOX_13=0.6]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R1QtM3RhAafi for <mpls@core3.amsl.com>; Tue, 8 Feb 2011 00:46:29 -0800 (PST)
Received: from av-tac-bru.cisco.com (weird-brew.cisco.com [144.254.15.118]) by core3.amsl.com (Postfix) with ESMTP id 105BE3A7019 for <mpls@ietf.org>; Tue, 8 Feb 2011 00:46:28 -0800 (PST)
X-TACSUNS: Virus Scanned
Received: from strange-brew.cisco.com (localhost.cisco.com [127.0.0.1]) by av-tac-bru.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id p188kYfd003285; Tue, 8 Feb 2011 09:46:34 +0100 (CET)
Received: from ams-iwijnand-8715.cisco.com (ams-iwijnand-8715.cisco.com [10.55.191.150]) by strange-brew.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id p188kXSc001183; Tue, 8 Feb 2011 09:46:33 +0100 (CET)
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: text/plain; charset="us-ascii"
From: IJsbrand Wijnands <ice@cisco.com>
In-Reply-To: <19338ACC-82B8-475B-94EE-6BB629F2674E@niven-jenkins.co.uk>
Date: Tue, 08 Feb 2011 09:46:32 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <15BD76E2-8C44-486D-932D-5E7FB81417C7@cisco.com>
References: <4CD8FD3E.4090507@pi.nu> <19338ACC-82B8-475B-94EE-6BB629F2674E@niven-jenkins.co.uk>
To: Ben Niven-Jenkins <ben@niven-jenkins.co.uk>
X-Mailer: Apple Mail (2.1081)
Cc: Ross Callon <rcallon@juniper.net>, mpls@ietf.org, Stewart Bryant <stbryant@cisco.com>
Subject: Re: [mpls] wglc on draft-ietf-mpls-ldp-p2mp-11
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Feb 2011 08:46:30 -0000

Hi Ben,

Thanks for the detailed comments below. See inline.

> Below are my editorial comments on draft-ietf-mpls-ldp-p2mp-11:
> 
> 1) Abstract:
> 
> "These extensions are also referred to as mLDP Multicast LDP"
> 
> Should that be "These extensions are also referred Multicast LDP (mLDP)"?

Changed it to "These extensions are also referred to as	Multicast LDP (mLDP)"

> 2) Section 1 - Introduction:
> 
> Seems to mix root/leaf & ingress/egress. Should probably try and be consistent and pick on set of terms?

It looks correct to me. The term 'leaf' can be seen as a more generic way to describe a leg of a MP-LSP, since when it comes to MP2MP a leaf can be both ingress and egress. Also, root and ingress don't have to be the same when it comes to MP2MP LSPs.

> 3) Section 1 - Introduction:
> 
> The last sentence seems a little strangely worded. Maybe something like "

>  [I-D.ietf-mpls-mp-ldp-reqs], [I-D.ietf-l3vpn-2547bis-mcast] and [RFC4875].
> 
> [Note: I reordered the references as I think the reqs & l3vpn documents are more relevant to this document than P2MP RSVP-TE]

Sounds good.

> 4) 2.4.1.1, para 2 s/amoung/among/

Done.

> 5) 2.4.2 s/The following lists/The following sections list/

Done.

> 6) Section 4.3, bullet 6, 2nd sentence s/Label L MUST/Label Lu MUST/

Done.

> 7) Section 4.3.1.3 bullet 1 s/bases/basis/

Done.

> 8) Section 4.3.1.3 bullet 2 s/build/built/

Done.

> 9) Section 4.4.2 s/The following lists/The following sections list/

Done.

> 10) Section 5 use LFT but it is not expanded anywhere.

Done.

> 11) Section 6.2.1 s/and an additional information/and any additional information/

Done.

> 12) Section 7.1.1 s/LSP label is send to the upstream LSR/LSP label is sent to the upstream LSR/

Done.

> 13) Section 7.1.1 s/installed the context/installed in the context/

Done.

> 14) Section 9.4.3 s/that an other/that another/

Done.

> 15) Section 9.4.4 s/is send to/is sent to/

Done.

> 16) Section 9.4.5 s/are send to/are sent to/

Done.

> 17) Section 15.1
> 
> draft-ietf-mpls-upstream-label-05 is now RFC5331
> 
> draft-ietf-mpls-ldp-upstream-02 is now draft-ietf-mpls-ldp-upstream-08
> 
> draft-ietf-mpls-ldp-capabilities-02 is now RFC5561
> 
> draft-ietf-mpls-ldp-typed-wildcard-07 is now RFC5918

Fixed.

> 
> 
> 18) Section 15.2
> 
> draft-ietf-mpls-mp-ldp-reqs-04 has expired

Has been updated now.

> 
> draft-ietf-l3vpn-2547bis-mcast-06 is now draft-ietf-l3vpn-2547bis-mcast-10
> 
> draft-ietf-mpls-multicast-encaps-09 is now RFC 5332

Fixed.

Thx,

Ice.


> On 9 Nov 2010, at 07:50, Loa Andersson wrote:
> 
>> Working Group,
>> 
>> 
>> this is to start a 2 week+ working group last call on
>> draft-ietf-mpls-ldp-p2mp-11.
>> 
>> Please review the document and send comments to the
>> mpls@ietf.org mailing lsit.
>> 
>> The working group last call ends November 26 - 2010.
>> 
>> /Loa
>> 
>> -- 
>> 
>> 
>> Loa Andersson                         email: loa.andersson@ericsson.com
>> Sr Strategy and Standards Manager            loa@pi.nu
>> Ericsson Inc                          phone: +46 10 717 52 13
>>                                            +46 767 72 92 13
>> _______________________________________________
>> mpls mailing list
>> mpls@ietf.org
>> https://www.ietf.org/mailman/listinfo/mpls
> 
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls