Re: [mpls] mpls-rt review of draft­-rhd­-mpls­-tp­-psc­-sd

"Hejia (Jia)" <hejia@huawei.com> Mon, 02 September 2013 13:15 UTC

Return-Path: <hejia@huawei.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A134A21F9E7C for <mpls@ietfa.amsl.com>; Mon, 2 Sep 2013 06:15:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.147
X-Spam-Level:
X-Spam-Status: No, score=-6.147 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_MED=-4, SARE_SUB_ENC_UTF8=0.152]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FUtcEJxBg6re for <mpls@ietfa.amsl.com>; Mon, 2 Sep 2013 06:15:00 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) by ietfa.amsl.com (Postfix) with ESMTP id 59F9521F9E54 for <mpls@ietf.org>; Mon, 2 Sep 2013 06:14:59 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml204-edg.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.5-GA FastPath queued) with ESMTP id AWV05437; Mon, 02 Sep 2013 13:14:46 +0000 (GMT)
Received: from LHREML403-HUB.china.huawei.com (10.201.5.217) by lhreml204-edg.china.huawei.com (172.18.7.223) with Microsoft SMTP Server (TLS) id 14.3.146.0; Mon, 2 Sep 2013 14:13:43 +0100
Received: from SZXEML457-HUB.china.huawei.com (10.82.67.200) by lhreml403-hub.china.huawei.com (10.201.5.217) with Microsoft SMTP Server (TLS) id 14.3.146.0; Mon, 2 Sep 2013 14:13:52 +0100
Received: from SZXEML505-MBX.china.huawei.com ([169.254.1.227]) by szxeml457-hub.china.huawei.com ([10.82.67.200]) with mapi id 14.01.0323.007; Mon, 2 Sep 2013 21:13:44 +0800
From: "Hejia (Jia)" <hejia@huawei.com>
To: "mpls-chairs@tools.ietf.org" <mpls-chairs@tools.ietf.org>, "draft-rhd-mpls-tp-psc-sd@tools.ietf.org" <draft-rhd-mpls-tp-psc-sd@tools.ietf.org>
Thread-Topic: mpls-rt review of draft­-rhd­-mpls­-tp­-psc­-sd
Thread-Index: AQHOn/OhmPz5oTrmikC8gEB2kylY35mye39Q
Date: Mon, 02 Sep 2013 13:13:43 +0000
Message-ID: <735916399E11684EAF4EB4FB376B71952C73992F@SZXEML505-MBX.china.huawei.com>
References: <521746E5.6010204@pi.nu>
In-Reply-To: <521746E5.6010204@pi.nu>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.66.76.169]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Cc: "mpls@ietf.org" <mpls@ietf.org>
Subject: Re: [mpls] mpls-rt review of draft­-rhd­-mpls­-tp­-psc­-sd
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Sep 2013 13:15:05 -0000

Hi All,

I didn't receive my review mail... Resend it...

======

Hi ,

I have finished reviewing draft-rhd-mpls-tp-psc-sd-00.txt as the member of MPLS Review team and have the following comments:

* Is the document coherent?

Yes. It describes the rational to complement current RFC 6378 with protection switching protocol associated with Signal Degrade (SD) and provides the text proposal accordingly.


* Is it useful (i.e., is it likely to be actually useful in operational networks), and is the document technically sound?

Yes.  The document is motivated by enhancing current RFC 6378 to meet ITU-T protection switching requirements (in ITU-T liaison statements) and align with MPLS-TP survivability framework defined in RFC6372. It completes the placeholders wrt SD in RFC 6378.


* Is the document ready to be considered for WG adoption?

Yes. But I have the following comments which appreciates consideration when further developing this document. 
 
1) I notice that the priority issue of "FS" and "SF-P" is not fixed in this document but in another separate document, but they may impact the same paragraph of the text. This may cause misunderstanding if people do not read the other PSC-related drafts together. However, by reading the presentation of the Berlin meeting, there seems another planned draft to integrate all the PSC-related drafts, which may solve this comment. Right? 

2) Typo: Page 14, the first sentence of the second paragraph under 5.10, 

      A local SD-P SHALL cause the LER to go to local Unavailabe state
      and begin transmitting an SD(0,0) message, it the current state is
      due to a (local or remote) MS command.

s/it/if



3) Typo: Page 17, the last three paragraphs, s/SF-W/SD-W



Thanks!


B.R.
Jia

-----邮件原件-----
发件人: Loa Andersson [mailto:loa@pi.nu] 
发送时间: 2013年8月23日 19:26
收件人: draft??-rhd??-mpls??-tp??-psc??-sd@tools.ietf.org; Eric Gray; Kamran Raza (skraza); Sam Aldrin; Hejia (Jia)
抄送: mpls-chairs@tools.ietf.org; Eric Osborne (eosborne)
主题: mpls-rt rebiew of draft-rhd-mpls-tp-psc-sd

Authors and reviewers,

I originally asked for mpls-rt reviews as seen below

draft­-rhd­-mpls­-tp­-psc­-sd
------------------------
eric osborne
sam aldrin
eric gray
kamran raza

However, it turns out that Eric O is on PTO a little too long
to be optimal; I've there for asked Jia to do this review instead.
She has indicated that she will have the review done by Thu Aug 29.

I guess that Eric O will comment on any psc-draft as necessary, when
he is back.

I don't think this "delay" mean that much, we will be able to
catch up.

Eric G, Sam and Kamran - please review as planned, but if you are
short of time please focus on getting your other document in first.
And line up with Jia's dead line for this document.

/Loa
-- 


Loa Andersson                        email: loa@mail01.huawei.com
Senior MPLS Expert                          loa@pi.nu
Huawei Technologies (consultant)     phone: +46 739 81 21 64