[mpls] Review of draft-mirsky-mpls-bfd-bootstrap-clarify

Carlos Pignataro <cpignata@gmail.com> Wed, 24 January 2024 19:56 UTC

Return-Path: <cpignata@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 265DAC151545 for <mpls@ietfa.amsl.com>; Wed, 24 Jan 2024 11:56:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q2P4VDgNajof for <mpls@ietfa.amsl.com>; Wed, 24 Jan 2024 11:55:59 -0800 (PST)
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D69AC15152B for <mpls@ietf.org>; Wed, 24 Jan 2024 11:55:59 -0800 (PST)
Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-55a5e7fa471so5341113a12.1 for <mpls@ietf.org>; Wed, 24 Jan 2024 11:55:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706126157; x=1706730957; darn=ietf.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ogxcg6Bt3MXzyeH15ray919a8DgGr0vDT+Y0+y6WqeQ=; b=G9hKJ8Fn8HjySTNypczSIdXANnGAvIAMQw4qiO5Z8JA0PSawP8qv/4DSLP9jZflBse ochWoDET4VtpPn4vRM3nEh9Rqlv9g3kRzX5TbEWVHKgLR9vZM8BHZ8inE3tv7tfk55UZ eH0SZTwH44RopVcSzGHHzVpWKVzuM9VVmC4/e0Ly/Ca1VxbaFhTuxe+DMNyP4XmSgrgh RdcgM+lmNRe0wY39UXQyqTUB1rZ7IRraWp2ydTbOc9hNVwpE3b1RBC9fBGg901ySORLB 6r0X5yN8RsBpitNIPScHofqs2szjTZGpPfbMNSHTWybztq95iWFAceFdOFEmK8GpQq9/ E4Fw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706126157; x=1706730957; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ogxcg6Bt3MXzyeH15ray919a8DgGr0vDT+Y0+y6WqeQ=; b=HxjT9KWtklB4rXgvaaWCRwW25IgrCIQ+A5zOh+rraY9/2lqukNVbeHGVjyHEnpIymr CA3FZFme0qGlbnG4mnquCyTqnvIW3uBejp+JSCcZATQmzTdhbTJcFR6/nYVwwjFqyJyr L2hH4YF0DOjLzKFFVmxT/V/I9FuRJzNwaiEkJWtmyHCa1T6zrVXTWBPRH7WEO+LQbGmC Hpg0auJ67nPPdXMaaCOA7V/+GAkeuSarZAuR/W/kdVATmyIzGWNg4Jfst+jaYMYyuvUL TONfXN8qNKc67lHrojZRUHy7yUQurA62AnbYdLzSTKy9CTOPIgTvnWIZM8QnGJbzImV/ GkdQ==
X-Gm-Message-State: AOJu0YwuEIEUu5/22mhQhAkdHwn3h9LEnVPpZoNQut5LsEFFWOT/tpDb ZK7zvtJn+Y/IhcU8EZLgfu0Kiq22RJXE8hqWFmUN8DiOYbyt0prwvd7PbB1pvPMnjJl87Dv7w0g yR80Jn/jEBb3fGD+D8yirYI29tvi6Q0DKFRRGOg==
X-Google-Smtp-Source: AGHT+IE2eKsxhP6X1ov8AlMu+uWGLvyJwpiaLu02tTWK7EYfUfnyKXJAcJ86GIrqx65sb53EuR6Wz11yT2JivTJd354=
X-Received: by 2002:a17:906:4097:b0:a30:33e3:504e with SMTP id u23-20020a170906409700b00a3033e3504emr983021ejj.120.1706126157340; Wed, 24 Jan 2024 11:55:57 -0800 (PST)
MIME-Version: 1.0
From: Carlos Pignataro <cpignata@gmail.com>
Date: Wed, 24 Jan 2024 14:55:45 -0500
Message-ID: <CACe62MmreLuNR5s10zhDCh+x2p1JXY1_J6dUPDtpcD9jEjsZQw@mail.gmail.com>
To: mpls@ietf.org
Content-Type: multipart/alternative; boundary="0000000000008ce388060fb673fc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/Ch5giz4OzWVtDW2YIp225wVAISU>
Subject: [mpls] Review of draft-mirsky-mpls-bfd-bootstrap-clarify
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jan 2024 19:56:04 -0000

Hi!

Review of draft-mirsky-mpls-bfd-bootstrap-clarify
Version 05
Type Getting Ready for WG Adoption
Team MPLS WG Review Team
Reviewer: Carlos Pignataro

I have been asked to provide a ‘getting ready for WG adoption’ review of
this document, on behalf of the MPLS WG review team.

There are generally two relevant questions at this stage:

1. knowing whether the document is in scope for the working group, and
2. knowing whether the document is ready to be considered for WG adoption

My perspective is that:

1. Maybe - RFC 4884, the RFC that this document would update if approved,
was progressed as draft-ietf-bfd-mpls in the bfd wg. As such, I wonder if
that ought to be followed here. From a practical standpoint, both WGs (mpls
and bfd) would have to review this document, but it is a chair decision and
guidance whether this should live in mpls or bfd (and frankly I have no
strong position either way so long as both WGs are in the loop, simply
pointing historic datapoints.) The document is clearly in scope on the
intersection of both WGs, and historically was in bfd.

2. Yes – this document addresses clear clarifications for implementation
interoperability. Granted, this protocol is deployed without these
clarifications, but are (at least) theoretical gaps.

A couple of further comments, since I read the document. Overall, well
written and clear, achieves its goal, and:

a. Backwards compatibility is paramount, and neither of those two words
appear in the document. I recommend a section detailing implications.

b. Section 5, IPv6, seems like an after-though, since it is not mentioned
in the Abstract. Further, that case and explanation is well covered in RFC
8029, and as such seems like a distraction.

c. There are various nits and an editorial pass would help with clarity.
These include things like unqualified “echo reply” uses.

Thanks,

Carlos Pignataro