Re: [mpls] MPLS-RT review of draft-mirsky-mpls-p2mp-bfd-04

Greg Mirsky <gregimirsky@gmail.com> Wed, 24 October 2018 18:12 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9AB98124C04; Wed, 24 Oct 2018 11:12:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R6sY-xAA1uyI; Wed, 24 Oct 2018 11:12:02 -0700 (PDT)
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9FBE312777C; Wed, 24 Oct 2018 11:12:01 -0700 (PDT)
Received: by mail-lj1-x236.google.com with SMTP id z9-v6so833121ljk.9; Wed, 24 Oct 2018 11:12:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/oIlYObUXHp3lqKN3YlDR3shXWZLWnYOvaLgb3cVH6Y=; b=puMZOBi+PuNQdZU8WUJ+wCMZb1iZc1hS+Aquy2WDNonIuhZLrpAx7hhc7qUJa+elMq k0m1r5qR2Rms0nYaNdJoWlUwA7CJM7KuK3c/PjqIXOVsW0KX4KBxqF+00llqjErgyjex beSdYACFKew/UZ8DTNuNiiKLFu5xnG1XfjG41tacNfBI2eKxdi33ALPS6RtnQiH1a83V 96NQp1WDOoBLT2RFKklUgkcYbo70vFrETwRAr/f11I5OFcElQLCYANiNi3kLhOXKI13o vQkUtMTWfD5WlnbUwbigsWmBK7/W3+E50fDGCAMW/Ov/ucF2w01/xYoJPC64s2tOqI93 OYUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/oIlYObUXHp3lqKN3YlDR3shXWZLWnYOvaLgb3cVH6Y=; b=DeFSF6WTTG64Z8URZoFsuiY1LvOtpiCef//EQojKWwU0+IITAf2ok8dje+Fy7/N9DB vxvSCkc4hYUshRxldCXb2Iu9CX/58IEt0XuOfTvr/WCofxkQt8tMKt1LllFDaPtbt3Au XbiL7AOJut4FTQBNDa3Wa90p8AF/FMZG6zMN79kVBIocsp9HMBPsaIQNmoFtXAeT4tix 7xRXw0OpqhcuHmoBgktCr9GptMX9RtduXmLuszP7FZYs3bPM3KaIFp7gmJ1CE3uPqA6P UXY5FvVURyUqK9+OZ8n1zkaJ/jghVeoi1vhXZAW4lVtntY+4lGgMBLKHsCZr0xqZbrdF c6kA==
X-Gm-Message-State: AGRZ1gKYLA6HLWusrP+iJ4eWgdC9bIwHnFHKZ6Z0mJMsJU92H+c4wkTv kwTOaezRqL4KTgHr49AsjNHhzcYG1tZiyJ/Ll9o=
X-Google-Smtp-Source: AJdET5dd9EviLoYJacytFVeeG3EyY/f+ui+7wH0BvzWUpG/isEz3h+/9T+v1oAIv46IrzmVrlViZcO3CXwHrcxvy8Bw=
X-Received: by 2002:a2e:4611:: with SMTP id t17-v6mr2409310lja.92.1540404719666; Wed, 24 Oct 2018 11:11:59 -0700 (PDT)
MIME-Version: 1.0
References: <CAA=duU2kQWCg5CfidXAw8M+1VivgY=C2cehCcEVUQ0D_1yYxSg@mail.gmail.com>
In-Reply-To: <CAA=duU2kQWCg5CfidXAw8M+1VivgY=C2cehCcEVUQ0D_1yYxSg@mail.gmail.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Wed, 24 Oct 2018 11:11:49 -0700
Message-ID: <CA+RyBmVLDKOsaJhDzdDKmF9WEk1Hwg7-LN25onVdK3fXk7bHSw@mail.gmail.com>
To: "Andrew G. Malis" <agmalis@gmail.com>
Cc: mpls-chairs@ietf.org, draft-mirsky-mpls-p2mp-bfd@ietf.org, mpls@ietf.org
Content-Type: multipart/alternative; boundary="000000000000204c3b0578fd6ca4"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/Jw24ztrN6EgPD4ZtkXRjrF6dEHY>
Subject: Re: [mpls] MPLS-RT review of draft-mirsky-mpls-p2mp-bfd-04
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 18:12:04 -0000

Dear Andy,
thank you for your thorough review and the most helpful comments. I'll work
on the update to address them.

Regards,
Greg

On Wed, Oct 24, 2018 at 9:17 AM Andrew G. Malis <agmalis@gmail.com> wrote:

> I’ve been selected as an MPLS-RT reviewer for
> draft-mirsky-mpls-p2mp-bfd-04, which is currently a candidate for MPLS WG
> adoption. This draft documents procedures for using BFD for multipoint
> networks to detect data plane failures in MPLS p2mp LSPs.
>
> The BFD WG has been working on draft-ietf-bfd-multipoint, which describes
> BFD procedures for multipoint and multicast networks.
> draft-mirsky-mpls-p2mp-bfd uses that draft as a basis to detect MPLS data
> plane failures for p2mp LSPs. This is a straightforward and useful
> application of the BFD draft for MPLS data plane failure detection.
>
> However, I would have expected to see at least a reference to RFC 4687,
> "Operations and Management (OAM) Requirements for Point-to-Multipoint MPLS
> Networks", and some text on how this draft addresses the requirements in
> that draft.
>
> I also expected more text on the relationship between this draft and RFC
> 6425, "Detecting Data-Plane Failures in Point-to-Multipoint MPLS -
> Extensions to LSP Ping"', and more of an explanation of why the keyword MAY
> is used in sections 4.1 and 4.2 - what are the implications of following or
> not following the MAY in each case?
>
> The draft also needs an editing pass, for example "MaultipointHead" for "MultipointHead"
> and some incorrect English grammar in several places.
>
> Once these items have been addressed, I think that the draft should be
> ready for an adoption call.
>
> Cheers,
> Andy
>
>
>