IETF Logo Mail Archive

Re: [mpls] MPLS-RT review of draft-mirsky-mpls-p2mp-bfd-04

Greg Mirsky <gregimirsky@gmail.com> Tue, 30 October 2018 15:05 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C7AF9128CFD; Tue, 30 Oct 2018 08:05:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.598
X-Spam-Level:
X-Spam-Status: No, score=-0.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_COMMENT_SAVED_URL=1.391, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hgh3iXtdhMUc; Tue, 30 Oct 2018 08:05:40 -0700 (PDT)
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 637C61293FB; Tue, 30 Oct 2018 08:05:39 -0700 (PDT)
Received: by mail-lj1-x235.google.com with SMTP id z80-v6so5633528ljb.8; Tue, 30 Oct 2018 08:05:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=utC3m10/kM6fnfBuOfasivAFuApUbyl9lgARJSnZFm4=; b=Gd2agq49e2kUD44Syy3JXMObmPZmQRZaD44drh3o1GhIT+7bQrTjj/P0W4K8zIzyWw dfiINmoszEGmcpbsWGiTwIL94wiQZYOErB6ZFT3a8sTStr61zAg8ytZUofimCmUS/Grm ZivY4i56sqXqFF2CP1W2ojvtwwti7WAOkgL7ub7FSt/V+50P7qauvbrGzo9lK57ViL/H K3d4EIaO/GkSggOJ3rK6Hj7FADD9KNWjbe8TMaOMXFwWiXBNfGsBdfjuoL9WoOYnHM7k xrZBCroJD+JEqJ+pfoQLcWXLHPrGoSQ8Sr5Le31jMwWpMpBmqMD0NR0NjMHyZFdTEItq HtQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=utC3m10/kM6fnfBuOfasivAFuApUbyl9lgARJSnZFm4=; b=T/gSkv1ge8CDhMFLwwZ3GQhZ/weJuiOup7mfJt5e5rjfIDn62KB9sMtrGKXgMH6whf omvJfZMPxD59H0Nxtssghi8nVrOQN2WK/kaqF7PAZwmLSEDY5aSuFajzJyeWvneeAWQN NrzC/0p0zLx7KQWDarasH1X7uenYeLGwod6v7DHaoxJTwuRTLD7PlpwgP1uI17VHx6vd iE0+2pgmOSodsmXqdbdKKpvbuAcF55Ic7fmXyJypu+MkDsuN/PMoIVngew8Om2bCBhfM Na0L1/kmyHXnFve41O5Qh2rv3Aj2ATKAEr8q7iucJnaYqTURcWVBo2vYzqojxZBCIpb/ 9nyw==
X-Gm-Message-State: AGRZ1gJj+UDdP1EezORSpvwF53GRLbenBA072CaQhkYr7Gi36ggGnL8F JpsgUTMexIpJ20PCgegsxeYCfe9Cc+g0NKh7q6Y=
X-Google-Smtp-Source: AJdET5cAcyB31pzddvOaShxD8kJQNSsQLZnELEf1UaItfODFXhYz/z9rszMA8pNbOHagLtHhoT75R0kD1glb/QYY4IQ=
X-Received: by 2002:a2e:b1d2:: with SMTP id e18-v6mr4815313lja.34.1540911937423; Tue, 30 Oct 2018 08:05:37 -0700 (PDT)
MIME-Version: 1.0
References: <CAA=duU2kQWCg5CfidXAw8M+1VivgY=C2cehCcEVUQ0D_1yYxSg@mail.gmail.com> <CA+RyBmVLDKOsaJhDzdDKmF9WEk1Hwg7-LN25onVdK3fXk7bHSw@mail.gmail.com>
In-Reply-To: <CA+RyBmVLDKOsaJhDzdDKmF9WEk1Hwg7-LN25onVdK3fXk7bHSw@mail.gmail.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Tue, 30 Oct 2018 08:05:28 -0700
Message-ID: <CA+RyBmXeQp+jFji-s5SsMDZTiwgNZ2Zfkcc0NHhwvnQ7jegdow@mail.gmail.com>
To: "Andrew G. Malis" <agmalis@gmail.com>
Cc: mpls-chairs@ietf.org, draft-mirsky-mpls-p2mp-bfd@ietf.org, mpls@ietf.org
Content-Type: multipart/mixed; boundary="000000000000a92676057973847b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/kms2X6avv2L52YMOgNdP67Vceps>
Subject: Re: [mpls] MPLS-RT review of draft-mirsky-mpls-p2mp-bfd-04
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 15:05:45 -0000

Dear Andy,
thank you for the review and the detailed suggestions. Attached please find
the updated version of the draft and the diff to highlight the proposed
changes. Please let me know if these address your comments.

Kind regards,
Greg

On Wed, Oct 24, 2018 at 11:11 AM Greg Mirsky <gregimirsky@gmail.com> wrote:

> Dear Andy,
> thank you for your thorough review and the most helpful comments. I'll
> work on the update to address them.
>
> Regards,
> Greg
>
> On Wed, Oct 24, 2018 at 9:17 AM Andrew G. Malis <agmalis@gmail.com> wrote:
>
>> I’ve been selected as an MPLS-RT reviewer for
>> draft-mirsky-mpls-p2mp-bfd-04, which is currently a candidate for MPLS WG
>> adoption. This draft documents procedures for using BFD for multipoint
>> networks to detect data plane failures in MPLS p2mp LSPs.
>>
>> The BFD WG has been working on draft-ietf-bfd-multipoint, which describes
>> BFD procedures for multipoint and multicast networks.
>> draft-mirsky-mpls-p2mp-bfd uses that draft as a basis to detect MPLS data
>> plane failures for p2mp LSPs. This is a straightforward and useful
>> application of the BFD draft for MPLS data plane failure detection.
>>
>> However, I would have expected to see at least a reference to RFC 4687,
>> "Operations and Management (OAM) Requirements for Point-to-Multipoint MPLS
>> Networks", and some text on how this draft addresses the requirements in
>> that draft.
>>
>> I also expected more text on the relationship between this draft and RFC
>> 6425, "Detecting Data-Plane Failures in Point-to-Multipoint MPLS -
>> Extensions to LSP Ping"', and more of an explanation of why the keyword MAY
>> is used in sections 4.1 and 4.2 - what are the implications of following or
>> not following the MAY in each case?
>>
>> The draft also needs an editing pass, for example "MaultipointHead" for "MultipointHead"
>> and some incorrect English grammar in several places.
>>
>> Once these items have been addressed, I think that the draft should be
>> ready for an adoption call.
>>
>> Cheers,
>> Andy
>>
>>
>>

v2.23.0 | Report a Bug | By Email