Re: [mpls] MPLS-RT review of draft-ryoo-mpls-tp-aps-updates-02.txt

Stewart Bryant <stewart.bryant@gmail.com> Thu, 03 March 2016 14:43 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 907B71AD05E for <mpls@ietfa.amsl.com>; Thu, 3 Mar 2016 06:43:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sx73k3PoHHAG for <mpls@ietfa.amsl.com>; Thu, 3 Mar 2016 06:43:18 -0800 (PST)
Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A50CA1AD06A for <mpls@ietf.org>; Thu, 3 Mar 2016 06:43:17 -0800 (PST)
Received: by mail-wm0-x229.google.com with SMTP id p65so37956804wmp.1 for <mpls@ietf.org>; Thu, 03 Mar 2016 06:43:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=BcdGMQWmTxBqo8UOEjrOkV+1KIZIMMxrmDlUfQFm9UE=; b=UDoYfV9pApIQcBAcrO3ncR+8Al6Z9YrGJ4P0tBJ7ld0+SBlm03o7iXFk12cTLcuROL xxZ6u/HHrkjYkkKt29nV4Yo1gBC8zz+JkWapADvD3lLDkYyZq2lgh0CH002r+R7CC+PS bQEpB5xDp3HidVFIiKdrgt5a7nvtobHuvDnbwenCYE8kmrY5FSt7cNbXt4GJ/lNG/O0S 6I4vnfhFkd7dYJQ5+o9ykKJlFGJL+n8YtSrgjH1eqYdFTlyTFnAdWsUMFl/TOkbsQ1Fs CrHKfhTRfX/hyGmj+CQjqgjrluWvo6MVohA3sR35jQIi6naNhii2myQads6x94HjJoYq mr5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=BcdGMQWmTxBqo8UOEjrOkV+1KIZIMMxrmDlUfQFm9UE=; b=TVdV5V4pI0IUHpEB1qsYkeeBq/MQBSosAA/ncHsWjBsrhs7p3vEmL2F3GU9FxdzG8c y7NhhNLBaftPmeqa/o2Sig1WnZzNFTN5nyuCVcOQXCE6tSCKUnfTX6+ygdgjd8fr+0mT 8Zl/iYX2HyADF52w3iUsiWBjG3f8YEw5Vyd1HXXZt0aOjiHeRONVdcjMNpTeC/oOyBlQ CYD+JqXRtgSbk9RZTNHibWcpap3+a59kNy/skw8cu96oOm0KJYRHqOFfkKtXzlTc8JHp 90n6ClXClzHyAfEXR53Jlyh6+g8vFn9fW5MhhWZuAZSNZNVrzItQxwNIDjcqQt7jEywe 21JA==
X-Gm-Message-State: AD7BkJIwfh0/Mn0YJ1SbOJk05qfXKaEbEjC/gNqZ0gCakBJ9JPsE/B+694R+9LIeK6LWEg==
X-Received: by 10.194.113.130 with SMTP id iy2mr3454408wjb.56.1457016196087; Thu, 03 Mar 2016 06:43:16 -0800 (PST)
Received: from [192.168.2.126] (host213-123-124-182.in-addr.btopenworld.com. [213.123.124.182]) by smtp.gmail.com with ESMTPSA id g3sm41127601wjw.31.2016.03.03.06.43.14 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2016 06:43:15 -0800 (PST)
To: "Bocci, Matthew (Nokia - GB)" <matthew.bocci@nokia.com>, "draft-ryoo-mpls-tp-aps-updates@tools.ietf.org" <draft-ryoo-mpls-tp-aps-updates@tools.ietf.org>, "mpls-chairs@tools.ietf.org" <mpls-chairs@tools.ietf.org>
References: <D2F0A46F.93408%matthew.bocci@nokia.com>
From: Stewart Bryant <stewart.bryant@gmail.com>
Message-ID: <56D84D82.9080709@gmail.com>
Date: Thu, 03 Mar 2016 14:43:14 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <D2F0A46F.93408%matthew.bocci@nokia.com>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/MWCAiGXhAbvzlt1dAwEzDTn7dJE>
Cc: "mpls@ietf.org" <mpls@ietf.org>
Subject: Re: [mpls] MPLS-RT review of draft-ryoo-mpls-tp-aps-updates-02.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 14:43:19 -0000

I was also selected as an MPLS Review team reviewer.

The document is well written and should be adopted by the WG.

As part of the WG process there needs to be independent confirmation
that if put into an arbitrary state, the state machine unconditionally
migrates to the correct state, and hence that the state machine is
unconditionally correct. That way we can be sure that no further
changes will be needed to address "all problematic changes@

- Stewart

Stewart

On 22/02/2016 11:41, Bocci, Matthew (Nokia - GB) wrote:
> Authors
>
> I have been selected as an MPLS Review team reviewer for
> draft-ryoo-mpls-tp-aps-updates-02.txt.
>
> In general, I think the draft is technically sound and it is useful to
> provide clarification to sections of RFC7271 if it is the case that this
> is actually causing confusion to implementers. However, I would encourage
> the working group to think about how widely implemented and deployed
> RFC7271 is before progressing this work, since spending working group time
> on something that is not being widely implemented does not seem useful.
>
> Minor Comments/Nits
> ‹‹‹‹‹‹‹‹‹‹‹‹‹‹
> 4.1
> <https://tools.ietf.org/html/draft-ryoo-mpls-tp-aps-updates-02#section-4.1>
> .  Initialization Behavior
>
>     This section defines initialization behavior that is not described in
>     [RFC7271 <https://tools.ietf.org/html/rfc7271>].
>
> MB> It is a little unclear if this is adding a new INIT state to the state
> machine that you can transit to from one or more other states, or if this
> is just stating initial conditions before APS becomes operational. Please
> can you clarify?
>
> 4.2
> <https://tools.ietf.org/html/draft-ryoo-mpls-tp-aps-updates-02#section-4.2>
> .  State Transition Modification
>
>     In addition to the initialization behavior described in Section 4.1
> <https://tools.ietf.org/html/draft-ryoo-mpls-tp-aps-updates-02#section-4.1>
> ,
>     four cells of remote state transition table need to be changed to
>     make two end nodes converged after initialization.
>
> MB> s/four cells of remote state/ four cells of the remote state
> MB> s/two end nodes converged / two end nodes converge
>
>
>   Best regards
>
> Matthew
>
>
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls