[mpls] [Gen-art] review: draft-ietf-mpls-lsp-ping-relay-reply-04

"Joel M. Halpern" <jmh@joelhalpern.com> Wed, 08 October 2014 23:20 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 959951A86F7; Wed, 8 Oct 2014 16:20:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jlrGka4_M0zd; Wed, 8 Oct 2014 16:20:20 -0700 (PDT)
Received: from mailc2.tigertech.net (mailc2.tigertech.net [208.80.4.156]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 021861A86F6; Wed, 8 Oct 2014 16:20:20 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mailc2.tigertech.net (Postfix) with ESMTP id D6A271BC7DB9; Wed, 8 Oct 2014 16:20:19 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at c2.tigertech.net
Received: from [192.168.1.90] (107-194-85-212.lightspeed.nsvltn.sbcglobal.net [107.194.85.212]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mailc2.tigertech.net (Postfix) with ESMTPSA id DC19B1BC7DBA; Wed, 8 Oct 2014 16:20:18 -0700 (PDT)
Message-ID: <5435C6B1.2090908@joelhalpern.com>
Date: Wed, 08 Oct 2014 19:20:17 -0400
From: "Joel M. Halpern" <jmh@joelhalpern.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: "A. Jean Mahoney" <mahoney@nostrum.com>, gen-art@ietf.org, "mpls@ietf.org" <mpls@ietf.org>, Adrian Farrel <adrian@olddog.co.uk>, IETF discussion list <ietf@ietf.org>
References: <5435A89C.5040409@nostrum.com>
In-Reply-To: <5435A89C.5040409@nostrum.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: http://mailarchive.ietf.org/arch/msg/mpls/UsGX8d3LoQtcD6gcEF_mZlS7MN8
Subject: [mpls] [Gen-art] review: draft-ietf-mpls-lsp-ping-relay-reply-04
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Oct 2014 23:20:22 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments
you may receive.

Document: draft-ietf-mpls-lsp-ping-relay-reply-04
     Relayed Echo Reply mechanism for LSP Ping
Reviewer: Joel M. Halpern
Review Date: 8-October-2014
IETF LC End Date: 13-October-2014
IESG Telechat date: (if known)

Summary: This document is not ready for publication as a Proposed Standard

Major issues:
     There is either a major technical flaw in this document, or there 
is a need for significantly better explanation.  The following is what I 
was able to understand from reading the document.
     The procedure in the document calls for a responding or relaying 
LSR to search the response addresses from the top to the bottom (top 
being the originator of the request, bottom being visible originators). 
  The responder then sends the reply to the first usable address it can 
find in the stack.  Usable is variously described as "public routable" 
and as "routable" (in sections 4.2), the converse is described as 
"unroutable" in section 4.3, while section 4.4 uses "routable".
If it means "routable", then this assumes that the private addresses 
used by one AS will not happen to also be used in another AS (which 
would make them routable in that domain, directing the reply to 
completely the wrong place.
If it means "publicly routable", this would seem to fail since routers 
do not know whether routable addresses are public, private, or simply 
not martian.

Minor issues:
     The procedures assume that border routers will know the correct 
address to put in the reply stack.  It is not bovious that even if the 
router has a public address, it will get put on.  The requirement stated 
here is that the address put on be the same one used to originate the 
reply.  Which would seem likely to be na internal address in many cases.

     The procedure for setting k=0 allowing entries to be removed from 
the stack seems fragile.  It relies on routers being able to determine 
that their address will not be needed for relay by the next hop.

Nits/editorial comments:
    Some of the procedure for originating a reply is described in 
section 4.2 on Receiving a request, rather than in seciton 4.3 on 
originating the reply.  (Information such as the address to put on the 
stack, where it goes on the stack, and the handling of the reply packet 
being too large all belong in 4.3.)