[mpls] Re: AD review for draft-ietf-mpls-mna-usecases-10

Greg Mirsky <gregimirsky@gmail.com> Tue, 27 August 2024 20:18 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C548FC18DBA0; Tue, 27 Aug 2024 13:18:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l2sSeyVbdSBL; Tue, 27 Aug 2024 13:18:06 -0700 (PDT)
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EE094C18DB9A; Tue, 27 Aug 2024 13:18:00 -0700 (PDT)
Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3718acbc87fso3293291f8f.3; Tue, 27 Aug 2024 13:18:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724789879; x=1725394679; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mh9lw3GxnwxkpzyX3eaiS+gB4kLJcEw3ZUQks+FePK8=; b=h+QvZrA3f2ioFDmyfIQiVL1XPprhGvcTOfKS6xk44NZ6CS6HVjGvCfYXpbEOrcM42L K1mLRIyJip/BKGtipni8ueZa2IVgBAhMMeRtrkaKhweowQqVxuXIn5vOdwWYImQlZsD0 ypjsq6Da6zn4cMm4uRxJClXCgsHJcHeDcRYtoEfgzNDrVGron1KY8McXz9DWLr6YOKPq T9jKAlelWp/mz6HZjzch4SAhZxZu8DvX35BopyW9KzsP7mxSK9/BzmcQV5vnu4fHvMsi jRL09dEG4jlUvejfcVrU9ZTUKeTBGc9tQpnPm5dU8O4U6DKIb+3C7znA3l0dQ+6WPw4y bYvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724789879; x=1725394679; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mh9lw3GxnwxkpzyX3eaiS+gB4kLJcEw3ZUQks+FePK8=; b=uGr600MIoSQiB+dCdBgC1mgjeAmBzZ4PJReJHWMaebcToWMLZij6rHLlVCnVAbOJ8q OYH3zv7g6xhHkX+JMUTc5G7wuGTxqTCB6mCQMmDYGD+PLH4HxH8ZpBwTyU3XDSGpcmqJ aEfHnXkSazqiAyP2/RPXBKtAns5VPWeg0zz8UYV0Fz81Q+0L2PihiHgt/Xv09VQy9ney wGOOiySoDMGmaVHpEEhlMx4GJn1E2BHcamDiQj7Tz8nckrtgDbXhOvDIRWKCOxkPj+YU XA2IleVOqRO4bVJ4nwTAjcT7Q6DQmD/TH6+4C53S2+I57BGOHTcODzbms5kRl67xgK9y c7nw==
X-Forwarded-Encrypted: i=1; AJvYcCU7eMhAf58ZUz6qA3xwZTWmlIN5iE3hzm4VnEZuGbHAL4QEZesI876Xz4rOPL58aTkYhzRX@ietf.org
X-Gm-Message-State: AOJu0YxZMS2l4h5gi1HNthxEUU3qU4GM963gC0m8p3Mqc2frsbHVkac1 vyIUcIeGkkfckdrl8cptyoDp7E7mFQdw1DaZTUrk9aF5SWdpmtXHAg7RpQgRAS/HQblTmbwy50W SdpgSzeFYudceHn0bhOjzbyoZwXWFSGhV
X-Google-Smtp-Source: AGHT+IFNpyObwI0aPTG3i+CDre3puXbdiPq389MC6GAG1dpa2PyecbNiBtvVl1WSycTzTRPeu7Mxfs+cCAebyGkqzvA=
X-Received: by 2002:a05:6000:18d:b0:369:9358:4634 with SMTP id ffacd0b85a97d-373118584c2mr8136096f8f.19.1724789878637; Tue, 27 Aug 2024 13:17:58 -0700 (PDT)
MIME-Version: 1.0
References: <MW5PR13MB5485ADDA47C1BE85C40F2E1CD2942@MW5PR13MB5485.namprd13.prod.outlook.com>
In-Reply-To: <MW5PR13MB5485ADDA47C1BE85C40F2E1CD2942@MW5PR13MB5485.namprd13.prod.outlook.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Tue, 27 Aug 2024 13:17:46 -0700
Message-ID: <CA+RyBmXjHqY0D9hZs2yeYXXoh=tHOxCkSB0QBRPkp2p5=pCTnw@mail.gmail.com>
To: James Guichard <james.n.guichard@futurewei.com>
Content-Type: multipart/alternative; boundary="000000000000074dc10620aff09a"
Message-ID-Hash: 4CDKZXDTH5ML2DHWP45NZOMKEBWQ7K3F
X-Message-ID-Hash: 4CDKZXDTH5ML2DHWP45NZOMKEBWQ7K3F
X-MailFrom: gregimirsky@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-mpls.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "draft-ietf-mpls-mna-usecases@ietf.org" <draft-ietf-mpls-mna-usecases@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [mpls] Re: AD review for draft-ietf-mpls-mna-usecases-10
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/WDGM2M8OCyEL2XF3zwvl_edIJGk>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Owner: <mailto:mpls-owner@ietf.org>
List-Post: <mailto:mpls@ietf.org>
List-Subscribe: <mailto:mpls-join@ietf.org>
List-Unsubscribe: <mailto:mpls-leave@ietf.org>

Hi Jim,
many thanks for your thorough review and thoughtful suggestions. I updated
the document accordingly and uploaded the new version -11
<https://datatracker.ietf.org/doc/draft-ietf-mpls-mna-usecases/>.
Please let me know if there is anything I can do to help progress this
draft.

Kind regards,
Greg

On Tue, Aug 27, 2024 at 5:46 AM James Guichard <
james.n.guichard@futurewei.com> wrote:

> Dear Authors,
>
>
>
> Thank you for this document. Please see my comments for v-10 (line numbers
> from nits provided).
>
>
>
>   == Outdated reference: A later version (-10) exists of
>
>      draft-ietf-mpls-mna-fwk-09
>
GIM>> The new version -11 references the latest version:
   [I-D.ietf-mpls-mna-fwk]
              Andersson, L., Bryant, S., Bocci, M., and T. Li, "MPLS
              Network Actions (MNA) Framework", Work in Progress,
              Internet-Draft, draft-ietf-mpls-mna-fwk-10, 6 August 2024,
              <https://datatracker.ietf.org/doc/html/draft-ietf-mpls-
              mna-fwk-10>.

>
>
> 19      associated ancillary data within MPLS packets.  There are
> interest in
>
>
>
> Jim> s/are/is or perhaps s/are/is community interest in…
>
GIM>> The latter is even better, thank you.

>
>
> 88      This document describes cases that introduce functions that are
> based
>
>
>
> Jim> s/describes cases/describes use cases. Also, perhaps state that the
> functions require special processing by forwarding hardware rather than are
> ‘based’ e.g. s/are based on/require special
>
GIM>> I agree. Applied both updates.

>
>
> 89      on special processing by forwarding hardware.  Previously, that
>
>
>
> Jim> Instead of ‘previously’ I would state that current state-of-the-art
> requires the allocation of special-purpose labels.
>
GIM>> Updated as displayed below.

>
>
> 90      required the allocation of a new special-purpose label or extended
>
> 91      special-purpose label.  To conserve that limited resource, an MPLS
>
>
>
> Jim> Please provide a reference for special-purpose label for readers that
> are not familiar with it.
>
 GIM>> Two updates combined resulted in the following:
NEW TEXT:
   The current state
   of the art requires allocating a new special-purpose label [RFC3032]
   or extended special-purpose label.

>
>
> 92      Network Action (MNA) approach was introduced to extend the MPLS
>
>
>
> Jim> I would say that the MNA approach has been ‘proposed’ as ‘introduced’
> implies that it has already been standardized within the MPLS architecture.
>
>
GIM>> I agree with the argument. Done.

>
>
> 93      architecture.  MNA is expected to enable functions that may
> require
>
> 94      carrying additional ancillary data within the MPLS packets, as
> well
>
> 95      as means to indicate the ancillary data is present and a specific
>
>
>
> Jim> s/means/a means
>
GIM>> Done.

>
>
> 163   2.  Use Cases
>
>
>
> 165   2.1.  No Further Fastreroute
>
>
>
> Jim> s/Fastreroute/Fast Reroute
>
GIM>> Thank you, done.

>
>
> 266   2.4.  NSH-based Service Function Chaining
>
>
>
> 268     [RFC8595] describes how Service Function Chaining can be realized
> in
>
> 269     an MPLS network by emulating the Network Service Header (NSH)
> using
>
>
>
> Jim> Please add a reference to RFC 8300 for NSH.
>
GIM>> Added.

>
>
> 320     the presence of a control channel associated witha PW, LSP, or
>
>
>
> Jim> s/witha/with a
>
GIM>> Thank you for catching that.

>
>
> 340     allow for the co-existance and backward compatibility with all
> such
>
>
>
> Jim> s/co-existance/coexistence
>
GIM>> Perhaps s/co-existance/co-existence/ ? I find that hyphenation is a
valid option.

>
>
> 343   4.  Co-existence of the MNA Use Cases
>
>
>
> 345     Two or more of the aforementioned use cases may co-exist in the
> same
>
> 346     packet.  This may require the presence of multiple ancilary data
>
>
>
> Jim> s/ancilary/ancillary
>
GIM>> Done

>
>
>
>
> Thanks!
>
>
>
> Jim
>