Re: [mpls] Fw: Re: Requested review of draft-xp-mpls-spring-lsp-ping-path-sid

Carlos Pignataro <cpignata@gmail.com> Thu, 01 February 2024 14:24 UTC

Return-Path: <cpignata@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 08334C14F68B for <mpls@ietfa.amsl.com>; Thu, 1 Feb 2024 06:24:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.105
X-Spam-Level:
X-Spam-Status: No, score=-7.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bQlBYgKRXARt for <mpls@ietfa.amsl.com>; Thu, 1 Feb 2024 06:24:30 -0800 (PST)
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 62D88C14F602 for <mpls@ietf.org>; Thu, 1 Feb 2024 06:24:30 -0800 (PST)
Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a30f7c9574eso134204366b.0 for <mpls@ietf.org>; Thu, 01 Feb 2024 06:24:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706797468; x=1707402268; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JruydkG4fMcmNBvIoo2bm3tSybtJ1euFrFSu+ZmmBAs=; b=fMZNunlEgTHcCwcajdWVGLHtfSoGKQB4JQjtGBFLr4ywJybvMuwv6NoyI66L2Iyw18 0LKTeeietwj01strcoeM52n6r26XcEyeFaMvH0C3N0tqldUsJoP4Y/Tz2uDKWevnpZI1 i/ZIj35P2Q1h57W/q+8bK2jLRAJu540R51OYdrzBcU3Z5Q7VkAEIT+H4k9M7JF9A1t9s SGMCFV5Epsm6CARLpsrpsE2S8FMr6otDrT9t8H8wWR6qdkX722JwOrj8AC+oAEQ3Kw12 7WftUc4FouXh2Vpj/EuxRvj9I0R6l3osAZePTD+j4xG49QWbkDW5oFjXyQlKSHK+OGtA Ffpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706797468; x=1707402268; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JruydkG4fMcmNBvIoo2bm3tSybtJ1euFrFSu+ZmmBAs=; b=WQFZTHpw/lhv5RYUjI/s+vBGIGSWqNtlAsMLNOZxWRURzHURoponLI7xp/jlNr4QKd nMHJb4HG0mCOIGLMZ6anhmpyc6wxisJmVJ5rl30KpsbEIRo/JzPjWKxe+fpf3atXpKXb DX/DEeMkdt9no40WZKAPxKk0OXo/kALQUSP5nPgOvCGgIaAlkDXn3dNwJVolx6LAQM3l v6lEYUSv4npOdCr+PDbaPPe8FtsALMbZsvUD3fr0EGwKhHTt+IGXvgLPtOTYvxQsWnad UBxeoKT+hLhuW9WcZD8ifVevwYNesxjjCeaiR97LL+HiaoHnOe1gInDpKgQ/dOupregf Kknw==
X-Gm-Message-State: AOJu0YwQxr2iywsUmv5RlRXPiaLizm5Ab1r1Yq6TiRcawotgeh8t5Sic lxHXjeXMceDHTXCvuOTQtJbAcaBsBrY+NRL3qymqpsAAHgwvyLXQkVKx4NN5Emu1ezHipsqeI9I 7cOTBsoLuHfMfMnUpSDBY6A4P+8BttPIw
X-Google-Smtp-Source: AGHT+IEsQsZ380hmWZLFmkKz1Psmj3jk5V/9zuRYC28lq/2/kORExinyvmalSOf1htpSVXhw2sGX2GFN0IeEdSBiy7k=
X-Received: by 2002:a17:906:7fd7:b0:a35:668a:e9eb with SMTP id r23-20020a1709067fd700b00a35668ae9ebmr2026500ejs.31.1706797467997; Thu, 01 Feb 2024 06:24:27 -0800 (PST)
MIME-Version: 1.0
References: <eef8399531070f1d55965e0bde28664e.squirrel@pi.nu> <202401261637184602871@zte.com.cn>
In-Reply-To: <202401261637184602871@zte.com.cn>
From: Carlos Pignataro <cpignata@gmail.com>
Date: Thu, 01 Feb 2024 09:24:16 -0500
Message-ID: <CACe62Mk7JurcH+njsz_7RRXbWk2xdB6mmjTx2zwPDCJxkHOVEQ@mail.gmail.com>
To: Xiao Min <xiao.min2@zte.com.cn>
Cc: Loa Andersson <loa@pi.nu>, mpls@ietf.org
Content-Type: multipart/alternative; boundary="000000000000c89b04061052c0c2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/x94_AZFuTfMLMoqm94-LTHfoajg>
Subject: Re: [mpls] Fw: Re: Requested review of draft-xp-mpls-spring-lsp-ping-path-sid
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Feb 2024 14:24:35 -0000

Many thanks, Xiao and Loa! [fixed the subject line with the full I-D
filename]

For the only pending comment, on the range of sub-TLVs and respective IANA
action, I would suggest:

*OLD:*

6.
<https://datatracker.ietf.org/doc/html/draft-xp-mpls-spring-lsp-ping-path-sid-09#section-6>IANA
Considerations

IANA is requested to assign three new sub-TLVs from the "sub-TLVs for TLV
Types 1, 16, and 21" subregistry of the "Multi-Protocol Label Switching
(MPLS) Label Switched Paths (LSPs) Ping Parameters" registry.


*NEW:*

6.
<https://datatracker.ietf.org/doc/html/draft-xp-mpls-spring-lsp-ping-path-sid-09#section-6>IANA
Considerations

IANA is requested to assign three new sub-TLVs from the *Standards Action
range of the* "sub-TLVs for TLV Types 1, 16, and 21" subregistry of the
"Multi-Protocol Label Switching (MPLS) Label Switched Paths (LSPs) Ping
Parameters" registry. *[RFC 9041]*
Add Normative Reference to *[RFC 9041]*.

Thanks!

Carlos.

On Fri, Jan 26, 2024 at 3:37 AM <xiao.min2@zte.com.cn> wrote:

> Hi Loa,
>
>
> Thank you for the prompt reply.
>
> A new -09 revision has been posted, which I believe addresses all your
> comments within the groups 1&3 . Link as below.
>
>
> https://datatracker.ietf.org/doc/html/draft-xp-mpls-spring-lsp-ping-path-sid-09
>
> Please see inline.
> Original
> *From: *loa@pi.nu <loa@pi.nu>
> *To: *肖敏10093570;
> *Cc: *loa.pi.nu@gmail.com <loa.pi.nu@gmail.com>;mpls@ietf.org <
> mpls@ietf.org>;
> *Date: *2024年01月26日 14:55
> *Subject: **Re: [mpls] Fw: Re: Requested review of draft-xp-mpls*
> Xiao,
>
> Thanks for quick responses. I'm comfortable with most of it - everything
> that that I think is a done deal. Just a few comments.
>
>
>
> > 1.1 Abstract
> > ------------
>
>
> > 1.4 Section 4.
> > --------------
> >
> > In the first paragraph you say:
> >
> > "The MPLS LSP Ping procedures MAY be initiated by the headend..."
> >
> > I don't doubt that it can be started from the headend, but is the
> > requirement language really needed in this draft??
> >  [XM]>>> How about removing the first sentence? Or if you have any
> > suggested text change, I'm glad to apply.
>
> I looked at removing the first sentence, it works, but cut out a useful
> reference. I would, at least for now, use a de-capitalized may.
>
> "The MPLS LSP Ping procedures may be initiated by the headend..."
>
> Note: As per an earlier mail I have updated my comments, so it makes sense.
>
> [XM-2]>>> The text change as you suggested has been incorporated in -09
> revision.
>
>
> > 2. To be fixed before WGLC
> >
>
> > 2.2 Introduction
> > ------------
> > Do we have a good reference to Target Forwarding Equivalence Class?
> >  [XM]>>> Is https://datatracker.ietf.org/doc/html/rfc8029#section-3.2
>  that
> > you're looking for?
>
> Yes - the reference is fine. Re-checking I see what partly confused me
>
> [XM-2]>>> OK.
> >
> >
> > 2.x IANA Considerations
> >
> > The registry that you are requesting  your three new Sub-TLVs should be
> > assigned from has 8 different ranges, you need to pick one per sub-TLV
> > and indicate that as the range you want it to be assigned from.
> >  [XM]>>> OK. Will check the details later to make the registry accurate..
>
> The key is that you need to make two decisions
>
> - the Registration Procedure, I tend to think "Standards Action"
> - and what a node that does not recognize the sub-TLV will, I then
>   to think "send error message"
>
> [XM-2]>>> Thanks for the detailed suggestions. The two decisions would be
> made after this draft is adopted.
>
>
> And I would strongly suggest that you treat a 3 new sub-TLVs equally.
>
> [XM-2]>>> I fully agree.
>
>
> Cheers,
>
> Xiao Min
>
>
> /Loa
>
> >
> >
>
> >
> >
>
> >
> >
> > /Loa
> >  Thanks again for your time.
> >
> > Best Regards,
> > Xiao Min_______________________________________________
> > mpls mailing list
> > mpls@ietf.org
> > https://www.ietf.org/mailman/listinfo/mpls
> >
>
>
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls
>