Re: [Netconf] ietf-netconf-partial-lock.yang

"Romascanu, Dan (Dan)" <dromasca@avaya.com> Sun, 27 June 2010 10:15 UTC

Return-Path: <dromasca@avaya.com>
X-Original-To: netconf@core3.amsl.com
Delivered-To: netconf@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id A00053A680E for <netconf@core3.amsl.com>; Sun, 27 Jun 2010 03:15:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[AWL=0.699, BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tAwqdDUIWQ1A for <netconf@core3.amsl.com>; Sun, 27 Jun 2010 03:15:13 -0700 (PDT)
Received: from co300216-co-outbound.net.avaya.com (co300216-co-outbound.net.avaya.com [198.152.13.100]) by core3.amsl.com (Postfix) with ESMTP id D8BAE3A6853 for <netconf@ietf.org>; Sun, 27 Jun 2010 03:15:12 -0700 (PDT)
X-IronPort-AV: E=Sophos;i="4.53,491,1272859200"; d="scan'208";a="225122439"
Received: from unknown (HELO co300216-co-erhwest.avaya.com) ([198.152.7.5]) by co300216-co-outbound.net.avaya.com with ESMTP; 27 Jun 2010 06:15:22 -0400
X-IronPort-AV: E=Sophos;i="4.53,491,1272859200"; d="scan'208";a="486760289"
Received: from unknown (HELO 307622ANEX5.global.avaya.com) ([135.64.140.14]) by co300216-co-erhwest-out.avaya.com with ESMTP; 27 Jun 2010 06:15:21 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Date: Sun, 27 Jun 2010 12:15:13 +0200
Message-ID: <EDC652A26FB23C4EB6384A4584434A04022F39A9@307622ANEX5.global.avaya.com>
In-Reply-To: <4C243C9B.4070107@iwl.com>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: [Netconf] ietf-netconf-partial-lock.yang
Thread-Index: AcsUJiLv8KQ6B6PuSD2wBtk7OUQ3kABu1OwQ
References: <4C243C9B.4070107@iwl.com>
From: "Romascanu, Dan (Dan)" <dromasca@avaya.com>
To: andyb@iwl.com, Martin Bjorklund <mbj@tail-f.com>
Cc: NETCONF <netconf@ietf.org>
Subject: Re: [Netconf] ietf-netconf-partial-lock.yang
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/netconf>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jun 2010 10:15:14 -0000

This document was published as RFC 5717.

Dan
 

> -----Original Message-----
> From: netconf-bounces@ietf.org 
> [mailto:netconf-bounces@ietf.org] On Behalf Of Andy Bierman
> Sent: Friday, June 25, 2010 8:20 AM
> To: Martin Bjorklund
> Cc: NETCONF
> Subject: [Netconf] ietf-netconf-partial-lock.yang
> 
> Hi,
> 
> I am puzzled by some of the YANG usage in this module.
> For the 'lock-id', why on Earth is returning it in the 
> rpc-reply not mandatory, and in the partial-unlock, the
> 
> 
>  rpc partial-lock {
>     description
>      "A NETCONF operation that locks parts of the running datastore.";
>     input {
>       leaf-list select {
>         type string;
> ***          ^^^^^^  
> ***  I needed to change this to yang:xpath1.0 to get the XML prefixes
> ***  automatically in the stack.  Should we make an errata request
> ***  to change string to xpath1.0?
> 
>         min-elements 1;
>         description
>          "XPath expression that specifies the scope of the lock.
>           An Instance Identifier expression MUST be used unless the
>           :xpath capability is supported, in which case any XPath 1.0
>           expression is allowed.";
>       }
>     }
>     output {
>       leaf lock-id {
>         type lock-id-type;
>         description
>          "Identifies the lock, if granted.  The lock-id SHOULD be
>           used in the partial-unlock rpc.";
> 
> *** I cannot find any text that suggests returning the 
> lock-id is optional
> *** I do not understand SHOULD instead of MUST
> 
>       }
>       leaf-list locked-node {
>         type instance-identifier;
>         min-elements 1;
>         description
>          "List of locked nodes in the running datastore";
>       }
>     }
>   }
> 
>   rpc partial-unlock {
>     description
>      "A NETCONF operation that releases a previously acquired
>       partial-lock.";
>     input {
>       leaf lock-id {
>         type lock-id-type;
>         description
>          "Identifies the lock to be released.  MUST be the value
>           received in the response to a partial-lock operation.";
> 
> *** why isn't mandatory=true here?
> *** what lock is released if no parameter is provided?
> 
>       }
>     }
>   }
> }
> 
> 
> Andy
> 
> _______________________________________________
> Netconf mailing list
> Netconf@ietf.org
> https://www.ietf.org/mailman/listinfo/netconf
>