Re: [Netconf] ietf-netconf-partial-lock.yang

On 06/27/2010 03:15 AM, Romascanu, Dan (Dan) wrote:
> This document was published as RFC 5717.
>
>   

I know that.
It is full of bugs, most of which I ignored because it
is an RFC already.  Since it is an RFC the WG should
have no problem fully understanding it and explaining
what lock is released when there is no lock-id given.

One part says SHOULD provide a lock-id and another
says the lock-id MUST be correct.   If that isn't a bug
then how is it interoperable?

> Dan
>   

Andy

>  
>
>   
>> -----Original Message-----
>> From: netconf-bounces@ietf.org 
>> [mailto:netconf-bounces@ietf.org] On Behalf Of Andy Bierman
>> Sent: Friday, June 25, 2010 8:20 AM
>> To: Martin Bjorklund
>> Cc: NETCONF
>> Subject: [Netconf] ietf-netconf-partial-lock.yang
>>
>> Hi,
>>
>> I am puzzled by some of the YANG usage in this module.
>> For the 'lock-id', why on Earth is returning it in the 
>> rpc-reply not mandatory, and in the partial-unlock, the
>>
>>
>>  rpc partial-lock {
>>     description
>>      "A NETCONF operation that locks parts of the running datastore.";
>>     input {
>>       leaf-list select {
>>         type string;
>> ***          ^^^^^^  
>> ***  I needed to change this to yang:xpath1.0 to get the XML prefixes
>> ***  automatically in the stack.  Should we make an errata request
>> ***  to change string to xpath1.0?
>>
>>         min-elements 1;
>>         description
>>          "XPath expression that specifies the scope of the lock.
>>           An Instance Identifier expression MUST be used unless the
>>           :xpath capability is supported, in which case any XPath 1.0
>>           expression is allowed.";
>>       }
>>     }
>>     output {
>>       leaf lock-id {
>>         type lock-id-type;
>>         description
>>          "Identifies the lock, if granted.  The lock-id SHOULD be
>>           used in the partial-unlock rpc.";
>>
>> *** I cannot find any text that suggests returning the 
>> lock-id is optional
>> *** I do not understand SHOULD instead of MUST
>>
>>       }
>>       leaf-list locked-node {
>>         type instance-identifier;
>>         min-elements 1;
>>         description
>>          "List of locked nodes in the running datastore";
>>       }
>>     }
>>   }
>>
>>   rpc partial-unlock {
>>     description
>>      "A NETCONF operation that releases a previously acquired
>>       partial-lock.";
>>     input {
>>       leaf lock-id {
>>         type lock-id-type;
>>         description
>>          "Identifies the lock to be released.  MUST be the value
>>           received in the response to a partial-lock operation.";
>>
>> *** why isn't mandatory=true here?
>> *** what lock is released if no parameter is provided?
>>
>>       }
>>     }
>>   }
>> }
>>
>>
>> Andy
>>
>> _______________________________________________
>> Netconf mailing list
>> Netconf@ietf.org
>> https://www.ietf.org/mailman/listinfo/netconf
>>
>>     
>   