Re: [Netconf] LC on yang-push-15

[Balazs Lengyel <[e-mail]>]

Hell,

I have reviewed and support this draft if my 2 MAJOR comments are addressed.

Some comments:

P7) Generally a number of items are repeated in the draft which makes it 
longer then necessary.  Paragraph: " On-change subscriptions can be 
refined to let users subscribe only to .." could be removed.

Bullet 1.: Just before the change: how can a node know before the change 
that it will happen?

P15) Paragraphs 2 and 3 seem to contradict each other.  Para2. states "A 
publisher MUST allow ..." while Pra 3. states the same MAY be rejected.

P16) "Update records for a single subscription MAY NOT be resequenced"  
Use MUST NOT

P17)
Remove 3.11.2   It says the same as chapter 3.4
4.1  reference the RFC about the tree diagrams instead of describing 
them hereP21) Modify-subscription:  Why can't the resync and excluded 
operation be modified?

P24) Why does the resynch-subscription-error contain period-hints and 
filter-failure-hint ?

P28)  MAJOR
Figure 8 does not follow the YANG model of subscribed-notifications

General) MAJOR
When an error is returned will the identity string contain the prefix? 
According to YANG 1.1 it should however all examples omit it.

P34)
Why is resynch not allowed for configured on-change notifications?
identity datastore-not-subscribable: may indicate the datastore is not 
present at all

P35) "the response's 'error-info' may contain:" unfinished sentence

P46) anydata datastore-changes: delta includes config false nodes

regards Balazs


On 2/28/2018 11:08 PM, Kent Watsen wrote:
> WG,
>
> The authors of netconf-event-notifications have indicated privately that they believe this document is now ready for Last Call.
>
> This starts a 2.5-week Last Call on draft-ietf-netconf-yang-push-15 [1]
> The LC will end on March 17, or when active threads peter out.
>
> Please send your comments on this thread. Reviews of the document, and statement of support, are particularly helpful to the authors.  If you have concerns about the document, please state those too.
>
> Authors please indicate if you are aware of any IPR on the document.
>
>
> [1] https://tools.ietf.org/html/draft-ietf-netconf-yang-push-15
>
>
> Kent & Mahesh
>
>
>
>
> _______________________________________________
> Netconf mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/netconf
>

-- 
Balazs Lengyel                       Ericsson Hungary Ltd.
Senior Specialist
Mobile: [phone]              email: [e-mail]