Re: [netconf] New Version Notification for draft-ahuang-netconf-notif-yang-01.txt

Hi Andy and Tom, 

Thank you very much for the feedback. I will integrate these comments on the next iteration of the draft.
Here some comments I have :
- I don’t have a strong opinion on the name of the yang module prefix. If the WG prefer a shorter prefix, happy to change it. Currently, it is "inotif" standing for “Ietf Notifications”.
- Regarding the SID range request for this YANG module, I would like to ask the Netconf WG for guidelines. Should all new YANG modules defining notifications request for a SID / SID range? 

Cheers,

Alex

> On 30 Mar 2023, at 11:33, tom petch <ietfc@btconnect.com> wrote:
> 
> 
> 
> ________________________________________
> From: Andy Bierman <andy@yumaworks.com>
> Sent: 29 March 2023 17:54
> 
> 
> 
> On Wed, Mar 29, 2023 at 9:23 AM tom petch <ietfc@btconnect.com<mailto:ietfc@btconnect.com>> wrote:
> From: netconf <netconf-bounces@ietf.org<mailto:netconf-bounces@ietf.org>> on behalf of Alex Huang Feng <alex.huang-feng@insa-lyon.fr<mailto:alex.huang-feng@insa-lyon.fr>>
> Sent: 03 March 2023 16:30
> 
> Dear Netconf WG,
> 
> I published a new iteration of draft-ahuang-netconf-notif-yang.
> 
> I integrated the feedback I received from the mailing list and offline.
> 
> The following changes has been made:
> - The yang module prefix has changed to “inotif” to be more explicit.
> 
> <tp>
> mmmm explicit of what?  to me it looks like 'in'  'ot'  'if' since the human tendency is to parse into syllables.  The I-D seems to be about events more than notifications so I might have gone for 'evt' for event or some such  with perhaps a suffix if there are to be more of this ilk.
> 
> In passing, references in the YANG module MUST appear in the I-D references - 6991, 8791, 3339
> 
> Abstract or Introduction or both need a reference to the current YANG specification.
> 
> Abstract - so what? what is the point of this YANG module, what could I do with it?
> 
>      "WG Web:   <http:/tools.ietf.org/wg/netconf/<http://tools.ietf.org/wg/netconf/>>
> is out of date
> 
>        leaf eventTime {
> SMI used camel case, YANG tends not to; is there a reason to here?
> 
> 
> 
> This needs to match the XSD element name in RFC 5277.
> 
> I have an additional review comment:
> 
> There is no SID file.
> Create a SID file for this structure and create the proper sections to
> request the SID range.
> 
> <tp>
> 
> Andy 
> 
> Thanks for that.  I suspected it would be the case but did not go digging through the  (missing?) references to find out.  
> 
> Alex
> Worth adding a statement of explanation in the I-D IMHO lest others make that comment as well.
> 
> Tom Petch
> </tp>
> thanks,
> Andy
> 
> type yang:date-and-time;
>         "The time the event was generated by the event source.  This
>            parameter is of type dateTime
> Looks like 'date-and-time' to me
> 
> Tom Petch
> 
> 
> - The namespace is changed to the one used in RFC5277 : urn:ietf:params:xml:ns:netconf:notification:1.0
> - In IANA section, instead of asking for a new URI, we ask IANA to add this document as a reference to the URI from RFC5277
> 
> Any new feedback on this draft is welcome.
> 
> Cheers,
> 
> Alex
> 
> On 3 Mar 2023, at 16:43, internet-drafts@ietf.org<mailto:internet-drafts@ietf.org><mailto:internet-drafts@ietf.org<mailto:internet-drafts@ietf.org>> wrote:
> 
> 
> A new version of I-D, draft-ahuang-netconf-notif-yang-01.txt
> has been successfully submitted by Alex Huang Feng and posted to the
> IETF repository.
> 
> Name: draft-ahuang-netconf-notif-yang
> Revision: 01
> Title: YANG model for NETCONF Event Notifications
> Document date: 2023-03-03
> Group: Individual Submission
> Pages: 6
> URL:            https://www.ietf.org/archive/id/draft-ahuang-netconf-notif-yang-01.txt
> Status:         https://datatracker.ietf.org/doc/draft-ahuang-netconf-notif-yang/
> Htmlized:       https://datatracker.ietf.org/doc/html/draft-ahuang-netconf-notif-yang
> Diff:           https://author-tools.ietf.org/iddiff?url2=draft-ahuang-netconf-notif-yang-01
> 
> Abstract:
>  This document defines the YANG model for NETCONF Event Notifications.
> 
> 
> 
> 
> 
> The IETF Secretariat
> 
> 
> 
> 
> _______________________________________________
> netconf mailing list
> netconf@ietf.org<mailto:netconf@ietf.org>
> https://www.ietf.org/mailman/listinfo/netconf