Re: [netconf] Francesca Palombini's No Objection on draft-ietf-netconf-crypto-types-29: (with COMMENT)

Kent Watsen <kent+ietf@watsen.net> Fri, 02 February 2024 16:49 UTC

Return-Path: <0100018d6ab9f444-abd558f9-c5a4-4b57-a789-db2f9496308a-000000@amazonses.watsen.net>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B56C3C14F5F7; Fri, 2 Feb 2024 08:49:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.905
X-Spam-Level:
X-Spam-Status: No, score=-6.905 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=amazonses.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2E67Y21LM77z; Fri, 2 Feb 2024 08:49:49 -0800 (PST)
Received: from a48-110.smtp-out.amazonses.com (a48-110.smtp-out.amazonses.com [54.240.48.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 47D01C14E515; Fri, 2 Feb 2024 08:49:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1706892588; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:Feedback-ID; bh=cVxxdbZG8A1nZCATLPJmJon0brSpbd6MvI7bQJfGiQI=; b=PCGoHLSj+7fxMFLZHhkeNlQGFvbHJOgdvkcUXdD9jg2+afJinxAD9TPxR0n7lE8V viC51uEfk8ox/G37HwFkRPQey7i12rQrgFpjyhWWv4GmCIZfMBmDVVBoFW0l44SpFwo yYcpyVH26afvcO4QRI6QC/vLE3Qtq7nSzEkzu7fU=
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
From: Kent Watsen <kent+ietf@watsen.net>
In-Reply-To: <DB9F5E80-54BF-46B1-B52D-E972928EAFF7@tzi.org>
Date: Fri, 02 Feb 2024 16:49:48 +0000
Cc: Francesca Palombini <francesca.palombini@ericsson.com>, The IESG <iesg@ietf.org>, draft-ietf-netconf-crypto-types@ietf.org, "netconf-chairs@ietf.org" <netconf-chairs@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-ID: <0100018d6ab9f444-abd558f9-c5a4-4b57-a789-db2f9496308a-000000@email.amazonses.com>
References: <170670628452.55766.11991207802136495252@ietfa.amsl.com> <8D4289E5-C908-483A-AD82-7297C544BC57@tzi.org> <0100018d61fc9820-ef13abd1-4671-4451-a953-f732f1ddc61b-000000@email.amazonses.com> <DB9F5E80-54BF-46B1-B52D-E972928EAFF7@tzi.org>
To: Carsten Bormann <cabo@tzi.org>
X-Mailer: Apple Mail (2.3731.600.7)
Feedback-ID: 1.us-east-1.DKmIRZFhhsBhtmFMNikgwZUWVrODEw9qVcPhqJEI2DA=:AmazonSES
X-SES-Outgoing: 2024.02.02-54.240.48.110
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/YbSRwdftAQgRvF7hDM9-PZUOi6M>
Subject: Re: [netconf] Francesca Palombini's No Objection on draft-ietf-netconf-crypto-types-29: (with COMMENT)
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Feb 2024 16:49:53 -0000

Hi Carsten,

I just added "(see Section 4 in <xref target="RFC4648"/>)”

Here’s the diff:

           <t>Various examples in this document use "BASE64VALUE=" as a
             placeholder value for binary data has has been base64
-            encoded.  This placeholder value is used as real
-            base64 encoded structures are often many lines long and
-            hence distracting to the example being presented.</t>
+            encoded (see Section 4 in <xref target="RFC4648"/>).  This
+            placeholder value is used as real base64 encoded structures
+            are often many lines long and hence distracting to the example
+            being presented.</t>

Seems okay?

Kent


> On Feb 1, 2024, at 1:26 AM, Carsten Bormann <cabo@tzi.org> wrote:
> 
> Hi Kent,
> 
> I haven’t seen your changes yet.
> As long as the restatements are clearly marked as such [1], i.e., they don’t appear to make new normative requirements on their own, there is no damage.
> 
> [1]: https://www.ietf.org/archive/id/draft-bormann-restatement-00.html#name-defusing-restatements
> 
> Grüße, Carsten
> 
> 
>> On Feb 1, 2024, at 01:06, Kent Watsen <kent+ietf@watsen.net> wrote:
>> 
>> Hi Carsten,
>> 
>> Whoops, just seeing your comment after making the change.
>> I agree that it seemed not needed, but I also didn’t see any harm in adding it.
>> Thoughts?
>> 
>> Kent
>> 
>> 
>>> On Jan 31, 2024, at 8:16 AM, Carsten Bormann <cabo@tzi.org> wrote:
>>> 
>>> On 2024-01-31, at 14:04, Francesca Palombini via Datatracker <noreply@ietf.org> wrote:
>>>> 
>>>> The document is missing a reference to RFC 4648 (and specify which encoding,
>>>> Section 4 or 5). I assume that this is the same as for RFC 7950 which states:
>>>> 
>>>> Binary values are encoded with the base64 encoding scheme (see
>>>> Section 4 in [RFC4648]).
>>> 
>>> I actually would not add a restatement here.  Section 1.4 only explains the substitution of longer base64 encoded values in the examples by BASE64VALUE= (encoding for the meaningless 8 bytes “04 04 84 eb 85 40 2d 41” hex).
>>> 
>>> The document uses base64 within YANG-XML and YANG-JSON examples only, and both RFC 7950 and (uncharacteristically for JSON) RFC 7951 use Section 4 of RFC 4648.  This should not be restated — maybe this will be fixed to be base64url in a future version of RFC 7951?
>>> (RFC 9254 (YANG-CBOR) doesn’t use base64 at all for its representation of YANG “binary”, but then the crypto-types document doesn’t have YANG-CBOR examples.)
>>> 
>>> Grüße, Carsten
>>> 
>> 
>