Re: [netconf] Lars Eggert's No Objection on draft-ietf-netconf-trust-anchors-23: (with COMMENT)

Kent Watsen <kent@watsen.net> Sat, 03 February 2024 18:15 UTC

Return-Path: <0100018d702e650c-3db941c3-0f51-4d2c-a3bd-6b6f7b45438f-000000@amazonses.watsen.net>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A9011C14F71C; Sat, 3 Feb 2024 10:15:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.905
X-Spam-Level:
X-Spam-Status: No, score=-6.905 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=amazonses.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NOzdqJFdRy4T; Sat, 3 Feb 2024 10:15:08 -0800 (PST)
Received: from a8-33.smtp-out.amazonses.com (a8-33.smtp-out.amazonses.com [54.240.8.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6BE1DC14F704; Sat, 3 Feb 2024 10:15:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1706984105; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:Feedback-ID; bh=FkbYJmSG0CtrebSc7f2eSR5Py7Vi7UUjgtxihziImbo=; b=AaeL0/Tds6USRo0MkEEOWmqLJIf6sLfEw5rCTILk7YfJ+xcO6HKsG5SEtYe6xW7J Skm7VvebZRzsbvmAATMgXOzkF6Ieu8wjPKbIgyY3pEpN5jz+aQp3601HBa8IQB9yOOD ifhSXOr2bgxoPdQxgupZVAUqHs6MWaHC06Edhtlw=
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
From: Kent Watsen <kent@watsen.net>
In-Reply-To: <170678748463.27953.17595884802475550627@ietfa.amsl.com>
Date: Sat, 03 Feb 2024 18:15:05 +0000
Cc: The IESG <iesg@ietf.org>, draft-ietf-netconf-trust-anchors@ietf.org, "netconf-chairs@ietf.org" <netconf-chairs@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-ID: <0100018d702e650c-3db941c3-0f51-4d2c-a3bd-6b6f7b45438f-000000@email.amazonses.com>
References: <170678748463.27953.17595884802475550627@ietfa.amsl.com>
To: Lars Eggert <lars@eggert.org>
X-Mailer: Apple Mail (2.3731.600.7)
Feedback-ID: 1.us-east-1.DKmIRZFhhsBhtmFMNikgwZUWVrODEw9qVcPhqJEI2DA=:AmazonSES
X-SES-Outgoing: 2024.02.03-54.240.8.33
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/ZN4AWJkrtf99ST5n3sp8icDHryg>
Subject: Re: [netconf] Lars Eggert's No Objection on draft-ietf-netconf-trust-anchors-23: (with COMMENT)
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Feb 2024 18:15:12 -0000

Hi Lars,

Thank you for your valuable comments.
Please find responses below.

Kent


> On Feb 1, 2024, at 6:38 AM, Lars Eggert via Datatracker <noreply@ietf.org> wrote:
> 
> Lars Eggert has entered the following ballot position for
> draft-ietf-netconf-trust-anchors-23: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
> for more information about how to handle DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-netconf-trust-anchors/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> # GEN AD review of draft-ietf-netconf-trust-anchors-23
> 
> CC @larseggert
> 
> Thanks to Paul Kyzivat for the General Area Review Team (Gen-ART) review
> (https://mailarchive.ietf.org/arch/msg/gen-art/hI2a8vgOBaDljK3k37xmQaUMB0Y).
> 
> ## Nits
> 
> All comments below are about very minor potential issues that you may choose to
> address in some way - or ignore - as you see fit. Some were flagged by
> automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
> will likely be some false positives. There is no need to let me know what you
> did with these suggestions.
> 
> ### Grammar/style
> 
> #### Section 1.1, paragraph 5
> ```
> placeholder value for binary data has has been base64 encoded. This placeho
>                                   ^^^^^^^
> ```
> Possible typo: you repeated a word.

s/has has/that has/


> #### Section 2.1.3.4, paragraph 5
> ```
> f [I-D.ietf-netconf-crypto-types]. Thus the "cert-data" node is a CMS struct
>                                   ^^^^
> ```
> A comma may be missing after the conjunctive/linking adverb "Thus".

Replaced “Thus the” with just “The”


> #### Section 2.1.3.4, paragraph 6
> ```
> f [I-D.ietf-netconf-crypto-types]. Thus the "public-key" node can be one of
>                                   ^^^^
> ```
> A comma may be missing after the conjunctive/linking adverb "Thus".

Replaced “Thus the” with just “The”


> #### Section 2.3, paragraph 32
> ```
> any name, be used for any purpose and etc., subject to constraints imposed b
>                                   ^^^^^^^
> ```
> Write the name of the item after "and" or use only "etc".

Removed "and etc."


Thanks again,
Kent


> ## Notes
> 
> This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
> [`ietf-comments` tool][ICT] to automatically convert this review into
> individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].
> 
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
> [ICT]: https://github.com/mnot/ietf-comments
> [IRT]: https://github.com/larseggert/ietf-reviewtool
> 
> 
> 
> _______________________________________________
> netconf mailing list
> netconf@ietf.org
> https://www.ietf.org/mailman/listinfo/netconf