[Netconf] WGLC on restconf-notif-08

Qin Wu <bill.wu@huawei.com> Thu, 11 October 2018 02:24 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5CECD130E21 for <netconf@ietfa.amsl.com>; Wed, 10 Oct 2018 19:24:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.601
X-Spam-Level:
X-Spam-Status: No, score=-2.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h2iq7zYdqBGZ for <netconf@ietfa.amsl.com>; Wed, 10 Oct 2018 19:24:44 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 400EE130E37 for <netconf@ietf.org>; Wed, 10 Oct 2018 19:24:44 -0700 (PDT)
Received: from lhreml701-cah.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 2F197D528AD09 for <netconf@ietf.org>; Thu, 11 Oct 2018 03:24:40 +0100 (IST)
Received: from NKGEML411-HUB.china.huawei.com (10.98.56.70) by lhreml701-cah.china.huawei.com (10.201.108.42) with Microsoft SMTP Server (TLS) id 14.3.399.0; Thu, 11 Oct 2018 03:24:41 +0100
Received: from NKGEML513-MBX.china.huawei.com ([169.254.1.200]) by nkgeml411-hub.china.huawei.com ([10.98.56.70]) with mapi id 14.03.0399.000; Thu, 11 Oct 2018 10:24:37 +0800
From: Qin Wu <bill.wu@huawei.com>
To: "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: [Netconf] WGLC on restconf-notif-08
Thread-Index: AQHUXC8dqc/ZdIehM0Ol7lZ9+zKBhqUX3vCAgAF7cNA=
Date: Thu, 11 Oct 2018 02:24:38 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABA9B064CEB@nkgeml513-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.138.33.244]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/dP-G1O6kgTEhbMRocmBy7-zJXJM>
Subject: [Netconf] WGLC on restconf-notif-08
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Oct 2018 02:24:54 -0000

Hi,
I have read the latest version of restconf-notif-08 and have the following comments:
1. Section 3
"  Subscribing to event
   streams is accomplished in this way via a RESTCONF POST into RPCs
   defined within [I-D.draft-ietf-netconf-subscribed-notifications]
   Section 2.4.
"
hard to understand this sentence, what do we mean "via RESTCONF POST into RPCs"?
in which way?


2.section 3
I think this section explain why POST is used instead of GET for URI retieval.
Suggest the following change:

"
As described in [RFC8040] Section 6.3, a GET needs to be made against
   a specific URI on the publisher.  Subscribers cannot pre-determine
   the URI against which a subscription might exist on a publisher, as
   the URI will only exist after the "establish-subscription" RPC has
   been accepted. Therefore The POST for the "establish-subscription" RPC    replaces the
   GET request for the "location" leaf which is used in [RFC8040] to
   obtain the URI. When The subscription URI is determined and sent as
   part of the response to the "establish-subscription" RPC, and a
   subsequent GET to this URI will be done in order to start the flow of
   notification messages back to the subscriber.  A subscription does
   not move to the active state as per Section 2.4.1. of
   [I-D.draft-ietf-netconf-subscribed-notifications] until the GET is
   received.  
"
3. Section 3.2
Is there any reason not reuse streams defined in ietf-restconf-monitoring.yang in [RFC6520]?
4.Section 3.3
Why JSON encoding is emphasized? what about XML encoding?

"
   Note that "error-path" does not need to be included with the "rpc-
   error" element, as subscription errors are generally not associated
   with nodes in the datastore but with the choice of RPC input
   parameters.

"
not sure I understand this, is this difference between NETCONF and RESTCONF?
RESTCONF server doesn't support NETCONF protocol or datastore?

5.Section 3.4
"
In addition to an RPC response for a "modify-subscription" RPC
      traveling over (a), a "subscription-modified" state change
      notification must be sent within (b). 
"
Does this contradict with the statement in subscrbed notification draft
"
unlike [RFC5277], this document enables a single transport session
      to intermix notification messages and RPCs for different
      subscriptions.

"
confused.


-Qin