Re: [Netconf] WGLC on netconf-event-notifications-13

Martin Bjorklund <mbj@tail-f.com> Thu, 11 October 2018 07:25 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2CF9130E45 for <netconf@ietfa.amsl.com>; Thu, 11 Oct 2018 00:25:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FwDRzBL3gPCE for <netconf@ietfa.amsl.com>; Thu, 11 Oct 2018 00:25:40 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 4B8B1130E3A for <netconf@ietf.org>; Thu, 11 Oct 2018 00:25:40 -0700 (PDT)
Received: from localhost (unknown [173.38.220.61]) by mail.tail-f.com (Postfix) with ESMTPSA id 7B3CD1AE0310; Thu, 11 Oct 2018 09:25:39 +0200 (CEST)
Date: Thu, 11 Oct 2018 09:25:39 +0200
Message-Id: <20181011.092539.1869235859078328014.mbj@tail-f.com>
To: evoit@cisco.com
Cc: netconf@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <c8115971cd7c42909dba9946ef56ebcf@XCH-RTP-013.cisco.com>
References: <C25DFAF6-04FC-44B4-B714-D6CE4E4EFF8C@juniper.net> <20181010.111455.977252154629241283.mbj@tail-f.com> <c8115971cd7c42909dba9946ef56ebcf@XCH-RTP-013.cisco.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/n8ovCj9GghUhIuOj_7ja8x0t2SM>
Subject: Re: [Netconf] WGLC on netconf-event-notifications-13
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Oct 2018 07:25:42 -0000

Hi,

Thanks for fixing these issues.  Two comments, trimming:


"Eric Voit (evoit)" <evoit@cisco.com> wrote:
> Thanks very much Martin.   Changes made as described in-line.
> 
> > From: Martin Bjorklund, October 10, 2018 5:15 AM

[...]

> > But this illustrates a problem with SN; the "transport" leaf is
> > mandatory if the feature "configured" is supported.  The problem
> > is that just b/c a server supports the "configured" feature, it
> > doesn't mean that there is an identity defined for all transports;
> > e.g., there is no identity defined for NETCONF.  So the leaf
> > "transport" should probably not be mandatory.
> 
> Made optional within the SN grouping "subscription-policy", and
> tweaked the definition as follows:
> 
>     leaf transport {
>       if-feature "configured";
>       type transport;
>       description
>         "For a configured subscription, this leaf specifies the 
>         transport used to deliver messages destined to all receivers 
>         of that subscription.";
>     }

Is the intention that this leaf is not present in the operational
state for dynamic subscriptions?  If so, I think this should be
explicitly stated.

[...]

> > o  Spelling of XPath
> > 
> >   s/xpath filter/XPath filter/  (a couple of places)
> 
> Found one.  Fixed.

In A.2.2:

   seen, the modifications being attempted are the application of a new
   xpath filter as well as the setting of a new periodic time interval.

In A.4:

   For more examples of xpath filters, see [XPATH].



/martin