Re: [netconf] Shepherd Review on draft-ietf-netconf-https-notif-10

Mahesh Jethanandani <mjethanandani@gmail.com> Tue, 23 August 2022 20:02 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F22F6C1524BE; Tue, 23 Aug 2022 13:02:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qQKTe7pgdzLf; Tue, 23 Aug 2022 13:02:56 -0700 (PDT)
Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 28B30C1524B6; Tue, 23 Aug 2022 13:02:56 -0700 (PDT)
Received: by mail-pl1-x633.google.com with SMTP id x19so13762779plc.5; Tue, 23 Aug 2022 13:02:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc; bh=aSgOcjSGLt5gxq/LGncNd66jxlG85e+5p34OLa7xxB8=; b=bBirDkck4CbF8tGnIRuuoi8QLQWk7qZZ11AkyowLH8GCueEG7Jbwwr2hYWICqN7w+3 UDmvGT0noNWOGI35PwT+Mj54SG73q8QBuTJy30Bugmp85v1HtVlzJcKhTas9rX3snLC+ kS2wHB/bgclHzuqVarBvoQWnDwFlGlFUNhGrzvdtjusGh1VfLTSBk+cnSYnhxVmMwpAo LhzKZquff4wx5I+ruHN3ZezXCnAx3BjERfsNDk4h+jZL9z+Rj2JKnHxAsFTi7JVMpoEb Qso9uzRqk7QLRjA2iHHYV7EyezPvqx0OZWDbq1ZlpJthfw69ylZ/AWx0Ja2khlHTKTRf nlLQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc; bh=aSgOcjSGLt5gxq/LGncNd66jxlG85e+5p34OLa7xxB8=; b=5GdLvljjxVkk3gSfQspBZGjtSxVz6oUh/X05xXVIe0NipKIqVGNx8ME7a1wG4tZKHv 3LG6RflFCHi50w2iDjHmHPf4MDWvSQOZ5Sf2NRpd9javs3nF5o4+khL8e0JBGwfmPUN2 Iy1r1q4FZgJAQJmwhMM8dzhR2jQZQCkVV3fjYsgIXGE0iJ7DR6igIBvrrQxtWIl0PDK/ qrlYlcA7reswkLAr7nORxOeVk/5Mrbd+R/Q1x9g/czhFtBkW9houKzIqTM7o1VoxHpjv +Z8MpaxMbl8XEdD8ZWQQy9ZuBHaNyHexNSrVVSQ+byb1Z7EjVCFam42c7TqvxydNz6cR qh1Q==
X-Gm-Message-State: ACgBeo3e4GRjiP3VSnUNjh9ORNa+k01KgoG+aWho9ccgVDFWqAR2Ar6/ EqqZZDm6D69vtBSUUu2uVO+Y8TA8Kqc=
X-Google-Smtp-Source: AA6agR4oltM2HSKtesBoBBeL+9cLI1brgJ2mduhUtyZtvSktBvwXvibcytU16t/VBLiIp9IhzMrLCQ==
X-Received: by 2002:a17:902:f606:b0:172:9c81:d788 with SMTP id n6-20020a170902f60600b001729c81d788mr25345289plg.42.1661284975424; Tue, 23 Aug 2022 13:02:55 -0700 (PDT)
Received: from smtpclient.apple ([70.234.233.187]) by smtp.gmail.com with ESMTPSA id o12-20020a170902d4cc00b00172b87d97cbsm10499325plg.67.2022.08.23.13.02.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Aug 2022 13:02:54 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <32E15026-FBCA-4404-BEDD-BA64A938E388@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_76D9F144-8401-46B3-AB8C-4634A3EA3DF2"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Date: Tue, 23 Aug 2022 13:02:53 -0700
In-Reply-To: <6973ce697741485a83be4403c48b018f@huawei.com>
Cc: "draft-ietf-netconf-https-notif@ietf.org" <draft-ietf-netconf-https-notif@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>, Robert Wilton <rwilton@cisco.com>
To: "maqiufang (A)" <maqiufang1@huawei.com>
References: <1f22e4eaedd64670a64b55a198df7d28@huawei.com> <A1BAC90C-8FBE-4095-A640-808C43BE9F40@gmail.com> <6f074fa3ae81445e89f68122a609519f@huawei.com> <CE11142F-7619-4D85-AD2E-9C9FA124BC92@gmail.com> <c4b9ea2482a347a895304b8402ba725a@huawei.com> <FFCFC541-67CA-47D2-A9B6-37E575CC9F36@gmail.com> <6973ce697741485a83be4403c48b018f@huawei.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/gPIqNP9QfkjUyfw9_7_RuJYVFsM>
Subject: Re: [netconf] Shepherd Review on draft-ietf-netconf-https-notif-10
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Aug 2022 20:02:57 -0000

Hi Quifang,

First of all, and just to be clear, there was no change in the model. The change you are seeing is because of an update in the tool chain, especially pyang, which was updated to revision 2.5.3 and is being used to generate the tree diagram.

As you have already observed, the model is trying to use the “http-client-stack-grouping” from draft-ietf-netconf-http-client-server draft, but wants to disable support for http transport. A https based transport is the minimum requirement for the draft to muster passage through any security scrutiny. That is why you see the logical impossibility of including http in the model. It would therefore make sense that the tree diagram for the model also reflect that logical impossibility. Otherwise, it would not be a true reflection of the model.

Thanks.

> On Aug 23, 2022, at 5:41 AM, maqiufang (A) <maqiufang1@huawei.com> wrote:
> 
> Hi, Mahesh
> Thanks for posting another version to address my comments ;-)
>  
> Besides the fixed nits, the diff(https://www.ietf.org/rfcdiff?url2=draft-ietf-netconf-https-notif-12 <https://www.ietf.org/rfcdiff?url2=draft-ietf-netconf-https-notif-12>) also shows that you have removed the whole “tcp” case inside the “transport” choice from the tree diagram(change at page 12). Is this intentional? I do understand that you are creating a logic impossibility here to disable a tcp transport configuration, but I am unsure if this should be removed from the tree diagram totally. if we use pyang to generate the tree, pyang will output it honestly with the list of features that can never be met at the same time.
>  
> Best Regards,
> Qiufang
>  
> From: Mahesh Jethanandani [mailto:mjethanandani@gmail.com] 
> Sent: Tuesday, August 23, 2022 7:33 AM
> To: maqiufang (A) <maqiufang1@huawei.com>
> Cc: draft-ietf-netconf-https-notif@ietf.org; netconf@ietf.org; Robert Wilton <rwilton@cisco.com>
> Subject: Re: [netconf] Shepherd Review on draft-ietf-netconf-https-notif-10
>  
> Hi Qiufang,
>  
> Thanks for reviewing the document carefully. Since the last post was a manual post, there was some confusion about which version of the file need to be posted. The recent post of -12 version of the draft should address the remaining comments you had.
>  
> Thanks.
> 
> 
> On Jul 21, 2022, at 7:03 PM, maqiufang (A) <maqiufang1@huawei.com <mailto:maqiufang1@huawei.com>> wrote:
>  
> Hi, Mahesh
> I see that v-11 has already been posted. I’ve reviewed the diff, and thanks for addressing my comments!
> But I found that the latest version still has a few nits:
> ·         Sec. 1. Introduction
> ·         s/ notfications/notifications/
> ·         Sec. 1.3 Abbreviations
> ·         s/Hyper Text Transport Protocol Secure/Hypertext Transfer Protocol Secure/
> ·         Sec. 5.2  YANG Module
> ·         s/augemnts/augments/
> ·         PYANG reminds me that The IETF Trust Copyright statement is still not correct:
>       "Copyright (c) 2022 IETF Trust and the persons identified as
>         the document authors.", which should be:
>        "Copyright (c) 2022 IETF Trust and the persons identified as
>         authors of the code."
>    The same case for Sec. 6.2 YANG module
> ·         Sec. 6.2 YANG Module
> ·         s/MUST NOT not/MUST NOT/
> ·         Sec.7 Security Considerations
> ·         The first paragraph: s/defines/define/
> ·         The second paragraph: s/makes/make/; s/are/is/
> ·         Sec. 8.3 The "Capabilities for HTTPS Notification Receivers" Registry
> ·         s/ urn:ietf:capability:https-notif-receiver:encoding:sub-notif/urn:ietf:capability:https-notif-receiver:sub-notif/
>               (remove "encoding")
> ·         Appendix A.2
> ·         s/nofif/notif/
>  
> Best Regards,
> Qiufang
> From: Mahesh Jethanandani [mailto:mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>] 
> Sent: Tuesday, July 12, 2022 4:01 AM
> To: maqiufang (A) <maqiufang1@huawei.com <mailto:maqiufang1@huawei.com>>
> Cc: draft-ietf-netconf-https-notif@ietf.org <mailto:draft-ietf-netconf-https-notif@ietf.org>; netconf@ietf.org <mailto:netconf@ietf.org>; Robert Wilton <rwilton@cisco.com <mailto:rwilton@cisco.com>>
> Subject: Re: [netconf] Shepherd Review on draft-ietf-netconf-https-notif-10
>  
> [Pruning the list down to open issues]
> 
> 
> 
> On Jun 28, 2022, at 8:30 PM, maqiufang (A) <maqiufang1@huawei.com <mailto:maqiufang1@huawei.com>> wrote:
>  
>  
> ·         Section 2 Overview of Publisher to Receiver Interaction
> ·         Would it be beneficial to state clearly in this section that the receiver which is a NETCONF or RESTCONF client, though, works as an HTTPS server to present HTTP target resources?
>  
> [mj] We do not require the receiver to be a RESTCONF client, as you observed above. The only requirement is that the receiver be an HTTPS server. Being a HTTP based protocol, it cannot be a NETCONF server or client.
> So my only question is, would it be good to state clearly that the receiver is required to be an HTTPS server in Sec.2? Just a suggestion, feel free to accept or reject it.
>  
> [mj] In the Abstract we state that this document is defining the protocol for HTTPS, and explicitly not NC or RC. We will elaborate on the Abstract in the Introduction.
>  
> Thanks.
>  
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
>  
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>

Mahesh Jethanandani
mjethanandani@gmail.com