Re: [netext] AD review of draft-ietf-netext-radius-pmip6

jouni korhonen <jouni.nospam@gmail.com> Tue, 13 December 2011 13:04 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: netext@ietfa.amsl.com
Delivered-To: netext@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7571721F8490 for <netext@ietfa.amsl.com>; Tue, 13 Dec 2011 05:04:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.599
X-Spam-Level:
X-Spam-Status: No, score=-3.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s1gIey0SmK3e for <netext@ietfa.amsl.com>; Tue, 13 Dec 2011 05:04:08 -0800 (PST)
Received: from mail-lpp01m010-f44.google.com (mail-lpp01m010-f44.google.com [209.85.215.44]) by ietfa.amsl.com (Postfix) with ESMTP id 1660521F8483 for <netext@ietf.org>; Tue, 13 Dec 2011 05:04:07 -0800 (PST)
Received: by laah2 with SMTP id h2so1820690laa.31 for <netext@ietf.org>; Tue, 13 Dec 2011 05:04:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=uW9tW7ZgPH5dtFv2ttrPP0FGzEiOAwBWup1r58qgqK0=; b=Ins+JZ1/RmGv4Rarvb3+eSH+aqRzpLIPXoJWfSkRqxTKiD3VDpEVisz+52Wj8LXR1+ BiHWpn/QkOC9LKaiAvZ5nZqg9eyz1rqWF4BcyV1q/4pR6/+co5BHafATuEdJvNalJYYn sKGz8tzNqW8e1ojSY2I+0IVstF+tGVxT9oldY=
Received: by 10.152.109.5 with SMTP id ho5mr10838652lab.51.1323781447026; Tue, 13 Dec 2011 05:04:07 -0800 (PST)
Received: from a88-112-207-66.elisa-laajakaista.fi (a88-112-207-66.elisa-laajakaista.fi. [88.112.207.66]) by mx.google.com with ESMTPS id lr3sm957659lab.17.2011.12.13.05.04.05 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 13 Dec 2011 05:04:05 -0800 (PST)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset="us-ascii"
From: jouni korhonen <jouni.nospam@gmail.com>
In-Reply-To: <4EE5324E.3010803@piuha.net>
Date: Tue, 13 Dec 2011 15:04:03 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <436DC79F-5BF8-474A-BCEF-9D8A50B0DCC4@gmail.com>
References: <4EE5324E.3010803@piuha.net>
To: Jari Arkko <jari.arkko@piuha.net>
X-Mailer: Apple Mail (2.1084)
Cc: draft-ietf-netext-radius-pmip6@tools.ietf.org, "netext@ietf.org" <netext@ietf.org>
Subject: Re: [netext] AD review of draft-ietf-netext-radius-pmip6
X-BeenThere: netext@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Mailing list for discusion of extensions to network mobility protocol, i.e PMIP6. " <netext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netext>, <mailto:netext-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/netext>
List-Post: <mailto:netext@ietf.org>
List-Help: <mailto:netext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netext>, <mailto:netext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Dec 2011 13:04:09 -0000

Jari,

Thanks for the detailed review. See my comments online. 

On Dec 12, 2011, at 12:44 AM, Jari Arkko wrote:

> I have reviewed this specification.
> 
> The draft is well written. Thanks for that. I only found a couple of minor editorial issues, and one technical issue. I would like to talk about the technical issue before we send the draft forward. Please reply to this e-mail and/or revise the draft accordingly so that I can start an IETF Last Call.
> 
> Section 4.9: Shouldn't this section include some text about not including this attribute, if MIP6-Home-HN-Prefix is already present? (Like Section 4.7 had for its corresponding attribute pair.) The same problem may appear in Section 4.13 and elsewhere as well. Please check.

If I recall our (authors) discussion correctly the motivation not to add any restriction in these cases was to allow a (possible future) deployment where the MAG receives both home & visited LMA addresses and then picks based on some policy either one. For this to work, we would need address allocation also have the same functionality. No problem to add "SHOULD NOT"s there and explain the situation.

> Section 4.10 & 4.11: This is the technical issue that worries me. While RFC 5213 does say that there are cases where MN-HoA is known, this is certainly an exception rather than the rule:
> 
>   Mobile Node's Home Address (MN-HoA)
> 
>      MN-HoA is an address from a mobile node's home network prefix.
>      The mobile node will be able to use this address as long as it is
>      attached to the access network that is in the scope of that Proxy
>      Mobile IPv6 domain.  If the mobile node uses more than one address
>      from its home network prefix(es), any one of these addresses is
>      referred to as mobile node's home address.  Unlike in Mobile IPv6
>      where the home agent is aware of the home address of the mobile
>      node, in Proxy Mobile IPv6, the mobility entities are only aware
>      of the mobile node's home network prefix(es) and are not always
>      aware of the exact address(es) that the mobile node configured on
>      its interface from its home network prefix(es).  However, in some
>      configurations and based on the enabled address configuration
>      modes on the access link, the mobility entities in the network can
>      be certain about the exact address(es) configured by the mobile
>      node.
> 
> Sections 4.10 and 4.11 talk about IIDs without any context on how they should be derived, used, and whether they can even exist on a given deployment.
> 
> One approach to fix this would be to delete the subsections. Another one would be explain how the IID values are determined, when they can be determined, and how they should be used. Yet another approach is to point me (and the reader) to another RFC that describes this (as I could of course have missed something).

Right, good point. I would remove the "derivation text" and add applicability statement for links where the network actually delivers the IID to the end host (PPP, 3GPP, ...) these attributes contain the IID.

> 
>> 4.18.  Calling-Station-Id
>> 
>>   The Calling-Station-Id attribute (Type value 31) is of type String
>>   and when used for PMIPv6 it contains the link-layer identifier of the
>>   MN as defined in [RFC5213], Sections 2.2 and 8.6.
> 
> You should refer to the RFC that originally defined Calling-Station-Id.

Ack.

> 
>>   The User-Name attribute MUST be present in the Access-Request.  It
>>   SHOULD carry a valid MN identity unless the identity is being
>>   suppressed for policy reasons, for example, when identity hiding is
>>   in effect.  The MN identity, if available, MUST be in Network Access
>>   Identifier (NAI) [RFC4282] format.
> 
> I think there is always an identifier that is of the valid form. It just may not reveal the identity of the user (at least not in an 1-1 and stable fashion). Consider making this change:
> 
> ... MUST carry a correctly formed identifier that SHOULD correspond to a MN identity unless ...

Ok. Will change.

Thanks,
	Jouni

> 
> Jari
>