Re: [netmod] Few Comments //RE: Publication has been requested for draft-ietf-netmod-module-tags-04

[Christian Hopps <[e-mail]>]

> On Feb 13, 2019, at 6:04 AM, Rohit R Ranade <[e-mail]> wrote:
> 
> Editorial Comments:
> 1.  Section 1, refers to RFC6020 for Yang Module, but since this document uses Yang Version 1.1, I feel it should refer to RFC7950
> 2.  Section 4.3, " removed with using normal configuration", can use "removed by using normal configuration"

Done

> 3.  Description of statement "leaf-list tag", in the Step 1), " System added tags are added" can be replaced with "tags of 'system' origin are added" as it associates System with "system" origin in a better way.

Adopted with modification. Trying to keep things more readable but still well specified.

           1) System tags (i.e., tags of 'system' origin) are added.
           2) User configured tags (i.e., tags of 'intended' origin)
           are added.
           3) Any tag that is equal to a masked-tag is removed.";

> 4.  Description of statement "leaf-list tag", " The operational view of this list", can be replaced with "The applied configuration of this list", as it uses is a well-known term from RFC 8342.

NEW:
           The 'operational' state [RFC8342] view of this list is
           constructed using the following steps:


> 5.  Description of statement "leaf-list tag", " User configured tags" can be replaced with "tags of 'intended' origin" as it uses a well-known NMDA term from RFC8342

Adopted with mod, See above.

> Technical:
> 1. Section 4.2, "These tags may be standard or vendor specific tags".  Does this statement exclude other tags from being added by implementations ? If it does not exclude, I feel this statement can be removed.

Going to leave this, standard tags and vendor tags are tags with a specific prefix.

> 2. In the description of Yang statement "leaf-list tag", is there any reason why System tags should be added first and then User configured tags ? Not clear.

This is just the way it worked out on the mailing list. Doesn't hurt to specify an order.

> 3. Description of statement "leaf-list masked-tag", " This user can remove (mask) tags", I think we need to clarify that it will not "apply" the tags which have been configured as "masked-tags", because they are not "removed" from any configuration datastore.
> The tags which have been masked will be present in <intended>, but will not be present in <operational>.
> Suggested description
> " The list of tags that will not be applied to this
> module. By adding tags to this list, the user can prevent
> such tags from being applied. It is not an error to add
> tags to this list that are not associated with the module."

I'm not sure about making these changes. I think the current text (with the modification below) is pretty clear in what is meant, and delving so deeply into NMDA gets distracting, and could in fact end up being wrong (e.g., I think of tags being associated with a module not applied to them).

 I did make the change to the enumerated list to show what is meant by "System" and "User", and in the spirit of your suggestion, I did change it to be more specific about operational state datastore.

          "The list of tags that should not be associated with this
           module. The user can remove (mask) tags from the
           operational state datastore [RFC8342] by adding them to
           this list. It is not an error to add tags to this list
           that are not associated with the module, but they have no
           operational effect.";

Thanks for the review!

Chris.


> 
> 
> With Regards,
> Rohit R
> 
> 
> -----Original Message-----
> From: netmod [mailto:[e-mail]] On Behalf Of Joel Jaeggli
> Sent: 13 February 2019 05:20
> To: [e-mail]
> Cc: [e-mail]; Joel Jaeggli <[e-mail]>; [e-mail]; [e-mail]
> Subject: [netmod] Publication has been requested for draft-ietf-netmod-module-tags-04
> 
> Joel Jaeggli has requested publication of draft-ietf-netmod-module-tags-04 as Proposed Standard on behalf of the NETMOD working group.
> 
> Please verify the document's state at https://datatracker.ietf.org/doc/draft-ietf-netmod-module-tags/
> 
> _______________________________________________
> netmod mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/netmod
> 
> _______________________________________________
> netmod mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/netmod
>