Re: [netmod] [Anima] mcr's YANG question raised during the ANIMA WG session

Michael Richardson <mcr+ietf@sandelman.ca> Sun, 13 November 2022 10:07 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15517C14CE4A; Sun, 13 Nov 2022 02:07:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id njSEMt4puFHN; Sun, 13 Nov 2022 02:07:50 -0800 (PST)
Received: from relay.sandelman.ca (relay.cooperix.net [IPv6:2a01:7e00:e000:2bb::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71023C14CF1A; Sun, 13 Nov 2022 02:07:50 -0800 (PST)
Received: from dyas.sandelman.ca (ip-185-104-137-32.ptr.icomera.net [185.104.137.32]) by relay.sandelman.ca (Postfix) with ESMTPS id E973B1F44D; Sun, 13 Nov 2022 10:07:47 +0000 (UTC)
Received: by dyas.sandelman.ca (Postfix, from userid 1000) id A427BA0B01; Sun, 13 Nov 2022 10:07:45 +0000 (GMT)
Received: from dyas (localhost [127.0.0.1]) by dyas.sandelman.ca (Postfix) with ESMTP id A0FE7A0AF0; Sun, 13 Nov 2022 11:07:45 +0100 (CET)
From: Michael Richardson <mcr+ietf@sandelman.ca>
To: Jan Lindblad <janl@tail-f.com>, "Anima@ietf.org" <anima@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
In-reply-to: <D335747C-1416-4E02-B430-239F860AC476@tail-f.com>
References: <DU0PR10MB5196F26C92DD2F266A4FAC28F3949@DU0PR10MB5196.EURPRD10.PROD.OUTLOOK.COM> <365823.1658933390@dooku> <DU0PR10MB5196ADB3702B7417B0589555F3979@DU0PR10MB5196.EURPRD10.PROD.OUTLOOK.COM> <446675.1659033968@dooku> <DU0PR10MB51966008D0EA49AC6FCD3FB9F3999@DU0PR10MB5196.EURPRD10.PROD.OUTLOOK.COM> <539974.1659103385@dooku> <YuhrI/iINFJxPOC7@faui48e.informatik.uni-erlangen.de> <32336.1659550668@localhost> <58217DD1-D5C2-4C99-BDF9-5BA5B252AE56@tail-f.com> <21550.1659654070@localhost> <D335747C-1416-4E02-B430-239F860AC476@tail-f.com>
Comments: In-reply-to Jan Lindblad <janl@tail-f.com> message dated "Fri, 05 Aug 2022 10:41:10 +0200."
X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 26.3
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha512"; protocol="application/pgp-signature"
Date: Sun, 13 Nov 2022 11:07:45 +0100
Message-ID: <770863.1668334065@dyas>
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/OlgizOuui8l9vFofSRztyuSWSDI>
Subject: Re: [netmod] [Anima] mcr's YANG question raised during the ANIMA WG session
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Nov 2022 10:07:53 -0000

To follow up finally.

To recap: we have been doing A:grouping-A, B:grouping-B-augment-group-A, and now are facing
C:grouping-C-augment-group-B, which seems to be wrong.

We start with RFC8366's YANG for voucher.
It is augmented in RFC8995 to create voucher-request.
What I am hearing is that we did it wrong in RFC8995.

  grouping voucher-request-grouping {
    description
      "Grouping to allow reuse/extensions in future work.";

    uses vch:voucher-artifact-grouping {
      refine "voucher/created-on" {
      ...
      }

      augment "voucher"  {
        description
          "Adds leaf nodes appropriate for requesting vouchers.";
        leaf prior-signed-voucher-request {...};
      }
  }

What I think you are saying is that we should have done:

  grouping voucher-request-grouping {
    description
      "Grouping to allow reuse/extensions in future work.";
    augment "voucher"  {
      description
        "Adds leaf nodes appropriate for requesting vouchers.";
      leaf prior-signed-voucher-request {..}
  }

  uses vch:voucher-artifact-grouping;
  uses voucher-request-grouping;

Then other uses could just add the the groupings that they need.

I'm trying this now.

--
Michael Richardson <mcr+IETF@sandelman.ca>, Sandelman Software Works
 -= IPv6 IoT consulting =-