Re: [netmod] AD review of draft-ietf-netmod-interfaces-cfg-09

[Martin Bjorklund <[e-mail]>]

Juergen Schoenwaelder <[e-mail]> wrote:
> On Wed, Apr 17, 2013 at 04:52:30PM +0200, Benoit Claise wrote:
> > >
> > What would be required is a new appendix with how the config at
> > http://www.youtube.com/watch?v=KdQlwm6bIpM might be defined.
> > Alternatively, the appendix C could be improved.
> > Specifically, the combination of type and location must be clearly
> > labeled (or explained) for the primary interface and subinterfaces.

[...]

> Perhaps all that is needed is to add another vlan example interface to
> the config snipped shown in Appendix D.

I think this makes sense.  I suggest we change the example in app. D
to:

<rpc-reply
    xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"
    message-id="101">
  <data>
    <interfaces
        xmlns="urn:ietf:params:xml:ns:yang:ietf-interfaces"
        xmlns:vlan="http://example.com/vlan">
      <interface>
        <name>eth0</name>
        <type>ethernetCsmacd</type>
        <location>0</location>
        <enabled>true</enabled>
        <if-index>2</if-index>
      </interface>
      <interface>
        <name>eth1</name>
        <type>ethernetCsmacd</type>
        <location>1</location>
        <enabled>true</enabled>
        <if-index>7</if-index>
        <vlan:vlan-tagging>true</vlan:vlan-tagging>
      </interface>
      <interface>
        <name>eth1.10</name>
        <type>l2vlan</type>
        <enabled>true</enabled>
        <if-index>9</if-index>
        <vlan:base-interface>eth1</vlan:base-interface>
        <vlan:vlan-id>10</vlan:vlan-id>
      </interface>
    </interfaces>
  </data>
</rpc-reply>

While doing this, I found and fixed a bug in a must expression in
Appendix C - quotes were missing around the literal 'true'.


Benoit, is this what you had in mind?



/martin