Re: [netmod] Roman Danyliw's Discuss on draft-ietf-netmod-factory-default-14: (with DISCUSS and COMMENT)

Kent Watsen <kent+ietf@watsen.net> Tue, 21 April 2020 15:56 UTC

Return-Path: <010001719d742c56-71daa55d-c510-4ab5-937d-fbb2d78017aa-000000@amazonses.watsen.net>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCB653A0AA6; Tue, 21 Apr 2020 08:56:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=amazonses.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jn-Rvt5ChA0f; Tue, 21 Apr 2020 08:56:18 -0700 (PDT)
Received: from a8-96.smtp-out.amazonses.com (a8-96.smtp-out.amazonses.com [54.240.8.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ACA673A0CA7; Tue, 21 Apr 2020 08:56:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1587484569; h=From:Message-Id:Content-Type:Mime-Version:Subject:Date:In-Reply-To:Cc:To:References:Feedback-ID; bh=FQ3F4Ma1xLSIJLCo/cXTN8WgLArZeEz+O9wm83w0c5Q=; b=NGZ4zPFzlV2hu/WVbVo4/uJT64kaS6KsSKKov6tmr0qj2RRqNHHPjRxq706E715B uaZvDwgMoyAwh9QnGBSxdabS1vJckHgH4Rpv2MuO7pLZfKQ0kybEDwrlwsERQ69uUEC M7SHgxXU4XgD7GDkVfyuO/T8Ruo/gM2wlTixQ+sY=
From: Kent Watsen <kent+ietf@watsen.net>
Message-ID: <010001719d742c56-71daa55d-c510-4ab5-937d-fbb2d78017aa-000000@email.amazonses.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_2EE12284-AEA8-4DC0-B774-909E9F1FC371"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Tue, 21 Apr 2020 15:56:09 +0000
In-Reply-To: <B8F9A780D330094D99AF023C5877DABAAD620C2A@dggeml511-mbx.china.huawei.com>
Cc: Roman Danyliw <rdd@cert.org>, The IESG <iesg@ietf.org>, "draft-ietf-netmod-factory-default@ietf.org" <draft-ietf-netmod-factory-default@ietf.org>, "netmod-chairs@ietf.org" <netmod-chairs@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
To: Qin Wu <bill.wu@huawei.com>
References: <B8F9A780D330094D99AF023C5877DABAAD620C2A@dggeml511-mbx.china.huawei.com>
X-Mailer: Apple Mail (2.3445.104.11)
X-SES-Outgoing: 2020.04.21-54.240.8.96
Feedback-ID: 1.us-east-1.DKmIRZFhhsBhtmFMNikgwZUWVrODEw9qVcPhqJEI2DA=:AmazonSES
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/wVKnGtgUY825xjlX2HXllVm8Wcg>
Subject: Re: [netmod] Roman Danyliw's Discuss on draft-ietf-netmod-factory-default-14: (with DISCUSS and COMMENT)
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2020 15:56:22 -0000

Hi Roman,

> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
> 
> Please use YANG security considerations template from https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines.  Specifically (as a DISCUSS item):
> 
> ** (Per the template questions “for all YANG modules you must evaluate whether any readable data”) Would factory-default contain any sensitive information in certain network environments where the ACLs should be more restrictive that world readable for everyone?
> [Qin]: It does follows yang-security-guidelines but there is no readable data node defined within rpc, that's why we don't use third paragraph boilerplate and fourth paragraph boilerplate of yang-security-guidelines. YANG-security-guidelines are more applicable to YANG data model with more readable/writable data nodes.
> In addition, as clarified in the second paragraph, section 6 of this draft, NACM can be used to restrict access for particular NETCONF or RESTCONF users to a preconfigured subset of all available NETCONF or RESTCONF protocol operations (i.e., factory-reset rpc)
> 
> Per “The operational disruption caused by setting the config to factory default contents varies greatly depending on the implementation and current config”, it seems like it could be worse than just an operational disruption.  Please note that a default configuration could be insecure or not have security controls enabled whereby exposing the network to compromise.
> 
> [Qin]: As described in the second paragraph of section 6 it by default restrict access for everyone by using the "default-deny-all" access control defined [RFC8341], what else does it need to address this security concern?
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Please use YANG security considerations template from https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines <https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines>.  Specifically (as a COMMENT item):
> 
> ** Add “The Network Configuration Access Control Model (NACM) [RFC8341] provides the means to …”
> 
> [Qin]: We did follow this template, I am wondering how it is different from the second paragraph of section 6? I see they are equivalent but with more fine granularity security measures, if my understanding is correct.


Regarding the use of the YANG security considerations template from [1], it has been noted that the template is imperfect in several ways…

For instance, a YANG module  may not define any protocol accessible nodes (e.g., they only define identities, typedefs, yang-data, or structures).  In another example, the YANG module may only define RPCs (such as in this case) and/or notifications.  In yet another example, the YANG module may be only for use with RESTCONF (not NETCONF), and thus mentioning NETCONF at all would be odd (i.e., RFC 8572).

In such cases, strict adherence to the template does not make sense.  As chair/shepherd/author, I’ve struggled with how to best satisfy the intention adequately.   Of course, each case varies, but one idea that I’ve been exploring is to start the section with a disclaimer explaining why/how template [1] is (or not) followed.  This approach is appealing as it immediately conveys to the IESG that the template was not ignored.  However, it is unappealing in that it may be wrong for the published Security Considerations section to have a link to the template.

Please advise.
Kent  // as chair and shepherd

[1] https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines <https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines>