[NSIS] AD review comments of draft-ietf-nsis-qos-nslp-16
Magnus Westerlund <magnus.westerlund@ericsson.com> Thu, 01 October 2009 13:54 UTC
Return-Path: <magnus.westerlund@ericsson.com>
X-Original-To: nsis@core3.amsl.com
Delivered-To: nsis@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 408FA3A696A for <nsis@core3.amsl.com>; Thu, 1 Oct 2009 06:54:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.732
X-Spam-Level:
X-Spam-Status: No, score=-5.732 tagged_above=-999 required=5 tests=[AWL=0.517, BAYES_00=-2.599, HELO_EQ_SE=0.35, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eCJus1F8-MMd for <nsis@core3.amsl.com>; Thu, 1 Oct 2009 06:54:30 -0700 (PDT)
Received: from mailgw4.ericsson.se (mailgw4.ericsson.se [193.180.251.62]) by core3.amsl.com (Postfix) with ESMTP id D2A033A688B for <nsis@ietf.org>; Thu, 1 Oct 2009 06:54:29 -0700 (PDT)
X-AuditID: c1b4fb3e-b7b63ae0000049dc-c8-4ac4b4e5c39b
Received: from esealmw127.eemea.ericsson.se (Unknown_Domain [153.88.253.125]) by mailgw4.ericsson.se (Symantec Mail Security) with SMTP id 02.1C.18908.5E4B4CA4; Thu, 1 Oct 2009 15:55:49 +0200 (CEST)
Received: from esealmw127.eemea.ericsson.se ([153.88.254.175]) by esealmw127.eemea.ericsson.se with Microsoft SMTPSVC(6.0.3790.3959); Thu, 1 Oct 2009 15:54:26 +0200
Received: from [147.214.183.250] ([147.214.183.250]) by esealmw127.eemea.ericsson.se with Microsoft SMTPSVC(6.0.3790.3959); Thu, 1 Oct 2009 15:54:26 +0200
Message-ID: <4AC4B492.6070005@ericsson.com>
Date: Thu, 01 Oct 2009 15:54:26 +0200
From: Magnus Westerlund <magnus.westerlund@ericsson.com>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: NSIS <nsis@ietf.org>, draft-ietf-nsis-qos-nslp@tools.ietf.org
X-Enigmail-Version: 0.96.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
X-OriginalArrivalTime: 01 Oct 2009 13:54:26.0797 (UTC) FILETIME=[B08FF1D0:01CA429E]
X-Brightmail-Tracker: AAAAAA==
Subject: [NSIS] AD review comments of draft-ietf-nsis-qos-nslp-16
X-BeenThere: nsis@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Next Steps in Signaling <nsis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/nsis>, <mailto:nsis-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/nsis>
List-Post: <mailto:nsis@ietf.org>
List-Help: <mailto:nsis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nsis>, <mailto:nsis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Oct 2009 13:54:31 -0000
Hi, I have finally completed my AD review of the QoS NSLP and QSPEC documents. QSPEC will be dealt in a separate email. But here are my questions and comments. A. Section 3.1.2: Please expand DSCP on its first usage. B. Section 3.1.3 contains a reference to draft-manner-nsis-nslp-auth. This is an informational reference. But I do wonder about the security solution and its need to carry authentication information. No, I don't want to make this a normative reference. But I do wonder how the WG plans to present the lack of even one fully specified security solution, even if this is going for experimental. C. Section 3.2.12.1: How long does it take to detect that a new down stream peer exist, or that truncation has happened? D. Section 4.6, page 35, second paragraph. It is not clear to me how (1) can be guaranteed to arrive prior to (2), or if both message are sent width bound to the other one? E. Section 4.7.1, page 39: "Note that the egress should use a timer, with a preconfigured value, that can be used to synchronise the arrival of both messages, i.e., the end-to-end RESERVE message and the local RESERVE' message." I can't understand this "using a timer for synchronization" in this sentence. F. Section 5.1.2.1: "If the session of this message is bound to another session, then the RESERVE message SHOULD include the SESSION_ID of that other session in a BOUND_SESSION_ID object." Why a SHOULD here. Please explain when you could or should break the SHOULD. G. Section 5.1.2.2: "A QUERY message MAY contain a second QSPEC object." QUERY = COMMON_HEADER [ RII ][ *BOUND_SESSION_ID ] [ PACKET_CLASSIFIER ] [ INFO_SPEC ] QSPEC The BNF seem to not allow for a second QSPEC object. H. Section 5.1.3: "The remaining bits marked 'r' are reserved." There are no definition of the meaning of reserved bits. I assume SHALL be set to 0, SHALL be ignored on reception? I. Section 5.1.3.5: "The method-specific classifier data is two bytes long and consists of a set of flags: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |X|Y|P|T|F|S|A|B| Reserved | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+" This seems to be 4 bytes, and not 2. J. Section 5.1.3.6 " Offset: The byte in the object at which the QNE found the error. When this field is set to "0", the complete object is included." I don't get these two sentences to match. First sentence says this is a pointer to where the error is. Second sentence indicates that the object has been truncated upto the given offset. Please clarify. K. Section 5.3.6: " A SESSION_ID_LIST is carried in RESERVE messages. It is used in two cases, to refresh or two tear down the indicated sessions. " Second "two" should be a "to"? L. Section 6. Please update reference to RFC 5226. M. Section 7. "The protocol mechanisms s in this document try to minimize exhaustion attacks against these resources when performing authentication and authorization for QoS resources." Is the lone "s" after mechanisms intended? -- Magnus Westerlund IETF Transport Area Director ---------------------------------------------------------------------- Multimedia Technologies, Ericsson Research EAB/TVM ---------------------------------------------------------------------- Ericsson AB | Phone +46 10 7148287 Färögatan 6 | Mobile +46 73 0949079 SE-164 80 Stockholm, Sweden| mailto: magnus.westerlund@ericsson.com ----------------------------------------------------------------------
- [NSIS] AD review comments of draft-ietf-nsis-qos-… Magnus Westerlund
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Roland Bless
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Jukka Manner
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Jukka Manner
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Georgios Karagiannis
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Roland Bless
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Roland Bless
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Jukka MJ Manner
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Magnus Westerlund
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Jukka Manner
- Re: [NSIS] AD review comments of draft-ietf-nsis-… Magnus Westerlund