[Ntp] Genart last call review of draft-ietf-ntp-packet-timestamps-07

Russ Housley via Datatracker <noreply@ietf.org> Fri, 07 February 2020 19:42 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ntp@ietf.org
Delivered-To: ntp@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D8C212089C; Fri, 7 Feb 2020 11:42:37 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: last-call@ietf.org, ntp@ietf.org, draft-ietf-ntp-packet-timestamps.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.117.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Russ Housley <housley@vigilsec.com>
Message-ID: <158110455747.11678.12613654963980490395@ietfa.amsl.com>
Date: Fri, 07 Feb 2020 11:42:37 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/Axj_6pJOPRtta6A8e_T3gA1yCzI>
Subject: [Ntp] Genart last call review of draft-ietf-ntp-packet-timestamps-07
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Feb 2020 19:42:38 -0000

Reviewer: Russ Housley
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-ntp-packet-timestamps-07
Reviewer: Russ Housley
Review Date: 2020-02-07
IETF LC End Date: 2020-02-20
IESG Telechat date: Unknown


Summary: Almost Ready

Major Concerns: None


Minor Concerns:

Abstract: It is too long.  In my opinion, the second paragraph should
be moved to the Introduction.


Section 2.1: Please use:

   The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
   "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and
   "OPTIONAL" in this document are to be interpreted as described in
   BCP 14 [RFC2119] [RFC8174] when, and only when, they appear in all
   capitals, as shown here.


Section 2.3, paragraph 1: I think it would be better to define timestamp
error without using the phrase "device under test".  If you disagree,
please add a definition for "device under test".


Section 3, Synchronization aspects: The paragraph should also say that
there might not be any synchronization considerations.  For example, an
epoch since the device was powered up does not have any.


Section 9:  Please say "such as Message Authentication Codes (MAC)".
HMAC is one instance of a MAC, and you are not trying to name a specific
algorithm here.


Section 11.2:  RFC 1323 has been obsoleted by RFC 7323.  Is there a
reason that it is better ot reference the older document here?


Nits:

General: Some places this Internet-Draft refers to itself as "this memo"
and other places if refers to itself as "this document".  Please pick.


Section 1, paragraph 1: Nonces often have a timestamp embedded in them.
For example, TLS 1.2 [RFC5246] defined the nonce as:

         struct {
             uint32 gmt_unix_time;
             opaque random_bytes[28];
         } Random;

So, I think the paragraph should include something about using time to
create an unlikely to repeat value.


Section 3: I do not find the "+" improves readability.


Section 3 says:

      The structure of the timestamp field consists of:

      + Size: The number of bits (or octets) used to represent the
      packet timestamp field.  If the timestamp is comprised of more
      than one field, the size of each field is specified.

Since there is only one item, I suggest:

      Size: The structure of the timestamp field consists of the number
      of bits (or octets) used to represent the packet timestamp field.
      If the timestamp is comprised of more than one field, the size of
      each field is specified.


Questions:

Should RFC 6019 be included in the table in Section 6?