[Ntp] [Technical Errata Reported] RFC5905 (5978)

RFC Errata System <rfc-editor@rfc-editor.org> Sat, 08 February 2020 18:10 UTC

To: mills@udel.edu, jrmii@isc.org, jack.burbank@jhuapl.edu, william.kasch@jhuapl.edu, suresh@kaloom.com, evyncke@cisco.com, dsibold.ietf@gmail.com, odonoghue@isoc.org
From: RFC Errata System <rfc-editor@rfc-editor.org>
Cc: david.verbree@dornerworks.com, ntp@ietf.org, rfc-editor@rfc-editor.org
Content-Type: text/plain; charset="UTF-8"
Message-Id: <20200208180959.458BDF406DB@rfc-editor.org>
Date: Sat, 08 Feb 2020 10:09:59 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/jYMfm3cLrz-6f5ADZkg_nN6nyKE>
Subject: [Ntp] [Technical Errata Reported] RFC5905 (5978)
Precedence: list

The following errata report has been submitted for RFC5905,
"Network Time Protocol Version 4: Protocol and Algorithms Specification".

--------------------------------------
You may review the report below and at:
https://www.rfc-editor.org/errata/eid5978

--------------------------------------
Type: Technical
Reported by: David Verbree <david.verbree@dornerworks.com>

Section: A.5.1.1.

Original Text
-------------

    /*
        * Verify valid root distance.
        */
    if (r->rootdelay / 2 + r->rootdisp >= MAXDISP || p->reftime >
        r->xmt)
            return;                 /* invalid header values */


Corrected Text
--------------

    /*
        * Verify valid root distance.
        */
    if (p->rootdelay / 2 + p->rootdisp >= MAXDISP || p->reftime >
        r->xmt)
            return;                 /* invalid header values */


Notes
-----
The r->rootdelay and r->rootdisp are the received values not in double format and therefore, should not be compared against MAXDISP. Use the p->rootdelay and p->rootdisp instead which have already been converted to double via FP2D macro.

Instructions:
-------------
This erratum is currently posted as "Reported". If necessary, please
use "Reply All" to discuss whether it should be verified or
rejected. When a decision is reached, the verifying party  
can log in to change the status and edit the report, if necessary. 

--------------------------------------
RFC5905 (draft-ietf-ntp-ntpv4-proto-13)
--------------------------------------
Title               : Network Time Protocol Version 4: Protocol and Algorithms Specification
Publication Date    : June 2010
Author(s)           : D. Mills, J. Martin, Ed., J. Burbank, W. Kasch
Category            : PROPOSED STANDARD
Source              : Network Time Protocol
Area                : Internet
Stream              : IETF
Verifying Party     : IESG

[Ntp] [Technical Errata Reported] RFC5905 (5978) RFC Errata System