Re: [Ntp] New Version Notification for draft-rsalz-update-registries-00.txt

Miroslav Lichvar <mlichvar@redhat.com> Thu, 07 January 2021 10:48 UTC

Return-Path: <mlichvar@redhat.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5BED23A0EC8 for <ntp@ietfa.amsl.com>; Thu, 7 Jan 2021 02:48:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.37
X-Spam-Level:
X-Spam-Status: No, score=-2.37 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fML1qdbuofnl for <ntp@ietfa.amsl.com>; Thu, 7 Jan 2021 02:48:54 -0800 (PST)
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 962B03A0EC4 for <ntp@ietf.org>; Thu, 7 Jan 2021 02:48:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610016533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5mBE3QY/97hlb884TBl/n6YiWG0vsa/D0vXlFNtNkfE=; b=EeqwkiVGsEVQtAWZa//B8dXSVNCQ2BfHSTG93OWrSOcIUuxhlwJK18b1q55KQ3+/wNQ4TJ +0gQ9VrgUv3Km+pHTm14iPfGxubRVaCtsSi9RKN2D4w8woI60SxqoLox6XWd5CIyroEw2+ kvKh0UJgtGfMUuvv6byJipROKzSM570=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-CEgdVNAfOf2NQSR8u9e6PA-1; Thu, 07 Jan 2021 05:48:51 -0500
X-MC-Unique: CEgdVNAfOf2NQSR8u9e6PA-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 147D1801817; Thu, 7 Jan 2021 10:48:49 +0000 (UTC)
Received: from localhost (holly.tpb.lab.eng.brq.redhat.com [10.43.134.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5732C5D9DD; Thu, 7 Jan 2021 10:48:48 +0000 (UTC)
Date: Thu, 07 Jan 2021 11:48:46 +0100
From: Miroslav Lichvar <mlichvar@redhat.com>
To: "Salz, Rich" <rsalz=40akamai.com@dmarc.ietf.org>
Cc: "ntp@ietf.org" <ntp@ietf.org>
Message-ID: <20210107104846.GC3414631@localhost>
References: <160866842930.12375.2768184613474168188@ietfa.amsl.com> <8E362353-B91C-445B-B16E-166BE3A9045A@akamai.com> <20210104144735.GA2992437@localhost> <3FBAA9E7-A251-4C68-9231-A0271227EF6C@akamai.com> <43EFABEB-5829-443B-A29B-C3B4D1228BFD@akamai.com>
MIME-Version: 1.0
In-Reply-To: <43EFABEB-5829-443B-A29B-C3B4D1228BFD@akamai.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlichvar@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/Frv3CW8rAmu0YSlz_bakdoRQWFg>
Subject: Re: [Ntp] New Version Notification for draft-rsalz-update-registries-00.txt
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jan 2021 10:48:56 -0000

On Wed, Jan 06, 2021 at 03:42:19PM +0000, Salz, Rich wrote:
>  This document marks the erroneous values as reserved.
> +- The field type registry includes the Field Type, as defined in Figure
> +14 of {{!RFC5905}}, but also the length. This is arguably an error, but
> +one we will preserve as existing software might depend on the length values
> +being fixed.

That doesn't seem right to me. The field type registry doesn't include
the length. All values there are 16-bit. The length is in the other 16
bits of the 32-bit EF header.

> -- Field Types in the range 0xD000 throught 0xFFFF, inclusive, are reserved
> +- Field Types in the range 0xD000 through 0xFF00, inclusive, are reserved

If we wanted to avoid non-zero values in the Autokey error and
response flags, the range would be 0x3000 through 0x3FFF. 

> -- Field Type (required): A two-byte value in hexadecimal.
> +- Field Type (required): A four-byte value in hexadecimal, that includes
> +the type as the top two bytes and the length as the bottom two.

Just 16 bits for the type, no length. (bytes are arch-specific.)

-- 
Miroslav Lichvar