Re: [Ntp] New Version Notification for draft-rsalz-update-registries-00.txt

"Salz, Rich" <rsalz@akamai.com> Wed, 06 January 2021 15:42 UTC

Return-Path: <rsalz@akamai.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B5DB3A0F06; Wed, 6 Jan 2021 07:42:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.349
X-Spam-Level:
X-Spam-Status: No, score=-2.349 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=akamai.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GwWYipGE2m-P; Wed, 6 Jan 2021 07:42:25 -0800 (PST)
Received: from mx0a-00190b01.pphosted.com (mx0a-00190b01.pphosted.com [IPv6:2620:100:9001:583::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F0A9D3A0F01; Wed, 6 Jan 2021 07:42:22 -0800 (PST)
Received: from pps.filterd (m0122333.ppops.net [127.0.0.1]) by mx0a-00190b01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 106FXre9032652; Wed, 6 Jan 2021 15:42:22 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=jan2016.eng; bh=P6sMmVlwQdkoTftZQ1bChmvc0DHP9tiEQfNIxH0fPlI=; b=g1NedgCu76/32QK//fqt5dj1c5qciR3WfzA2ZwL1JpkAv6Hfig1sXzhAL6ziJ8U8NYGQ BQkK5W29FOjyimSpCgMWqfqQuDVRLNUUayQgs26u4uL3zTQaflJb3VrFndSLmxV2SrKy Y/VjqzrqqYHrQvZGyG5855dA4OG3eC2CgXEFnXm/S6EG8wS1T+JBbq/cwJcPpQndswU0 eiqeVx07Rrp3xNR2/jq70d1avyWdaAVYjiWdCThqhJy9QvXCSxDFup7jvCs+TMk2+hTH bYmXUS/j5FXGJr1vGeuzQwcx5u9SHEwzMdMUX6+vesSWKl1caZnmyRbOSw31pExSh6NO Mw==
Received: from prod-mail-ppoint4 (a72-247-45-32.deploy.static.akamaitechnologies.com [72.247.45.32] (may be forged)) by mx0a-00190b01.pphosted.com with ESMTP id 35tgyjtkqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Jan 2021 15:42:22 +0000
Received: from pps.filterd (prod-mail-ppoint4.akamai.com [127.0.0.1]) by prod-mail-ppoint4.akamai.com (8.16.0.43/8.16.0.43) with SMTP id 106FYNxh011830; Wed, 6 Jan 2021 10:42:21 -0500
Received: from email.msg.corp.akamai.com ([172.27.123.30]) by prod-mail-ppoint4.akamai.com with ESMTP id 35tn235u3m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 06 Jan 2021 10:42:21 -0500
Received: from USMA1EX-DAG1MB1.msg.corp.akamai.com (172.27.123.101) by usma1ex-dag1mb4.msg.corp.akamai.com (172.27.123.104) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 10:42:20 -0500
Received: from USMA1EX-DAG1MB1.msg.corp.akamai.com ([172.27.123.101]) by usma1ex-dag1mb1.msg.corp.akamai.com ([172.27.123.101]) with mapi id 15.00.1497.010; Wed, 6 Jan 2021 10:42:20 -0500
From: "Salz, Rich" <rsalz@akamai.com>
To: "Salz, Rich" <rsalz=40akamai.com@dmarc.ietf.org>, Miroslav Lichvar <mlichvar@redhat.com>
CC: "ntp@ietf.org" <ntp@ietf.org>
Thread-Topic: [Ntp] New Version Notification for draft-rsalz-update-registries-00.txt
Thread-Index: AQHW2J/m8vwbIM2enE6DpP13y96nnKoDkAWAgBRjoID//69mAIADML2A
Date: Wed, 06 Jan 2021 15:42:19 +0000
Message-ID: <43EFABEB-5829-443B-A29B-C3B4D1228BFD@akamai.com>
References: <160866842930.12375.2768184613474168188@ietfa.amsl.com> <8E362353-B91C-445B-B16E-166BE3A9045A@akamai.com> <20210104144735.GA2992437@localhost> <3FBAA9E7-A251-4C68-9231-A0271227EF6C@akamai.com>
In-Reply-To: <3FBAA9E7-A251-4C68-9231-A0271227EF6C@akamai.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.44.20121301
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [172.27.118.139]
Content-Type: text/plain; charset="utf-8"
Content-ID: <C6A3F816D3B8FF4793C29408C2095E4E@akamai.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-06_09:2021-01-06, 2021-01-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060097
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-06_09:2021-01-06, 2021-01-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 clxscore=1015 spamscore=0 impostorscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060097
X-Agari-Authentication-Results: mx.akamai.com; spf=${SPFResult} (sender IP is 72.247.45.32) smtp.mailfrom=rsalz@akamai.com smtp.helo=prod-mail-ppoint4
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/dm7P7-ZmkfUJJfkiVtSP48j3-34>
Subject: Re: [Ntp] New Version Notification for draft-rsalz-update-registries-00.txt
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2021 15:42:27 -0000

     >   I liked the Daniel's idea to keep them both, the original values
        unchanged and then mark the swapped set as reserved, occupied, or
        similar.

>    If we're listing them as reserved, we should put them in the RFC.  I'll do that today or tomorrow.

New commit pushed to the repo, https://github.com/richsalz/draft-rsalz-update-registries/commit/2eecd8c308ade0a9f8dce6231f3cc8fcbc5e06bc

    >    I'm ok with the the proposed range 0xD000-0xFFFF for experimenal
        extension fields, but others here probably will not like it as it will
        randomly set the "response" and "error" flags in their interpretation
        of the value.

So the registry contains more than just the extension field type, it contains the length and those flag bits.  The following diff tries to capture that, is it correct?

And also where are the response and error flags defined?  A quick search in RFC 5905 didn't find anything obvious.
diff --git a/draft-rsalz-update-registries.md b/draft-rsalz-update-registries.md
index 7d62fdd..575d101 100644
--- a/draft-rsalz-update-registries.md
+++ b/draft-rsalz-update-registries.md
@@ -86,8 +86,12 @@ around the interaction with the Message Authentication Code (MAC) field.
 The following problems exists with the current registry:
 
 - Many of the entries in the Extension Field Types registry have
-swapped nibbles (half of a byte).
+swapped some of the bytes; 1234 is listed as 1432 for example.
 This document marks the erroneous values as reserved.
+- The field type registry includes the Field Type, as defined in Figure
+14 of {{!RFC5905}}, but also the length. This is arguably an error, but
+one we will preserve as existing software might depend on the length values
+being fixed.
 - Some values were mistakenly re-used.
 
 ## Network Time Security Registries
@@ -174,7 +178,7 @@ possible, replace the existing 5905 with 5906.
 
 The following Note is added:
 
-- Field Types in the range 0xD000 throught 0xFFFF, inclusive, are reserved
+- Field Types in the range 0xD000 through 0xFF00, inclusive, are reserved
 for experimentation and development. IANA cannot assign them.
 Both NTS Cookie and Autokey Message Request have the same Field Type;
 in practice this is not a problem as the field semantics will be
@@ -182,7 +186,8 @@ determined by other parts of the message.
 
 The columns are defined as follows:
 
-- Field Type (required): A two-byte value in hexadecimal.
+- Field Type (required): A four-byte value in hexadecimal, that includes
+the type as the top two bytes and the length as the bottom two.
 
 - Meaning (required): A brief text description of the field type.