Re: [OAUTH-WG] Last Call Review of draft-ietf-oauth-json-web-token-25

Mike Jones <Michael.Jones@microsoft.com> Wed, 03 September 2014 01:46 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E16F01A8949; Tue, 2 Sep 2014 18:46:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U-8TTVAHSPwq; Tue, 2 Sep 2014 18:46:04 -0700 (PDT)
Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1lp0145.outbound.protection.outlook.com [207.46.163.145]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 953571A894A; Tue, 2 Sep 2014 18:46:03 -0700 (PDT)
Received: from BLUPR03CA007.namprd03.prod.outlook.com (10.255.124.24) by BY2PR03MB621.namprd03.prod.outlook.com (10.255.93.43) with Microsoft SMTP Server (TLS) id 15.0.1019.16; Wed, 3 Sep 2014 01:46:00 +0000
Received: from BL2FFO11FD010.protection.gbl (207.46.163.210) by BLUPR03CA007.outlook.office365.com (10.255.124.24) with Microsoft SMTP Server (TLS) id 15.0.1019.14 via Frontend Transport; Wed, 3 Sep 2014 01:45:59 +0000
Received: from mail.microsoft.com (131.107.125.37) by BL2FFO11FD010.mail.protection.outlook.com (10.173.161.16) with Microsoft SMTP Server (TLS) id 15.0.1010.11 via Frontend Transport; Wed, 3 Sep 2014 01:45:59 +0000
Received: from TK5EX14MBXC294.redmond.corp.microsoft.com ([169.254.3.122]) by TK5EX14HUBC106.redmond.corp.microsoft.com ([157.54.80.61]) with mapi id 14.03.0195.002; Wed, 3 Sep 2014 01:45:49 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Tom Taylor <tom.taylor.stds@gmail.com>, "draft-ietf-oauth-json-web-token.all@tools.ietf.org" <draft-ietf-oauth-json-web-token.all@tools.ietf.org>, Gen Art <gen-art@ietf.org>
Thread-Topic: Last Call Review of draft-ietf-oauth-json-web-token-25
Thread-Index: AQHPv0z0jG6qUdtWVkC2NMgTF7uzG5vussTg
Date: Wed, 03 Sep 2014 01:45:49 +0000
Message-ID: <4E1F6AAD24975D4BA5B16804296739439AE76189@TK5EX14MBXC294.redmond.corp.microsoft.com>
References: <53F95E44.2030307@gmail.com>
In-Reply-To: <53F95E44.2030307@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [157.54.51.70]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report: CIP:131.107.125.37; CTRY:US; IPV:CAL; IPV:NLI; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(6009001)(438002)(377454003)(479174003)(13464003)(199003)(189002)(51914003)(83072002)(85852003)(77982001)(86362001)(107046002)(19580405001)(106466001)(83322001)(19580395003)(81342001)(81156004)(106116001)(97756001)(15202345003)(6806004)(99396002)(44976005)(85306004)(4396001)(2656002)(23726002)(21056001)(90102001)(79102001)(76482001)(87936001)(55846006)(230783001)(92566001)(92726001)(50466002)(74502001)(77096002)(31966008)(86612001)(46406003)(50986999)(76176999)(54356999)(95666004)(46102001)(81542001)(15975445006)(47776003)(20776003)(64706001)(69596002)(97736001)(84676001)(74662001)(68736004)(33656002)(66066001)(80022001)(26826002)(104016003); DIR:OUT; SFP:; SCL:1; SRVR:BY2PR03MB621; H:mail.microsoft.com; FPR:; MLV:ovrnspm; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;UriScan:;
X-O365ENT-EOP-Header: Message processed by - O365_ENT: Allow from ranges (Engineering ONLY)
X-Forefront-PRVS: 032334F434
Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates 131.107.125.37 as permitted sender) receiver=protection.outlook.com; client-ip=131.107.125.37; helo=mail.microsoft.com;
Authentication-Results: spf=pass (sender IP is 131.107.125.37) smtp.mailfrom=Michael.Jones@microsoft.com;
X-OriginatorOrg: microsoft.onmicrosoft.com
Archived-At: http://mailarchive.ietf.org/arch/msg/oauth/Bgjcx6BrkmkayunJUvjgb4Devag
Cc: "oauth@ietf.org" <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Last Call Review of draft-ietf-oauth-json-web-token-25
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Sep 2014 01:46:06 -0000

Thanks for the review, Tom.  I've cc'ed the OAuth working group so that they're aware of the contents of your review.

				-- Mike

-----Original Message-----
From: Tom Taylor [mailto:tom.taylor.stds@gmail.com] 
Sent: Saturday, August 23, 2014 8:39 PM
To: draft-ietf-oauth-json-web-token.all@tools.ietf.org; Gen Art
Subject: Last Call Review of draft-ietf-oauth-json-web-token-25

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments you may receive.

Document: draft-ietf-oauth-json-web-token-25
Reviewer: Tom Taylor
Review Date: 23/08/2014
IETF LC End Date: 3/09/2014
IESG Telechat date: TBD

Summary: This draft is good to go. IDNits complains about the non-use of RFC 4648 (normative) but this is the Base64 specification invoked by "base64url". I did not re-verify the examples (done by the Document Shepherd).

Major issues:

Minor issues:

Nits/editorial comments: