[OPS-DIR]Re: Opsdir last call review of draft-ietf-regext-rdap-geofeed-09
Dhruv Dhody <dd@dhruvdhody.com> Mon, 21 April 2025 12:39 UTC
Return-Path: <dd@dhruvdhody.com>
X-Original-To: ops-dir@mail2.ietf.org
Delivered-To: ops-dir@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 1011F1ECB4AB for <ops-dir@mail2.ietf.org>; Mon, 21 Apr 2025 05:39:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (2048-bit key) header.d=dhruvdhody-com.20230601.gappssmtp.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uGkiFk8qmzWr for <ops-dir@mail2.ietf.org>; Mon, 21 Apr 2025 05:39:45 -0700 (PDT)
Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id EEDCB1ECB456 for <ops-dir@ietf.org>; Mon, 21 Apr 2025 05:39:44 -0700 (PDT)
Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-2cc9045bae9so514211fac.3 for <ops-dir@ietf.org>; Mon, 21 Apr 2025 05:39:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvdhody-com.20230601.gappssmtp.com; s=20230601; t=1745239184; x=1745843984; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gVJf2Ez1V0eH8aIeGDd4lCOOvqa0hngU8r0Lz5TREL0=; b=OZ+tDqmg9yAhrnLaGBjk/Wjx/JgmZwnDI4ELD3kKOM64ri4gcKtwfiw8GEhnQK8YAa lyyq4U6eWoG5FUDU9JnZNtwa5tOUxA3xUkKbwpqtVhJ/c1y5W3SjaKie95aRsmR6hHXz A5KA6fT+7H4yjqJJsdgOilPQ+uA6cWDtX1irFzUJyRuM/McacN2EwUS3K5Zzl4zgL7o4 0xywAQsC7cB2iBqFmZCI0Y6wiUKdgbf8bp2fM0YbcaURVobRV/2tNJYdasnd+mwROEwU /JuvyoEZWmDQaZJJJ+Vi1+UZZvjjvHjDDcG8xkfa/MK7sk+bmKFU1lBSwZN8ssdPDGZn Sn1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745239184; x=1745843984; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gVJf2Ez1V0eH8aIeGDd4lCOOvqa0hngU8r0Lz5TREL0=; b=PtNRGhZlHPepfzKe8dxvh1xLL31EUIQ3lYuPqJpKAnTM9QmKUO3lz+NDht0aFUekhl QsNI+bKHBHn+dglggJiOGfFe82J8pm6rPd/xFLE0t7PvEa/nr5cl+Wu0h79H7NGA2he2 zHAD2nLwV0G1uJuQF4NKS9tdeMrkw0NjT/7BtOo8HwjbO0EIHuxcy4pBCJLUMVEi4fOY t+3yexMWSyfEDQzkldtkoT+elKhdNi4m1S6OExqCDCsm2HHsVqQ2q4F3PeqauoGI2rSf RJ5tKtPXBI1pulUnOKcz1zDmCr9JGgsk92Ye9CodMUdVd+RFikaqexRHtVc1VGs56Gq0 n8aA==
X-Gm-Message-State: AOJu0YzOdKNJJPjMbfSRT8ibQIKRAtRwrcxwWS8+UC8KlcQcgpIhs8YN EK+xDy85E6dI1kUXKJW990/VChkWQiMjdGlQwzbtWrHji7N9WjMsTpXXESMRCRnGn7bjcMK3/ra uBpmA5VAKuAZo6soQU4V/e/JgFWf8RGQ+fXkoN17Jtv5L2wn9d08=
X-Gm-Gg: ASbGnctX+Wkd+3g0Wmo04+YqJ9G9nYINzLkZ5IYie2MxybZHwZZmzoE/4YmPJRmWtOi fqDQwIYv2Uzz6cirBD+5tI+DgnxNCTgIzhxI6FG7hRe1slgtwEjceRGFq7D6n8io5cibx/JW7qx IzvW6tf82dFeWbWNFF4rVbmhwqzQj1oeTcDixZFSq3xSQRI6ACHALVU4ao
X-Google-Smtp-Source: AGHT+IEgXTIZ1zdLpEKCaTMkgBYTPsuTAo+zDJFEa8LEjfAtHJQyc6QvNsXbkxYtrBcT9/mCgStw70YOvGhe8PufELk=
X-Received: by 2002:a05:6871:820c:b0:2d4:e101:13d5 with SMTP id 586e51a60fabf-2d526be74e2mr2340462fac.5.1745239184224; Mon, 21 Apr 2025 05:39:44 -0700 (PDT)
MIME-Version: 1.0
References: <174353271675.2440149.6559246021577295477@dt-datatracker-5b9b68c5b6-zxk6z> <PH7PR15MB60842037AC6ED90CDCDC1D5CC9BD2@PH7PR15MB6084.namprd15.prod.outlook.com>
In-Reply-To: <PH7PR15MB60842037AC6ED90CDCDC1D5CC9BD2@PH7PR15MB6084.namprd15.prod.outlook.com>
From: Dhruv Dhody <dd@dhruvdhody.com>
Date: Mon, 21 Apr 2025 18:09:07 +0530
X-Gm-Features: ATxdqUHMMR5PTvJULeH1DRKHcIMkPwY3-2m6AEJMj2ZM0-IUUH42WYMJfcLhhu4
Message-ID: <CAP7zK5Y_hbfKuxT81Ok_caGNL8r9tusmtju4tTXJBzqArDE0Mw@mail.gmail.com>
To: Jasdip Singh <jasdips@arin.net>
Content-Type: multipart/alternative; boundary="0000000000009fcf4e0633492976"
Message-ID-Hash: 3QZYWSKFDLQZKMZ6747XWPH553YIKRFE
X-Message-ID-Hash: 3QZYWSKFDLQZKMZ6747XWPH553YIKRFE
X-MailFrom: dd@dhruvdhody.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-ops-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "ops-dir@ietf.org" <ops-dir@ietf.org>, "draft-ietf-regext-rdap-geofeed.all@ietf.org" <draft-ietf-regext-rdap-geofeed.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "regext@ietf.org" <regext@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [OPS-DIR]Re: Opsdir last call review of draft-ietf-regext-rdap-geofeed-09
List-Id: Ops Directorate <ops-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/ops-dir/TH4161pQrqV1bLN2MMd0QRyJdfo>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ops-dir>
List-Help: <mailto:ops-dir-request@ietf.org?subject=help>
List-Owner: <mailto:ops-dir-owner@ietf.org>
List-Post: <mailto:ops-dir@ietf.org>
List-Subscribe: <mailto:ops-dir-join@ietf.org>
List-Unsubscribe: <mailto:ops-dir-leave@ietf.org>
Hi Jasdip, Thanks for handling my comments! Regards, Dhruv On Thu, Apr 17, 2025 at 12:35 AM Jasdip Singh <jasdips@arin.net> wrote: > Hi Dhruv, > > > > Thank you for your review of this draft. Please find below our comments. > > > > Also, please see [1] for the diffs in the updated draft. > > > > Thanks, > > Jasdip & Tom > > > > [1] > https://author-tools.ietf.org/iddiff?url2=draft-ietf-regext-rdap-geofeed-10 > > > > > > *From: *Dhruv Dhody via Datatracker <noreply@ietf.org> > *Date: *Tuesday, April 1, 2025 at 2:38 PM > *To: *ops-dir@ietf.org <ops-dir@ietf.org> > *Cc: *draft-ietf-regext-rdap-geofeed.all@ietf.org < > draft-ietf-regext-rdap-geofeed.all@ietf.org>, last-call@ietf.org < > last-call@ietf.org>, regext@ietf.org <regext@ietf.org> > *Subject: *Opsdir last call review of draft-ietf-regext-rdap-geofeed-09 > > Reviewer: Dhruv Dhody > Review result: Has Nits > > # OPSDIR Review of draft-ietf-regext-rdap-geofeed-09 > > I have reviewed this document as part of the Operational directorate's > ongoing > effort to review all IETF documents being processed by the IESG. These > comments > were written to improve the operational aspects of the IETF drafts. > Comments > that are not addressed in the last call may be included in AD reviews > during > the IESG review. Document editors and WG chairs should treat these comments > just like any other last-call comments. > > The document includes a dedicated Operational Considerations section. > Thanks > for including that. > > > > [JS] Indeed. :) > > > > ## Minor > > - Section 6.2 mentions that 1 in "geofeed1" stands for version 1. It would > make > sense to state that much earlier in the Introduction itself. > > > > [JS] Thanks for this observation! Since the RDAP extension ids are > presently opaque with no explicit versioning meaning to be derived, we > would prefer to change the intended usage verbiage in section 6.2 by > removing “version 1 of” as follows: > > > > “Intended usage: This extension describes a method to access the IP > geolocation feed data through RDAP.” > > > > > - Use the boilerplate text verbatim from RFC 8174. > > > > [JS] Thanks, updated. > > > - I am unsure why this text is needed - "Indentation and whitespace in > examples > are provided only to illustrate element relationships, and are not a > REQUIRED > feature of this protocol."; Isn't it a standard JSON practice? Also, does > it > make sense to call this geofeed extension 'this protocol'? > > > > [JS] Mentioning this is a precedent for the recent RDAP related drafts; to > be explicitly clear in case a reader was expecting a more compact JSON. > However, it is a good point about using “this protocol”. We have changed it > to “this specification”. Hope that reads better. > > > > - Is there a need to add a reference for "(Section 3.11 of > [I-D.shafranovich-rfc4180-bis])". The I-D is expired, and the section is > about > common implementation concerns with comments. > > > > [JS] That’s a good point. Removed that expired reference. > > > > - "In RDAP, the "value", "rel", and "href" JSON members are REQUIRED for > any > link object." -> If this is coming from RFC 9083, then rephrase this by > including a reference and removing 'REQUIRED'. > > > > [JS] Since the relevant Links section from RFC 9083 is referenced in the > previous paragraph, changed “REQUIRED” to “required”. > > > > - I understand that typically you will get one geofeed link object, but you > allow for more. In the case of more (and not just the multiple language > case), > is there any guidance for applications on what to do if they get multiple > link > objects? > > > > [JS] Since the multiple-languages scenario is the only one we can think of > where more than one geofeed link objects are possible, in our opinion, it > would be clearer to prohibit more than one geofeed link objects otherwise. > To that effect, updated that paragraph as follows: > > “An IP network object returned by an RDAP server MAY contain zero or more > geofeed link objects, though typically an IP network will have either no > such link objects or only one. The scenario where more than one geofeed > link object could be returned is when the server is able to represent that > data in multiple languages. In such a case, the server SHOULD provide > "hreflang" members for the geofeed link objects. Except for the > multiple-languages scenario, the server MUST NOT return more than one > geofeed link object.” > > Hope this helps clarify. > > > - "...it may be useful to define new RDAP extensions..." ; Is it useful or > not? > The reason given makes sense to me; why not just say that it is useful :) > > > > [JS] Good point. Updated. > > > - "Person & email address to contact for further information" - should > this be > WG or art@ietf.org? > > > > [JS] Reviewing some previous media type registrations, it seems to vary > from individuals to the WG. To your suggestion, changed it to the REGEXT WG. > > > > Also, "Author/Change Controller: IETF" should be used for > Sections 6.3 and 6.4 > > > > [JS] OK. Replaced “Change Controller” field with "Author/Change > Controller” in section 6.3 and added "Author/Change Controller” in section > 6.4. > > > > - The formatting of "Fragment Identifier Considerations:" in section 6.4 > is off. > > > > [JS] Thanks, fixed. > > > ## Nits > > - Add reference for rdapConformance (RFC 9083?) > > > > [JS] Indeed. Done as part of addressing feedback from another IESG review. > > > > ## Downref > > * Downref: Normative reference to an Informational RFC: RFC 4180 > > * Downref: Normative reference to an Informational RFC: RFC 7111 > > * Downref: Normative reference to an Informational RFC: RFC 8805 > > > > [JS] Thanks, they are down-referenced now. > > > >
- [OPS-DIR]Opsdir last call review of draft-ietf-re… Dhruv Dhody via Datatracker
- [OPS-DIR]Re: Opsdir last call review of draft-iet… Jasdip Singh
- [OPS-DIR]Re: Opsdir last call review of draft-iet… Dhruv Dhody
- [OPS-DIR]Re: Opsdir last call review of draft-iet… mohamed.boucadair